- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix ClassCastException in SearchableListModel
by tnisan＠redhat.com 26 Jan '16

26 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix ClassCastException in SearchableListModel ...................................................................... webadmin: Fix ClassCastException in SearchableListModel When new items are selected and determineSelectedItems tries to restore the selection, it blindly assumes that the list item is a subclass of IVdcQueryable which is now always the case: e.g. in the ImportVmModel. Change-Id: I679f132a2d23e285bd12380837d9eea58fb5f55d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293269 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModelTest.java 2 files changed, 42 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/52755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I679f132a2d23e285bd12380837d9eea58fb5f55d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: frontend: Fix NPE in ImportVms Dialog
by tnisan＠redhat.com 26 Jan '16

26 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix NPE in ImportVms Dialog ...................................................................... frontend: Fix NPE in ImportVms Dialog Change-Id: I42b3837321eaf8684a23b410afff2d15e9f13773 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293269 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/52754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42b3837321eaf8684a23b410afff2d15e9f13773 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: frontend: Fix name uniqueness chack in ImportVmModel
by tnisan＠redhat.com 26 Jan '16

26 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix name uniqueness chack in ImportVmModel ...................................................................... frontend: Fix name uniqueness chack in ImportVmModel Now when checking the name uniqueness of imported VM, we check for conflict only VMs in target data center. To facilitate this the data center loading part from ImportVmFromExportDomainModel#doInit() and ImportVmFromExternalProviderModel#doInit() had to be extracted into special helpers withDataCenterLoaded() that are used to wrap the setItems() method doing the name uniqueness analysis - since it requires access to storagePool.id. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912263 Change-Id: I86c8b17bee0d676bc09c758e98439e5d672eb885 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 4 files changed, 102 insertions(+), 79 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/52706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86c8b17bee0d676bc09c758e98439e5d672eb885 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Populate vm.placement_policy.affinity
by juan.hernandez＠redhat.com 26 Jan '16

26 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Populate vm.placement_policy.affinity ...................................................................... restapi: Populate vm.placement_policy.affinity The vm.placement_policy.affinity element isn't currently populated correctly. This regression was probably introduced by the following patch: restapi: instance types need to have only the subset of template fields https://gerrit.ovirt.org/46722 This patch restores the correct behaviour. Change-Id: I969bfb53549212f5c1797dbd6605879a94cf5db1 Bug-Url: https://bugzilla.redhat.com/1301992 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I969bfb53549212f5c1797dbd6605879a94cf5db1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Do not assign creator as owner to VMs from pool
by tnisan＠redhat.com 26 Jan '16

26 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Do not assign creator as owner to VMs from pool ...................................................................... engine: Do not assign creator as owner to VMs from pool If VM is created to attach it to a VM pool, do not assign its creator as owner in any case. Assignment of a user to the VM in this case will designate this VM as occupied and prevent other users from taking it. This assignment happens currently when pool creator doesn't have MANIPULATE_PERMISSIONS role on the pool VMs. Change-Id: I6af18a2b7caa8181523a277f4d63cc688e69a59e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1301867 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmAndAttachToPoolParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java 4 files changed, 15 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6af18a2b7caa8181523a277f4d63cc688e69a59e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix remove disk snapshots for cinder
by derez＠redhat.com 26 Jan '16

26 Jan '16

Daniel Erez has submitted this change and it was merged. Change subject: core: fix remove disk snapshots for cinder ...................................................................... core: fix remove disk snapshots for cinder Fix init on remove disk snapshots command for Cinder disks flow. The 'representativeImage' can be null when using CoCo after the disk snapshot has been removed and the command is in the ending phase. Change-Id: Iec6e9ef84e2dd4db63db25d6d5e52915828203c1 Bug-Url: https://bugzilla.redhat.com/1301340 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java 1 file changed, 21 insertions(+), 18 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52654 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec6e9ef84e2dd4db63db25d6d5e52915828203c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: missing constructor
by tnisan＠redhat.com 26 Jan '16

26 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: missing constructor ...................................................................... core: missing constructor absence of constructor which accepts EngineContext parameter can lead to runtime exceptions. Change-Id: I81ed218e127723855ecc8e2c71ce66b501f047fb Bug-Url: https://bugzilla.redhat.com/1299630 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllChildVlanInterfacesQuery.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81ed218e127723855ecc8e2c71ce66b501f047fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Fix typo: coNNect rather than conect
by alkaplan＠redhat.com 26 Jan '16

26 Jan '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Fix typo: coNNect rather than conect ...................................................................... engine: Fix typo: coNNect rather than conect Change-Id: I384200ee65a3853e8e118b7b09e5f6f856469657 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostSetupNetworksVdsCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java 3 files changed, 8 insertions(+), 8 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/52520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I384200ee65a3853e8e118b7b09e5f6f856469657 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Send MTU as int to VDSM in HostSetupNetworksVDSCommand
by alkaplan＠redhat.com 26 Jan '16

26 Jan '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Send MTU as int to VDSM in HostSetupNetworksVDSCommand ...................................................................... engine: Send MTU as int to VDSM in HostSetupNetworksVDSCommand VDSM side is ready for that move for a while... Change-Id: If4436c629529426cdc93d1ab913a1d555c2e2ec4 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/51052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4436c629529426cdc93d1ab913a1d555c2e2ec4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Add warning on live snapshot on VM without guest a...
by tnisan＠redhat.com 26 Jan '16

26 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add warning on live snapshot on VM without guest agent ...................................................................... webadmin: Add warning on live snapshot on VM without guest agent Change-Id: Icfd1b97515b1dbb03d84f03debb6afbfc3e26337 Bug-Url: https://bugzilla.redhat.com/1299513 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfd1b97515b1dbb03d84f03debb6afbfc3e26337 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0