- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.2]: core: make OsRepository injectable using @Inject
by tnisan＠redhat.com 18 Jan '16

18 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: make OsRepository injectable using @Inject ...................................................................... core: make OsRepository injectable using @Inject Created a producer method to retun the sole enum member implementing the interface. This is to reduce usage and stream line tests of OsRepository dependents and limit the use of SimpleDependencyInjector Change-Id: I707349d9db85f9ff5d1d77af89f2b2ff50ee5579 Bug-Url: https://bugzilla.redhat.com/1158096 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryProducer.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I707349d9db85f9ff5d1d77af89f2b2ff50ee5579 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix update of virtio_scsi.enabled
by tnisan＠redhat.com 18 Jan '16

18 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix update of virtio_scsi.enabled ...................................................................... restapi: Fix update of virtio_scsi.enabled Currently the "virtio_scsi.enabled" property is ignored by the update operations of virtual machines, templates and instance types. This patch fixes that. Change-Id: Id016e1006c5e07aacf80e6661e30b61d0c20a128 Bug-Url: https://bugzilla.redhat.com/1298489 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java 3 files changed, 13 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id016e1006c5e07aacf80e6661e30b61d0c20a128 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Upgrade to CDI 1.2
by mperina＠redhat.com 18 Jan '16

18 Jan '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Upgrade to CDI 1.2 ...................................................................... core: Upgrade to CDI 1.2 Removes hacks needed to support both CDI 1.0 (EAP6) and CDI 1.1+ (WildFly 8+). From now on we support only CDI 1.2. Change-Id: I3fec8f22a633dcf1fe866fab29cd26c2fa5a9e3d Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml M backend/manager/modules/dal/src/main/resources/META-INF/beans.xml M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/CdiIntegration.java M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M backend/manager/modules/utils/src/main/resources/META-INF/beans.xml M pom.xml 6 files changed, 23 insertions(+), 42 deletions(-) Approvals: Martin Peřina: Verified; Passed CI tests Juan Hernandez: Looks good to me, but someone else must approve Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fec8f22a633dcf1fe866fab29cd26c2fa5a9e3d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Upgrade to WildFly 10
by mperina＠redhat.com 18 Jan '16

18 Jan '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Upgrade to WildFly 10 ...................................................................... core: Upgrade to WildFly 10 1. Adds a requirement for WildFly 10 and corresponding WildFly overlay package. 2. Updates oVirt WildFly service configuration file to match latest updates in WildFly 10 3. Updates developer docs Change-Id: Ic230dcd4d9f138f9a125f7ed97b5fbaa358fe8a3 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M README.developer M ovirt-engine.spec.in M packaging/services/ovirt-engine/ovirt-engine.xml.in 3 files changed, 78 insertions(+), 51 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic230dcd4d9f138f9a125f7ed97b5fbaa358fe8a3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Drop EAP6 support
by mperina＠redhat.com 18 Jan '16

18 Jan '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Drop EAP6 support ...................................................................... core: Drop EAP6 support Drops EAP6 support from ovirt-engine.xml.in Change-Id: Ia2a46bd58106afed634c9ea059e8aefc5f7ccc25 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 0 insertions(+), 145 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2a46bd58106afed634c9ea059e8aefc5f7ccc25 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Added CPU Profiles Roles to the RoleTree
by rgolan＠redhat.com 18 Jan '16

18 Jan '16

Roy Golan has submitted this change and it was merged. Change subject: webadmin: Added CPU Profiles Roles to the RoleTree ...................................................................... webadmin: Added CPU Profiles Roles to the RoleTree CPU profile roles were added to the Role Tree in the UI. The roles are: CpuProfileCreator and CpuProfileOperator. Change-Id: Ib5e8b2b11a882fadadd1e6261fb574f871d4ec4c Bug-Url: https://bugzilla.redhat.com/1143869 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 49 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/51141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5e8b2b11a882fadadd1e6261fb574f871d4ec4c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fixing search engine queries
by emesika＠redhat.com 17 Jan '16

17 Jan '16

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing search engine queries ...................................................................... core: fixing search engine queries Search engine queries related to a view named clusters_storage_domain while the name should be cluster_storage_domain Change-Id: I6eaf6b8141d08df26a1815ecb4c9768baaa76a61 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6eaf6b8141d08df26a1815ecb4c9768baaa76a61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Fixed New Template dialog size
by derez＠redhat.com 17 Jan '16

17 Jan '16

Daniel Erez has submitted this change and it was merged. Change subject: userportal,webadmin: Fixed New Template dialog size ...................................................................... userportal,webadmin: Fixed New Template dialog size Changed the size of the New Template dialog in the user portal so elements won't slide off it. Change-Id: I28758fce935c6057d328f387e0838a035d6faa0f Bug-Url: https://bugzilla.redhat.com/1190142 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/51225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28758fce935c6057d328f387e0838a035d6faa0f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add VM compatibility version to ChangeVmClusterValidator
by ahadas＠redhat.com 17 Jan '16

17 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Add VM compatibility version to ChangeVmClusterValidator ...................................................................... core: Add VM compatibility version to ChangeVmClusterValidator This patch is part of the series introducing VM compatibility version feature. This feature allows to customize a VM to its own compatibility version unrelated to one of the cluster. VM compatibility version is limited by Data Center and capabilities of the host the VM will be able to run on. This patch adds VM compatibility version support to ChangeVmClusterValidator. Change-Id: Ic5e35963ba47aefd17a69495ed4f4187abbc34ad Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeVMClusterParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 7 files changed, 51 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5e35963ba47aefd17a69495ed4f4187abbc34ad Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: hosted-engine: missing config from engine-config
by tnisan＠redhat.com 17 Jan '16

17 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: hosted-engine: missing config from engine-config ...................................................................... core: hosted-engine: missing config from engine-config The HostedEngineStorageDomainName was missing from the DB and the engine-config properties. Change-Id: I99d39f73ebcf4eca3a3891c371c246660dda5611 Bug-Url: https://bugzilla.redhat.com/1290478 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Eli Mesika: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/51342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d39f73ebcf4eca3a3891c371c246660dda5611 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0