- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: hosted-engine: set the os type to linux on import
by tnisan＠redhat.com 17 Jan '16

17 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: hosted-engine: set the os type to linux on import ...................................................................... core: hosted-engine: set the os type to linux on import The imported VM is obviously linux so setting the type the the most basic linux os instead of "other" This fixes a bug when editing the VM because the values of the console are in the limits of linux and not valid for "other" os. Change-Id: I3520d6d0501e82aa135bdc896f8d994e02e30d74 Bug-Url: https://bugzilla.redhat.com/1158096 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Roy Golan: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3520d6d0501e82aa135bdc896f8d994e02e30d74 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: make OsRepository injectable using @Inject
by tnisan＠redhat.com 17 Jan '16

17 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: make OsRepository injectable using @Inject ...................................................................... core: make OsRepository injectable using @Inject Created a producer method to retun the sole enum member implementing the interface. This is to reduce usage and stream line tests of OsRepository dependents and limit the use of SimpleDependencyInjector Change-Id: I707349d9db85f9ff5d1d77af89f2b2ff50ee5579 Bug-Url: https://bugzilla.redhat.com/1158096 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryProducer.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I707349d9db85f9ff5d1d77af89f2b2ff50ee5579 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactoring vm-analyzer
by ahadas＠redhat.com 17 Jan '16

17 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refactoring vm-analyzer ...................................................................... core: refactoring vm-analyzer Refactoring VmAnalyzer#removeVmsFromCache: 1. Rename to removeVmFromCache 2. Extract the surrounding 'if' check to the caller Change-Id: I08fa5d780c85ccddaf7571a6dc1066661ad6dd39 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 40 insertions(+), 40 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08fa5d780c85ccddaf7571a6dc1066661ad6dd39 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fixed indexing on upgrade script
by rgolan＠redhat.com 17 Jan '16

17 Jan '16

Roy Golan has submitted this change and it was merged. Change subject: core: Fixed indexing on upgrade script ...................................................................... core: Fixed indexing on upgrade script Removed the explicit mentioning of "USING btree" from an upgrade script. Change-Id: I817d57833630ac386c9fbdf70139439dbfc1be07 Bug-Url: https://bugzilla.redhat.com/1143869 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0190_create_index_cpu_profiles.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I817d57833630ac386c9fbdf70139439dbfc1be07 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactoring vm-analyzer
by ahadas＠redhat.com 17 Jan '16

17 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refactoring vm-analyzer ...................................................................... core: refactoring vm-analyzer Simplify VmAnalyzer#inMigrationTo Change-Id: Ibbbc827f1c6c7bc54383f603021b127933201b3f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbbc827f1c6c7bc54383f603021b127933201b3f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: wrong usage of DomainAdminPassword instead of AdminPas...
by tnisan＠redhat.com 17 Jan '16

17 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: wrong usage of DomainAdminPassword instead of AdminPassword ...................................................................... core: wrong usage of DomainAdminPassword instead of AdminPassword These xml contains the wrong entries. Change-Id: I35d871c56b029a7d1b0cc0ddfe2fba91992177ee Bug-Url: https://bugzilla.redhat.com/1264733 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.2k8 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35d871c56b029a7d1b0cc0ddfe2fba91992177ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: wrong usage of DomainAdminPassword instead of AdminPas...
by shavivi＠redhat.com 17 Jan '16

17 Jan '16

Shahar Havivi has submitted this change and it was merged. Change subject: core: wrong usage of DomainAdminPassword instead of AdminPassword ...................................................................... core: wrong usage of DomainAdminPassword instead of AdminPassword These xml contains the wrong entries. Change-Id: I35d871c56b029a7d1b0cc0ddfe2fba91992177ee Bug-Url: https://bugzilla.redhat.com/1264733 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.2k8 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35d871c56b029a7d1b0cc0ddfe2fba91992177ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add "unless" as a reserved word that starts a block
by juan.hernandez＠redhat.com 15 Jan '16

15 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add "unless" as a reserved word that starts a block ...................................................................... Add "unless" as a reserved word that starts a block Currently the class used to generate Ruby source code doesn't take into account that "unless" can be used to begin a block. As a result when this construct is used the generated source code isn't formatted correctly. This patch fixes that issue. Change-Id: I9f6daa6ef9e3dcebf31131153cbcad5fc1780a5f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/RubyBuffer.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f6daa6ef9e3dcebf31131153cbcad5fc1780a5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add suport for "Add" and action methods
by juan.hernandez＠redhat.com 15 Jan '16

15 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add suport for "Add" and action methods ...................................................................... Add suport for "Add" and action methods This patch adds support for the "Add" and action methods, as both use the HTTP POST method. It also adds examples that show how to use these operations. Change-Id: I8abda64733bde19b6cef7907e32044fda4c61a5f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java A sdk/examples/add_cluster.rb A sdk/examples/add_data_center.rb A sdk/examples/add_host.rb A sdk/examples/add_nfs_data_storage_domain.rb A sdk/examples/add_nfs_iso_storage_domain.rb A sdk/examples/add_vm.rb A sdk/examples/add_vm_disk.rb A sdk/examples/add_vm_nic.rb A sdk/examples/attach_nfs_data_storage_domain.rb A sdk/examples/attach_nfs_iso_storage_domain.rb M sdk/examples/list_vms.rb M sdk/examples/remove_vm.rb M sdk/examples/search_vms.rb A sdk/examples/start_vm.rb A sdk/examples/stop_vm.rb M sdk/lib/ovirt/sdk/v4/connection.rb 17 files changed, 789 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8abda64733bde19b6cef7907e32044fda4c61a5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add initial tests for relevant services
by juan.hernandez＠redhat.com 15 Jan '16

15 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add initial tests for relevant services ...................................................................... Add initial tests for relevant services This patch adds some simple tests for the services that are more relevant, like the data centers service, the clusters service and the storage domains service. Change-Id: I867045e7df814e6108fc610d757cb67a3b46b88f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/spec/clusters_service_spec.rb A sdk/spec/data_centers_service_spec.rb A sdk/spec/storage_domains_service_spec.rb 3 files changed, 192 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I867045e7df814e6108fc610d757cb67a3b46b88f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0