- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.2]: core: Call concurrent execution callback on add vm command.
by tnisan＠redhat.com 10 Jan '16

10 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Call concurrent execution callback on add vm command. ...................................................................... core: Call concurrent execution callback on add vm command. Add a call for ConcurrentChildCommandsExecutionCallback to be called for addVmCommand and set the parameter isUseCinderCommandCallback with the appropriate value. Change-Id: I59f0875526fd28bad4ba37746658a591bb9bb123 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59f0875526fd28bad4ba37746658a591bb9bb123 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: Add callback for create VM from Template with Cinder.
by tnisan＠redhat.com 10 Jan '16

10 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add callback for create VM from Template with Cinder. ...................................................................... core: Add callback for create VM from Template with Cinder. Failure flow add callback for addVMFromTemplateCommand. Change-Id: I2d7f8e1f5974aa9a3777a9c02e518047b7e1bf5b Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d7f8e1f5974aa9a3777a9c02e518047b7e1bf5b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: CoCo revert tasks of clone Cinder disks.
by tnisan＠redhat.com 10 Jan '16

10 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CoCo revert tasks of clone Cinder disks. ...................................................................... core: CoCo revert tasks of clone Cinder disks. Failure flow, once a template is failed to be created the Template disks which were created should be removed. Change-Id: Ia6229fe8d9ac1b8d6499f306b3d034f6308a6bf5 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java 1 file changed, 45 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6229fe8d9ac1b8d6499f306b3d034f6308a6bf5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: Refactor call back of CloneSingleCinderDisk
by tnisan＠redhat.com 10 Jan '16

10 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Refactor call back of CloneSingleCinderDisk ...................................................................... core: Refactor call back of CloneSingleCinderDisk since CloneCinderDisksCallBack command aggragates all its child commands statuses there is no need to remove those commands from the hierarchy, only the parent command should remove those commands from the hierarchy. Change-Id: I5a65c594b0454f2ec7cfaff75c69d0208f5f1217 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommandCallback.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a65c594b0454f2ec7cfaff75c69d0208f5f1217 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: Aggregate all commands in call back on failure.
by tnisan＠redhat.com 10 Jan '16

10 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Aggregate all commands in call back on failure. ...................................................................... core: Aggregate all commands in call back on failure. Set the command as failed only when all the disks has finished to get created so the revert operation will not collapse with the creation operation of Cinder. Change-Id: I382f4b6ce4fe22c3dd565e2211d350f1a1649ba4 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java 1 file changed, 14 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51582 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I382f4b6ce4fe22c3dd565e2211d350f1a1649ba4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: Change error to warn on query execution
by tnisan＠redhat.com 10 Jan '16

10 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change error to warn on query execution ...................................................................... core: Change error to warn on query execution When we delete a snapshot the GUI might not get refreshed instantly and the GetVmConfigurationBySnapshotQuery might get executed and find out the snapshot no longer exists. This message should not be an error, since this is only a synchronization issue. Change-Id: I2ea8c965cfeeacfd4711c909529c975d6deecdb8 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ea8c965cfeeacfd4711c909529c975d6deecdb8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: CoCo - avoid using removeFromHirerchy on callback
by tnisan＠redhat.com 10 Jan '16

10 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CoCo - avoid using removeFromHirerchy on callback ...................................................................... core: CoCo - avoid using removeFromHirerchy on callback Do not remove the command from hirerchy when it is ended so the aggragator command can determine if the command succeeded or not. Change-Id: Id60b300cda80fe2555f58f300ab83fad727be736 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllCinderSnapshotDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreAllCinderSnapshotsCommand.java 6 files changed, 10 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51531 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id60b300cda80fe2555f58f300ab83fad727be736 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: restapi: missing RSDL fields re: import vms
by tnisan＠redhat.com 10 Jan '16

10 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: missing RSDL fields re: import vms ...................................................................... restapi: missing RSDL fields re: import vms Bug 998607 introduced a new API functionality for importing a VM from an export domain. However, this change was not documented in the RSDL metadata file. This patch adds the appropriate fields to the RSDL file. Change-Id: I38d4f75fe308d94817dcd9bb5bd33aaac0e6860a Bug-Url: https://bugzilla.redhat.com/1296047 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38d4f75fe308d94817dcd9bb5bd33aaac0e6860a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Import clone VM without copy-collapse
by tnisan＠redhat.com 10 Jan '16

10 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Import clone VM without copy-collapse ...................................................................... engine: Import clone VM without copy-collapse The user should be able to import and clone a VM without snapshots without setting copy-collapse to true via REST. Also, when importing a VM without snapshots that is based on a template the copy-collapse parameter should not be ignored. The flow in this case in CopyImageGroupCommand should be the same as when copy-collapse is set to true. Change-Id: I8b3f2096341bef7a795813c304aebff3a0ee279e Bug-Url: https://bugzilla.redhat.com/1147011 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Passed CI tests Freddy Rolland: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b3f2096341bef7a795813c304aebff3a0ee279e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: missing RSDL fields re: import vms
by tnisan＠redhat.com 10 Jan '16

10 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: missing RSDL fields re: import vms ...................................................................... restapi: missing RSDL fields re: import vms Bug 998607 introduced a new API functionality for importing a VM from an export domain. However, this change was not documented in the RSDL metadata file. This patch adds the appropriate fields to the RSDL file. Change-Id: I38d4f75fe308d94817dcd9bb5bd33aaac0e6860a Bug-Url: https://bugzilla.redhat.com/1296047 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/51578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38d4f75fe308d94817dcd9bb5bd33aaac0e6860a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0