- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.2]: core: Importing a SD should override empty fields
by piotr.kliczewski＠gmail.com 07 Jan '16

07 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Importing a SD should override empty fields ...................................................................... core: Importing a SD should override empty fields validate name length only if it is not empty. Empty name or empty description should not be used and should be set from the storageDomainInfo. Change-Id: I0c3a6f688d7f05a79182054a8e34abde14e70d2e Bug-Url: https://bugzilla.redhat.com/1295852 Bug-Url: https://bugzilla.redhat.com/1222571 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c3a6f688d7f05a79182054a8e34abde14e70d2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: CoCo - avoid using removeFromHirerchy on callback
by piotr.kliczewski＠gmail.com 07 Jan '16

07 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: CoCo - avoid using removeFromHirerchy on callback ...................................................................... core: CoCo - avoid using removeFromHirerchy on callback Do not remove the command from hirerchy when it is ended so the aggragator command can determine if the command succeeded or not. Change-Id: Id60b300cda80fe2555f58f300ab83fad727be736 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllCinderSnapshotDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreAllCinderSnapshotsCommand.java 6 files changed, 10 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id60b300cda80fe2555f58f300ab83fad727be736 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Clean up after livemedia-creator
by rbarry＠redhat.com 07 Jan '16

07 Jan '16

Ryan Barry has submitted this change and it was merged. Change subject: Clean up after livemedia-creator ...................................................................... Clean up after livemedia-creator livemedia-creator (inside mock, because this works fine outside) leaves orphaned loopback devices attached to devicemapper. Clean these up if we can find a loopback device from the workspace or /var/lib/mock/$conf/root/$workspace, or orphaned /build/diskFOOBAR.img. Check devicemapper and try to remove it first, then try to remove the loopback device Change-Id: I16bc4a6917b1b3968bb406e6be48c1fed0b0d7a8 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M jobs/confs/shell-scripts/mock_cleanup.sh 1 file changed, 26 insertions(+), 0 deletions(-) -- To view, visit https://gerrit.ovirt.org/51532 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16bc4a6917b1b3968bb406e6be48c1fed0b0d7a8 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: blank template always has latest template
by tjelinek＠redhat.com 07 Jan '16

07 Jan '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: blank template always has latest template ...................................................................... webadmin: blank template always has latest template The new way of calculating compatibility versions caused a regression for the blank template editing (the spice + vnc was not available). The reason is that the blank template has always "latest" compatibility version and has no cluster, so the cluster can not be used to calculate it. Change-Id: I2b72175a9a76b43265faaeecd7a5b46789c30320 Bug-Url: https://bugzilla.redhat.com/1279524 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/BlankTemplateModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b72175a9a76b43265faaeecd7a5b46789c30320 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: added CA to .vv file's ovirt section
by tjelinek＠redhat.com 07 Jan '16

07 Jan '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: added CA to .vv file's ovirt section ...................................................................... webadmin: added CA to .vv file's ovirt section Change-Id: I7aa47e8bac77f4d11f83b3460ad9da923d4a249f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1295455 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java 3 files changed, 10 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aa47e8bac77f4d11f83b3460ad9da923d4a249f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: build: post ovirt-engine-3.6.2.3
by piotr.kliczewski＠gmail.com 07 Jan '16

07 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: build: post ovirt-engine-3.6.2.3 ...................................................................... build: post ovirt-engine-3.6.2.3 Change-Id: I4dd8d0ae1a57d4a8a0c318f905e1070ec807843e Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 56 files changed, 60 insertions(+), 57 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dd8d0ae1a57d4a8a0c318f905e1070ec807843e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: show snapshot name properly after live merge of snapsh...
by tnisan＠redhat.com 07 Jan '16

07 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: show snapshot name properly after live merge of snapshot disk ...................................................................... core: show snapshot name properly after live merge of snapshot disk After Live Merge of a snapshot disk (Storage > Disk Snapshots > Remove), the audit log shows the snapshot name of '<UNKNOWN>'. The problem is that the image record is used to look up the name, and this is not available after the merge operation is done. Instead, cache the snapshot name in the parameters and refer to this after the merge operation is complete. Change-Id: I253806b89f31cb31e0a145dfe22a6f3ba30579f8 Bug-Url: https://bugzilla.redhat.com/1204609 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskSnapshotsParameters.java 2 files changed, 19 insertions(+), 6 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I253806b89f31cb31e0a145dfe22a6f3ba30579f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: show snapshot name properly after live merge of snapsh...
by tnisan＠redhat.com 07 Jan '16

07 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: show snapshot name properly after live merge of snapshot disk ...................................................................... core: show snapshot name properly after live merge of snapshot disk After Live Merge of a snapshot disk (Storage > Disk Snapshots > Remove), the audit log shows the snapshot name of '<UNKNOWN>'. The problem is that the image record is used to look up the name, and this is not available after the merge operation is done. Instead, cache the snapshot name in the parameters and refer to this after the merge operation is complete. Change-Id: I253806b89f31cb31e0a145dfe22a6f3ba30579f8 Bug-Url: https://bugzilla.redhat.com/1204609 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskSnapshotsParameters.java 2 files changed, 19 insertions(+), 6 deletions(-) Approvals: Greg Padgett: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I253806b89f31cb31e0a145dfe22a6f3ba30579f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Fix notification on failure
by sbonazzo＠redhat.com 07 Jan '16

07 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Fix notification on failure ...................................................................... packaging: engine-backup: Fix notification on failure engine-backup was displaying a misleading error msg after failing and trying to notify the engine. Added logic to not notify engine if log parameter is not passed. Change-Id: I50ad8f885e4d89af4896163a4c25300979f3c0db Bug-Url: https://bugzilla.redhat.com/1296520 Signed-off-by: Gonzalo Rafuls <grafuls(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Gonzalo Rafuls: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50ad8f885e4d89af4896163a4c25300979f3c0db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gonzalo Rafuls <grafuls(a)redhat.com> Gerrit-Reviewer: Gonzalo Rafuls <grafuls(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix of MigrateDowntimeSupported option
by tnisan＠redhat.com 07 Jan '16

07 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix of MigrateDowntimeSupported option ...................................................................... core: Fix of MigrateDowntimeSupported option There was a typo in database upgrade script for the database option MigrateDowntimeSupported in commit 1a2a5179. As a result, the option name is different in the source code and in the database, producing error message in the log after otherwise successful live migration with clusters < 3.6. This commit fixes the typo in the database. Change-Id: I6a1f88b85c561b6a6b2e5aa59d4e1aeea005ad6a Bug-Url: https://bugzilla.redhat.com/1272084 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_2000_fix_migratedowntime_option.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Arik Hadas: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/51491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a1f88b85c561b6a6b2e5aa59d4e1aeea005ad6a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0