- Engine-commits - oVirt List Archives

Change in jenkins[master]: Removed testing of ovirt-optimizer on el6
by eedri＠redhat.com 06 Jan '16

06 Jan '16

Eyal Edri has submitted this change and it was merged. Change subject: Removed testing of ovirt-optimizer on el6 ...................................................................... Removed testing of ovirt-optimizer on el6 Change-Id: I089a9e4e3c2767186d3fe7a84686b795b0ff46c2 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/projects/ovirt-optimizer/ovirt-optimizer_standard.yaml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I089a9e4e3c2767186d3fe7a84686b795b0ff46c2 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: node: Switch to F22 distro for now
by eedri＠redhat.com 06 Jan '16

06 Jan '16

Eyal Edri has submitted this change and it was merged. Change subject: node: Switch to F22 distro for now ...................................................................... node: Switch to F22 distro for now To workaround a livemedia-creator problem. Change-Id: Iba0cf3117b5594d5863b0f0835d1a4a743227507 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M jobs/confs/projects/ovirt-node-ng/ovirt-node-ng.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba0cf3117b5594d5863b0f0835d1a4a743227507 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Rename SystemKatello to EngineKatello
by juan.hernandez＠redhat.com 06 Jan '16

06 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename SystemKatello to EngineKatello ...................................................................... restapi: Rename SystemKatello to EngineKatello Change-Id: I4a3b1b6e9346cd3a55538b593f6e16de8c8a4eae Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendEngineKatelloErrataResource.java R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendEngineKatelloErratumResource.java R backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendEngineKatelloErrataResourceTest.java R backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendEngineKatelloErratumResourceTest.java M backend/manager/modules/restapi/model/src/main/java/services/SystemService.java R backend/manager/modules/restapi/model/src/main/java/services/externalhostproviders/EngineKatelloErrataService.java 8 files changed, 23 insertions(+), 22 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/51352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a3b1b6e9346cd3a55538b593f6e16de8c8a4eae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Importing a SD should override empty fields
by mlipchuk＠redhat.com 06 Jan '16

06 Jan '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Importing a SD should override empty fields ...................................................................... core: Importing a SD should override empty fields validate name length only if it is not empty. Empty name or empty description should not be used and should be set from the storageDomainInfo. Change-Id: I0c3a6f688d7f05a79182054a8e34abde14e70d2e Bug-Url: https://bugzilla.redhat.com/1295852 Bug-Url: https://bugzilla.redhat.com/1222571 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c3a6f688d7f05a79182054a8e34abde14e70d2e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Add storage attributes on import SD.
by mlipchuk＠redhat.com 06 Jan '16

06 Jan '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Add storage attributes on import SD. ...................................................................... webadmin: Add storage attributes on import SD. Add storage attributes on import SD Change-Id: Ia8fe824419ae9373619feca10076e04857b3da6a Bug-Url: https://bugzilla.redhat.com/1295852 Bug-Url: https://bugzilla.redhat.com/1222571 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8fe824419ae9373619feca10076e04857b3da6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add job description for vm-logon
by ahadas＠redhat.com 06 Jan '16

06 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: add job description for vm-logon ...................................................................... core: add job description for vm-logon Add missing description for the VmLogon command. It prevents an error in the log and to display proper description of the command in the tasks tab. Change-Id: Ib90dd09893d173275a12cc1a0518699ad2b08bdb Bug-Url: https://bugzilla.redhat.com/1295779 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib90dd09893d173275a12cc1a0518699ad2b08bdb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor cleanup in vm-logon
by ahadas＠redhat.com 06 Jan '16

06 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup in vm-logon ...................................................................... core: minor cleanup in vm-logon Remove redundant comments, variables and fix formatting. Change-Id: I71ddff74a3242cd72caeb32d58ac6207cbd7c51b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java 1 file changed, 8 insertions(+), 13 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71ddff74a3242cd72caeb32d58ac6207cbd7c51b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Filter out child Cinder commands on end action.
by tnisan＠redhat.com 06 Jan '16

06 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Filter out child Cinder commands on end action. ...................................................................... core: Filter out child Cinder commands on end action. EndAction was being called only for image commands. Cinder commands should get filtered out on endAction since the logic is already being done as part of the Cinder command endAction. In the future this filtering should be removed and the child endAction should be called abstractically for Cinder and Image volumes. Change-Id: Ia8e5119ec55f498b4a688334cd6302abe7287388 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 16 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8e5119ec55f498b4a688334cd6302abe7287388 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Lock VM should not be done on revert tasks
by tnisan＠redhat.com 06 Jan '16

06 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Lock VM should not be done on revert tasks ...................................................................... core: Lock VM should not be done on revert tasks Lock of VM should not be done when reverting tasks to avoid deadlock. Change-Id: I75e9dea5fa9edcab0961b5180190308ae475daf1 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java 3 files changed, 11 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75e9dea5fa9edcab0961b5180190308ae475daf1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: CoCo, prevent using removeFromHirerchy on callback.
by tnisan＠redhat.com 06 Jan '16

06 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CoCo, prevent using removeFromHirerchy on callback. ...................................................................... core: CoCo, prevent using removeFromHirerchy on callback. Do not remove the command from hirerchy when it is ended so the aggragator command can determine if the command succeeded or not. Change-Id: I36d8582d22c63760dd55cd8c5ac5855ccd32b577 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommandCallback.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d8582d22c63760dd55cd8c5ac5855ccd32b577 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0