- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: CoCo, prevent using removeFromHirerchy on callback.
by mlipchuk＠redhat.com 04 Jan '16

04 Jan '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: CoCo, prevent using removeFromHirerchy on callback. ...................................................................... core: CoCo, prevent using removeFromHirerchy on callback. Do not remove the command from hirerchy when it is ended so the aggragator command can determine if the command succeeded or not. Change-Id: I36d8582d22c63760dd55cd8c5ac5855ccd32b577 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommandCallback.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d8582d22c63760dd55cd8c5ac5855ccd32b577 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Call concurrent execution callback on add vm command.
by mlipchuk＠redhat.com 04 Jan '16

04 Jan '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Call concurrent execution callback on add vm command. ...................................................................... core: Call concurrent execution callback on add vm command. Add a call for ConcurrentChildCommandsExecutionCallback to be called for addVmCommand and set the parameter isUseCinderCommandCallback with the appropriate value. Change-Id: I59f0875526fd28bad4ba37746658a591bb9bb123 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59f0875526fd28bad4ba37746658a591bb9bb123 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: fix badly generated macs in db
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix badly generated macs in db ...................................................................... core: fix badly generated macs in db Note: this patch replaces former one (I4a1b37da30ce4ad6d25c1d510eb5c09e17525f1b) because different approach to fix this issue was requested. There was .py script¹ (now deleted) which was used to generate mac ranges in some circumstances. However there was a bug in it, so some users may end up with MAC address like 00:1a:4a:1:f:ff generated (fourth and fifth group can be formed just by one char). This MAC got without any validation into DB and engine did not detect this problem — since engine code just removes colons and parse value as hex. So in that case user ended up with different mac ranges than intended. In 3.6 code validations were added to UI, where such MAC will fail when user just opens DC edit dialog and confirm it without any change. Because code did not fail, user could continue using such setting, but actually different range was used. For example if generated range was 00:1a:4a:1:f:00-00:1a:4a:1:f:ff, engine actually used range was: 00:00:1a:4a:1f:00-00:00:1a:4a:1f:ff. This patch tries to fix db entries in same way. description of sql udpate: Patch is little bit convoluted because it tries not to use stored procedures. Flow is: • first colons are removed • missing zeroes are added to the left of string to reach total of 12 chars • after each two chars new colon is added; this creates string enging with colon • extra last character is removed. [1] ./packaging/setup/plugins/ovirt-engine-setup/config/macrange.py Change-Id: I962d96dbde5afaf19c94763ac51166c958a2f0bd Bug-Url: https://bugzilla.redhat.com/1286132 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1980_fix_invalid_macs.sql 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I962d96dbde5afaf19c94763ac51166c958a2f0bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix badly generated macs in db
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix badly generated macs in db ...................................................................... core: fix badly generated macs in db Note: this patch replaces former one (I4a1b37da30ce4ad6d25c1d510eb5c09e17525f1b) because different approach to fix this issue was requested. There was .py script¹ (now deleted) which was used to generate mac ranges in some circumstances. However there was a bug in it, so some users may end up with MAC address like 00:1a:4a:1:f:ff generated (fourth and fifth group can be formed just by one char). This MAC got without any validation into DB and engine did not detect this problem — since engine code just removes colons and parse value as hex. So in that case user ended up with different mac ranges than intended. In 3.6 code validations were added to UI, where such MAC will fail when user just opens DC edit dialog and confirm it without any change. Because code did not fail, user could continue using such setting, but actually different range was used. For example if generated range was 00:1a:4a:1:f:00-00:1a:4a:1:f:ff, engine actually used range was: 00:00:1a:4a:1f:00-00:00:1a:4a:1f:ff. This patch tries to fix db entries in same way. description of sql udpate: Patch is little bit convoluted because it tries not to use stored procedures. Flow is: • first colons are removed • missing zeroes are added to the left of string to reach total of 12 chars • after each two chars new colon is added; this creates string enging with colon • extra last character is removed. [1] ./packaging/setup/plugins/ovirt-engine-setup/config/macrange.py Change-Id: I962d96dbde5afaf19c94763ac51166c958a2f0bd Bug-Url: https://bugzilla.redhat.com/1286132 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1980_fix_invalid_macs.sql 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51290 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I962d96dbde5afaf19c94763ac51166c958a2f0bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix the command params for SRIOV related commands
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix the command params for SRIOV related commands ...................................................................... restapi: Fix the command params for SRIOV related commands * Send proper parameters from REST API code to AddVfsConfigLabel and AddVfsConfigLabel commands. * AddVfsConfigLabelCommand returns the label it has created, so it could be loaded by REST code back. Change-Id: Icad91b6b1d6e8ec3c7834776fd677fd4785c77a3 Bug-Url: https://bugzilla.redhat.com/1295198 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddVfsConfigLabelCommand.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedLabelsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedNetworkResource.java 3 files changed, 6 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/51296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icad91b6b1d6e8ec3c7834776fd677fd4785c77a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: hosted-engine: missing config from engine-config
by rgolan＠redhat.com 04 Jan '16

04 Jan '16

Roy Golan has submitted this change and it was merged. Change subject: core: hosted-engine: missing config from engine-config ...................................................................... core: hosted-engine: missing config from engine-config The HostedEngineStorageDomainName was missing from the DB and the engine-config properties. Change-Id: I99d39f73ebcf4eca3a3891c371c246660dda5611 Bug-Url: https://bugzilla.redhat.com/1290478 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d39f73ebcf4eca3a3891c371c246660dda5611 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine: Integrate NetworkAttachmentIpConfigurationValidator
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Integrate NetworkAttachmentIpConfigurationValidator ...................................................................... engine: Integrate NetworkAttachmentIpConfigurationValidator Add ip configuration validation to HostSetupNetworksValidator. After consulting where the vailidation should happened, it was decided that the validation will occur only in the backend. Please note, The web application has a default ip configuration set for boot protocol none and additional validaition to other boot protocols. Regarding the REST API cilent, the decision was different from the web application as no validaiton nor default ip configuration will be set. It reasonable to ask a script writer to be responisable enought to meet the demand for valid ip configuration. It was also decided not to enforce a valid ip configuration via api.xsd in order to keep it as general as possible. Also, please note that only new network attachment should pass the ip configuration validation as already exist attached network has different logic. For example, a network with dhcp already configured will have ip details. Change-Id: I19b5f0f15f3fc494301928cfcb957bd09863c6c2 Bug-Url: https://bugzilla.redhat.com/1270807 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java 5 files changed, 116 insertions(+), 109 deletions(-) Approvals: Tal Nisan: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19b5f0f15f3fc494301928cfcb957bd09863c6c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine: Introudce NetworkAttachmentIpConfigurationValidator
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Introudce NetworkAttachmentIpConfigurationValidator ...................................................................... engine: Introudce NetworkAttachmentIpConfigurationValidator The validator will validate the network attachment's ip configuration. A valid ip configuration must has a primary address with valid boot protocol and ip details. In case the boot protocol is static, ip details must contains ip addres and netmask. Please note that gateway is not mandatory as the kernal can complete it with a default one. For dhcp or none boot protocols, no ip details should be mentioned. In case of dhcp, the dhcp itself should determine it. Change-Id: I589013ef2b6783c77a424a8d21fad5da8a7f3250 Bug-Url: https://bugzilla.redhat.com/1270807 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/NetworkAttachmentIpConfigurationValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/NetworkAttachmentIpConfigurationValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 283 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I589013ef2b6783c77a424a8d21fad5da8a7f3250 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: webadmin: fix HostSetupNetworkModel ipConfiguration param
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix HostSetupNetworkModel ipConfiguration param ...................................................................... webadmin: fix HostSetupNetworkModel ipConfiguration param When network boot protocol is none or dhcp no ip details (address, netmask , gateway) should be mentioned. The patch will fill those if exist only in case network boot protocl is static. Change-Id: I555e9c5b52c1aa3f774572734ef09461fa16fa98 Bug-Url: https://bugzilla.redhat.com/1270807 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I555e9c5b52c1aa3f774572734ef09461fa16fa98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix badly generated macs in db
by alkaplan＠redhat.com 04 Jan '16

04 Jan '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: fix badly generated macs in db ...................................................................... core: fix badly generated macs in db Note: this patch replaces former one (I4a1b37da30ce4ad6d25c1d510eb5c09e17525f1b) because different approach to fix this issue was requested. There was .py script¹ (now deleted) which was used to generate mac ranges in some circumstances. However there was a bug in it, so some users may end up with MAC address like 00:1a:4a:1:f:ff generated (fourth and fifth group can be formed just by one char). This MAC got without any validation into DB and engine did not detect this problem — since engine code just removes colons and parse value as hex. So in that case user ended up with different mac ranges than intended. In 3.6 code validations were added to UI, where such MAC will fail when user just opens DC edit dialog and confirm it without any change. Because code did not fail, user could continue using such setting, but actually different range was used. For example if generated range was 00:1a:4a:1:f:00-00:1a:4a:1:f:ff, engine actually used range was: 00:00:1a:4a:1f:00-00:00:1a:4a:1f:ff. This patch tries to fix db entries in same way. description of sql udpate: Patch is little bit convoluted because it tries not to use stored procedures. Flow is: • first colons are removed • missing zeroes are added to the left of string to reach total of 12 chars • after each two chars new colon is added; this creates string enging with colon • extra last character is removed. [1] ./packaging/setup/plugins/ovirt-engine-setup/config/macrange.py Change-Id: I962d96dbde5afaf19c94763ac51166c958a2f0bd Bug-Url: https://bugzilla.redhat.com/1286132 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0120_fix_invalid_macs.sql 1 file changed, 23 insertions(+), 15 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I962d96dbde5afaf19c94763ac51166c958a2f0bd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0