- Engine-commits - oVirt List Archives

Change in jenkins[master]: Enable el7 jobs for imgbased
by tlitovsk＠redhat.com 04 Jan '16

04 Jan '16

Anatoly Litovsky has submitted this change and it was merged. Change subject: Enable el7 jobs for imgbased ...................................................................... Enable el7 jobs for imgbased Change-Id: Ideb0e90df1613a6686e36457bc96824fd02ce2a1 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M jobs/confs/projects/imgbased/imgbased.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me; Ready for review Jenkins CI: Passed CI tests Anatoly Litovsky: Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/51265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ideb0e90df1613a6686e36457bc96824fd02ce2a1 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Integrate NetworkAttachmentIpConfigurationValidator
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Integrate NetworkAttachmentIpConfigurationValidator ...................................................................... engine: Integrate NetworkAttachmentIpConfigurationValidator Add ip configuration validation to HostSetupNetworksValidator. After consulting where the vailidation should happened, it was decided that the validation will occur only in the backend. Please note, The web application has a default ip configuration set for boot protocol none and additional validaition to other boot protocols. Regarding the REST API cilent, the decision was different from the web application as no validaiton nor default ip configuration will be set. It reasonable to ask a script writer to be responisable enought to meet the demand for valid ip configuration. It was also decided not to enforce a valid ip configuration via api.xsd in order to keep it as general as possible. Also, please note that only new network attachment should pass the ip configuration validation as already exist attached network has different logic. For example, a network with dhcp already configured will have ip details. Change-Id: I19b5f0f15f3fc494301928cfcb957bd09863c6c2 Bug-Url: https://bugzilla.redhat.com/1270807 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java 5 files changed, 116 insertions(+), 109 deletions(-) Approvals: Tal Nisan: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19b5f0f15f3fc494301928cfcb957bd09863c6c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Introudce NetworkAttachmentIpConfigurationValidator
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Introudce NetworkAttachmentIpConfigurationValidator ...................................................................... engine: Introudce NetworkAttachmentIpConfigurationValidator The validator will validate the network attachment's ip configuration. A valid ip configuration must has a primary address with valid boot protocol and ip details. In case the boot protocol is static, ip details must contains ip addres and netmask. Please note that gateway is not mandatory as the kernal can complete it with a default one. For dhcp or none boot protocols, no ip details should be mentioned. In case of dhcp, the dhcp itself should determine it. Change-Id: I589013ef2b6783c77a424a8d21fad5da8a7f3250 Bug-Url: https://bugzilla.redhat.com/1270807 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/NetworkAttachmentIpConfigurationValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/NetworkAttachmentIpConfigurationValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 283 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I589013ef2b6783c77a424a8d21fad5da8a7f3250 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: fix HostSetupNetworkModel ipConfiguration param
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix HostSetupNetworkModel ipConfiguration param ...................................................................... webadmin: fix HostSetupNetworkModel ipConfiguration param When network boot protocol is none or dhcp no ip details (address, netmask , gateway) should be mentioned. The patch will fill those if exist only in case network boot protocl is static. Change-Id: I555e9c5b52c1aa3f774572734ef09461fa16fa98 Bug-Url: https://bugzilla.redhat.com/1270807 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I555e9c5b52c1aa3f774572734ef09461fa16fa98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine: VfScheduler should consider directly attached VFs as...
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: VfScheduler should consider directly attached VFs as non-free ...................................................................... engine: VfScheduler should consider directly attached VFs as non-free Bug-Url: https://bugzilla.redhat.com/1293937 Change-Id: Ieace2c74971b00db5a99eb98ae6e2ebec59b0924 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImplTest.java 2 files changed, 126 insertions(+), 29 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieace2c74971b00db5a99eb98ae6e2ebec59b0924 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused VmDeviceUtils methods
by amureini＠redhat.com 04 Jan '16

04 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused VmDeviceUtils methods ...................................................................... core: Remove unused VmDeviceUtils methods Change-Id: Ide88ee963e321d012afc530f3e1e38840124f3ce Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 0 insertions(+), 24 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50615 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide88ee963e321d012afc530f3e1e38840124f3ce Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: VfScheduler should consider directly attached VFs as...
by tnisan＠redhat.com 04 Jan '16

04 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: VfScheduler should consider directly attached VFs as non-free ...................................................................... engine: VfScheduler should consider directly attached VFs as non-free Bug-Url: https://bugzilla.redhat.com/1293937 Change-Id: Ieace2c74971b00db5a99eb98ae6e2ebec59b0924 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImplTest.java 2 files changed, 126 insertions(+), 29 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieace2c74971b00db5a99eb98ae6e2ebec59b0924 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in the addition of unmanaged vms
by ahadas＠redhat.com 04 Jan '16

04 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in the addition of unmanaged vms ...................................................................... core: cleanup in the addition of unmanaged vms Minor cleanup in the recently added command that adds unmanaged VMs. Change-Id: I279ca24350e15d1194ac561e298916f14ef3f3b7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java 1 file changed, 16 insertions(+), 18 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I279ca24350e15d1194ac561e298916f14ef3f3b7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract external vms handling from vms monitoring
by ahadas＠redhat.com 04 Jan '16

04 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract external vms handling from vms monitoring ...................................................................... core: extract external vms handling from vms monitoring The handling of external VMs became more complicated with the introduction of the hosted engine and PPC. This patch extracts that handling to separate command in order to simplify the VMs-monitoring. Change-Id: I6ff8a034a01223f4063524931881cb06682a8604 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddUnmanagedVmsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 8 files changed, 268 insertions(+), 108 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ff8a034a01223f4063524931881cb06682a8604 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[ovirt-3.5]: packaging: Add windows spec and jenkins automation
by vfeenstr＠redhat.com 04 Jan '16

04 Jan '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: packaging: Add windows spec and jenkins automation ...................................................................... packaging: Add windows spec and jenkins automation Copied from master with slight modifications. Change-Id: I19bcd8e7e8b09c1d3bea3ea80891b080bef2f252 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- A automation/README.md A automation/build-artifacts.packages A automation/build-artifacts.repos A automation/build-artifacts.sh A automation/check-patch.packages A automation/check-patch.sh A ovirt-guest-agent-windows.spec 7 files changed, 155 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Vinzenz Feenstra: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/47971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19bcd8e7e8b09c1d3bea3ea80891b080bef2f252 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0