- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.2]: core: CoCoAsyncTaskHelper - get parent command id from the p...
by tnisan＠redhat.com 31 Dec '15

31 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: CoCoAsyncTaskHelper - get parent command id from the parent parameters ...................................................................... core: CoCoAsyncTaskHelper - get parent command id from the parent parameters When choosing parent parameters for the tasks the parent command id should be derived from those parameters, otherwise we can get into situation where the parentCommandId will be Guid.Empty not matching the selected parent parameters. This situation leads to the tasks to be considered as of different commands which leads to the endAction() method to be called multiple times when the parent command creates tasks. An example would be the usage of the memory builders, when creating a vm snapshot with memory the endAction() will be executed multiple times, one time for the disks tasks and one time for the memory tasks. Change-Id: I0cacc023e855c8e9651e7134234759288b93e897 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293663 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/51183 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cacc023e855c8e9651e7134234759288b93e897 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add default graphics devices if absent in OVF
by ahadas＠redhat.com 31 Dec '15

31 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: engine: Add default graphics devices if absent in OVF ...................................................................... engine: Add default graphics devices if absent in OVF If OVF was created on pre-3.6 version of the Engine, graphics devices will be absent in it. After restoration under Engine 3.6, the VM without graphics devices will fail to open the console or even fail to run (on recent versions of VDSM). This patch creates graphics devices, if absent after reading an OVF. The device type (protocol) is guessed from default display type of the VM. Change-Id: I596cbb9af4573fd25d1072c911227fb3bd759e0b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293299 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 2 files changed, 97 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I596cbb9af4573fd25d1072c911227fb3bd759e0b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: CoCoAsyncTaskHelper - get parent command id from the p...
by tnisan＠redhat.com 31 Dec '15

31 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: CoCoAsyncTaskHelper - get parent command id from the parent parameters ...................................................................... core: CoCoAsyncTaskHelper - get parent command id from the parent parameters When choosing parent parameters for the tasks the parent command id should be derived from those parameters, otherwise we can get into situation where the parentCommandId will be Guid.Empty not matching the selected parent parameters. This situation leads to the tasks to be considered as of different commands which leads to the endAction() method to be called multiple times when the parent command creates tasks. An example would be the usage of the memory builders, when creating a vm snapshot with memory the endAction() will be executed multiple times, one time for the disks tasks and one time for the memory tasks. Change-Id: I0cacc023e855c8e9651e7134234759288b93e897 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293663 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/51181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cacc023e855c8e9651e7134234759288b93e897 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gluster: handle unsupported gluster volume types
by sabose＠redhat.com 31 Dec '15

31 Dec '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: handle unsupported gluster volume types ...................................................................... gluster: handle unsupported gluster volume types NPE is seen when a new volume type is introduced in Gluster and that type of volume is created in Gluster CLI. Introducing a new volume types 'UNKNOWN' and 'TIER'. Actions like 'ADD' 'REMOVE' bricks and rebalance will not be supported in these types of volumes. Also tasks with type 'UNKNOWN' will not be sycned. Change-Id: Iffc6a93987eeafbba4666e2a864038ca1f2258cd Bug-Url: https://bugzilla.redhat.com/1294473 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterTasksListReturnForXmlRpc.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 10 files changed, 71 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Passed CI tests Kanagaraj M: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/51156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffc6a93987eeafbba4666e2a864038ca1f2258cd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: webadmin: Hide 'Upgrade' action during host upgrade
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Hide 'Upgrade' action during host upgrade ...................................................................... webadmin: Hide 'Upgrade' action during host upgrade Change-Id: I3f0af8659928f7721da2d4f201586d3e3b5bdb74 Bug-Url: https://bugzilla.redhat.com/1283662 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f0af8659928f7721da2d4f201586d3e3b5bdb74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: Randomly schedule check updates for host job
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Randomly schedule check updates for host job ...................................................................... core: Randomly schedule check updates for host job The patch replaces the fixated method of scheduling the 'check for host updates' jobs with a randomly method in order to prevent from scheduling all of the jobs at the exact time which has a great impact on the engine on system with many hosts. Change-Id: Ibd2e530fc18d84f29770046d13aa5c3708ce4da1 Bug-Url: https://bugzilla.redhat.com/1294772 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd2e530fc18d84f29770046d13aa5c3708ce4da1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Hide 'Upgrade' action during host upgrade
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Hide 'Upgrade' action during host upgrade ...................................................................... webadmin: Hide 'Upgrade' action during host upgrade Change-Id: I3f0af8659928f7721da2d4f201586d3e3b5bdb74 Bug-Url: https://bugzilla.redhat.com/1283662 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f0af8659928f7721da2d4f201586d3e3b5bdb74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Randomly schedule check updates for host job
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Randomly schedule check updates for host job ...................................................................... core: Randomly schedule check updates for host job The patch replaces the fixated method of scheduling the 'check for host updates' jobs with a randomly method in order to prevent from scheduling all of the jobs at the exact time which has a great impact on the engine on system with many hosts. Change-Id: Ibd2e530fc18d84f29770046d13aa5c3708ce4da1 Bug-Url: https://bugzilla.redhat.com/1294772 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd2e530fc18d84f29770046d13aa5c3708ce4da1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: store memory snapshots as disks
by ahadas＠redhat.com 30 Dec '15

30 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: core: store memory snapshots as disks ...................................................................... core: store memory snapshots as disks This patch change the representation of memory volumes to disks "behind the scenes", meaning that they are still not exposed to in the UI and their representation as comma-separated string is not yet removed. Change-Id: If973ebdfc73c8185c16701e79b94662269a776d0 Bug-Url: https://bugzilla.redhat.com/1150239 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/NullableMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/StatelessSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoImpl.java M packaging/dbscripts/snapshots_sp.sql 16 files changed, 223 insertions(+), 241 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46531 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If973ebdfc73c8185c16701e79b94662269a776d0 Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CoCoAsyncTaskHelper - get parent command id from the p...
by laravot＠redhat.com 30 Dec '15

30 Dec '15

Liron Aravot has submitted this change and it was merged. Change subject: core: CoCoAsyncTaskHelper - get parent command id from the parent parameters ...................................................................... core: CoCoAsyncTaskHelper - get parent command id from the parent parameters When choosing parent parameters for the tasks the parent command id should be derived from those parameters, otherwise we can get into situation where the parentCommandId will be Guid.Empty not matching the selected parent parameters. This situation leads to the tasks to be considered as of different commands which leads to the endAction() method to be called multiple times when the parent command creates tasks. An example would be the usage of the memory builders, when creating a vm snapshot with memory the endAction() will be executed multiple times, one time for the disks tasks and one time for the memory tasks. Change-Id: I0cacc023e855c8e9651e7134234759288b93e897 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293663 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cacc023e855c8e9651e7134234759288b93e897 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0