- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.2]: webadmin: Fix Optimize-For-Virt-Store in volume creation
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix Optimize-For-Virt-Store in volume creation ...................................................................... webadmin: Fix Optimize-For-Virt-Store in volume creation Optimize-For-Virt-Store in gluster volume create is failing because of volume ID being null in the parameter. Setting the volume ID from return value of CreateVolume action. Change-Id: I5a20ef51e3cc792daa2b013d0dcae8e4873c198d Bug-Url: https://bugzilla.redhat.com/1286887 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/51100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a20ef51e3cc792daa2b013d0dcae8e4873c198d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: gluster: Stop gluster processes when host moves to maintenance
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: gluster: Stop gluster processes when host moves to maintenance ...................................................................... gluster: Stop gluster processes when host moves to maintenance Stop glusterd and other gluster processes when a host is moved to maintenance mode, so that data is un-available. Start the glusterd service when host is activated again. starting glusterd service will ensure that all the other gluster services are started. Change-Id: Ib4e00fb30b9d0cc84dcaffe9c89864429470f0aa Bug-Url: https://bugzilla.redhat.com/1205724 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterProcessesVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 8 files changed, 77 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/51099 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4e00fb30b9d0cc84dcaffe9c89864429470f0aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: gluster: disbale rebalance for non distribute volumes
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: gluster: disbale rebalance for non distribute volumes ...................................................................... gluster: disbale rebalance for non distribute volumes Disable gluster volume rebalance option for non distribute volume in UI. Change-Id: I9455294afe5f42c21922356b788079e9325c6714 Bug-Url: https://bugzilla.redhat.com/1290678 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/51098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9455294afe5f42c21922356b788079e9325c6714 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: gluster: fix error code mappings for brick provisioning
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: gluster: fix error code mappings for brick provisioning ...................................................................... gluster: fix error code mappings for brick provisioning Fix the error code mappings for brick provisioning. Error mapping in oVirt engine for brick provisioning is corrupted. There are few error codes which are not mapped and there are few error codes which doesn't exists. Correcting all error codes as part of this patch. Change-Id: I14c8e83d4b76f5d67b6288a73e88d130a7f998d8 Bug-Url: https://bugzilla.redhat.com/1209475 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 4 files changed, 29 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/51097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14c8e83d4b76f5d67b6288a73e88d130a7f998d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: gluster: sync storage devices as part of installing host
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: gluster: sync storage devices as part of installing host ...................................................................... gluster: sync storage devices as part of installing host Sync all the storage devices in the gluster host while installing/adding the host to engine. Change-Id: I236b4fb1cb325f83e428db0bbd372e32e485e0d0 Bug-Url: https://bugzilla.redhat.com/1218057 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/SyncGlusterStorageDevicesParameter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java 4 files changed, 55 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/51096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I236b4fb1cb325f83e428db0bbd372e32e485e0d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine: Mac address check should be done only when plugging
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Mac address check should be done only when plugging ...................................................................... engine: Mac address check should be done only when plugging This condition was removed by mistake in patch- Ic7b32ad027016c0d95dd05ab0abbd176951c4be9 Bug-Url: https://bugzilla.redhat.com/1293863 Change-Id: I051567518fd0aa31f98647d0589832e6573fadf6 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I051567518fd0aa31f98647d0589832e6573fadf6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core:clear format of allowable characters in error
by tnisan＠redhat.com 30 Dec '15

30 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core:clear format of allowable characters in error ...................................................................... core:clear format of allowable characters in error Clear format of allowable characters in error messages "a-z0-9A-Z" or "-_" => 'a-z', 'A-Z', '0-9', '_', '.' or '-' Change-Id: I7c9ecc50329052e3a996f4817d92fedc6eb6a837 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1235118 Signed-off-by: emesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c9ecc50329052e3a996f4817d92fedc6eb6a837 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: VfScheduler should consider directly attached VFs as...
by alkaplan＠redhat.com 30 Dec '15

30 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: VfScheduler should consider directly attached VFs as non-free ...................................................................... engine: VfScheduler should consider directly attached VFs as non-free Bug-Url: https://bugzilla.redhat.com/1293937 Change-Id: Ieace2c74971b00db5a99eb98ae6e2ebec59b0924 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfScheduler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImplTest.java 4 files changed, 134 insertions(+), 33 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieace2c74971b00db5a99eb98ae6e2ebec59b0924 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix import vm from vmware as clone
by ahadas＠redhat.com 30 Dec '15

30 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: core: fix import vm from vmware as clone ...................................................................... core: fix import vm from vmware as clone This patch fixes the functionality of import-as-clone from VMware. The problem was that on import-as-clone we generate new ID, but in the ImportFromExternalProviderCommand we never used the generated ID. The solution is composed of 2 parts: 1. To move the getters for VM-ID that reside in ImportVmCommand and knows to return the right ID, also for the import-as-clone case, to ImportVmCommandBase so they will be shared with the command ImportFromExternalProviderCommand as well. 2. We need the parameters to store the ID of the VM in two fields: getVm().getId() and getVmId(). Instead of setting it manually, we now call the constructor of ImportVmParameters that does the trick. Change-Id: I32dfe891c6168d3c1d522e2588ae9e02d82b9de3 https://bugzilla.redhat.com/1294501 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromExternalProviderParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromOvaParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromOvaModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromVmwareModel.java 7 files changed, 47 insertions(+), 27 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32dfe891c6168d3c1d522e2588ae9e02d82b9de3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: change vm name on import from vmware
by ahadas＠redhat.com 29 Dec '15

29 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: core: change vm name on import from vmware ...................................................................... core: change vm name on import from vmware The import dialog allows the user to specify a new name for a VM that is imported from VMware. However, it would never work since we send this name to v2v as the identifier of the VM to import - so most probably it won't work since there will be no VM in VMware with that name. In the worse case, we might import the wrong VM.. Change-Id: Iea7f45a5d016352e44807dc85042eb717a170309 Bug-Url: https://bugzilla.redhat.com/1294651 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromExternalProviderParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromOvaModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromVmwareModel.java 4 files changed, 17 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea7f45a5d016352e44807dc85042eb717a170309 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0