- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Restore snapshot should handle Cinder snapshot.
by mlipchuk＠redhat.com 07 Dec '15

07 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Restore snapshot should handle Cinder snapshot. ...................................................................... core: Restore snapshot should handle Cinder snapshot. When a Cinder snapshot gets commited, the redundant volumes and snapshots should be deleted. Since the Cinder volume chain is different than the image volume chain, it is neccessery to filter out the relevant snapshots to delete separately than how it is being done today with images. Change-Id: Ibe1808974c467ab910d03e450d83490f0ee0fc56 Bug-Url: https://bugzilla.redhat.com/1256048 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java 1 file changed, 32 insertions(+), 14 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe1808974c467ab910d03e450d83490f0ee0fc56 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Refactor, Use RemoveCinderVolumeParentCommand method.
by mlipchuk＠redhat.com 07 Dec '15

07 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Refactor, Use RemoveCinderVolumeParentCommand method. ...................................................................... core: Refactor, Use RemoveCinderVolumeParentCommand method. Make RemoveCinderDiskCommand to use methods from the parent command. The difference in the parent command is that we also pass the storage id of the volume. Change-Id: I49ebcbfff3b584e39d20dec0b686e2879e30d650 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommandCallback.java 2 files changed, 7 insertions(+), 129 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49ebcbfff3b584e39d20dec0b686e2879e30d650 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Get initial Cinder volume to restore from.
by mlipchuk＠redhat.com 07 Dec '15

07 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Get initial Cinder volume to restore from. ...................................................................... core: Get initial Cinder volume to restore from. Add a method which returns the initial Cinder volume the engine should delete. The restore process of the Cinder volume should use this volume to get all its descendants and remove them all. The initial volume is chosen by taking the previewed snapshot, fetch the parent volume, and retun the other volume. Change-Id: Iffaa62f703734f50208418786dc813bfe82106b9 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49413 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffaa62f703734f50208418786dc813bfe82106b9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Handle Cinder imaged once snapshot gets commited/undo.
by mlipchuk＠redhat.com 07 Dec '15

07 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Handle Cinder imaged once snapshot gets commited/undo. ...................................................................... core: Handle Cinder imaged once snapshot gets commited/undo. Set the Cinder images to restore once a snapshot gets commited. Change-Id: I64170f1d82c0bd1ba973078eb11f5752ebd31036 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java 1 file changed, 26 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64170f1d82c0bd1ba973078eb11f5752ebd31036 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add a new Cinder volume parent command.
by mlipchuk＠redhat.com 07 Dec '15

07 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add a new Cinder volume parent command. ...................................................................... core: Add a new Cinder volume parent command. Add a new parent command to be used for remove of Cinder disk/volume. This command should share the same logic of remove Cinder disk and remove of Cinder volumes once a snapshot gets commited and its redundant volumes should be deleted. Change-Id: I376de555234c3050fba480573ff984effd4b3c06 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderVolumeParentCommand.java 1 file changed, 131 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I376de555234c3050fba480573ff984effd4b3c06 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant Cinder volumes for commited snapshot.
by mlipchuk＠redhat.com 07 Dec '15

07 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant Cinder volumes for commited snapshot. ...................................................................... core: Remove redundant Cinder volumes for commited snapshot. Once we commit a snapshot, there could be orphaned Cinder disks from the previous active snapshot that should get deleted. The engine should remove those leftovers in the end command phase. Change-Id: I1c071abc747367b21a97488c8298ebaa883ecc87 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreAllCinderSnapshotsCommand.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/49421 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c071abc747367b21a97488c8298ebaa883ecc87 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup RestoreFromSnapshotParameters from Cinder.
by mlipchuk＠redhat.com 07 Dec '15

07 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: cleanup RestoreFromSnapshotParameters from Cinder. ...................................................................... core: cleanup RestoreFromSnapshotParameters from Cinder. remove redundant Cinder references from RestoreFromSnapshotParameters class Change-Id: I1f8baa432299bed62923d642d6375821d106a71a Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreFromSnapshotParameters.java 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/49422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f8baa432299bed62923d642d6375821d106a71a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Re-factor restore snapshot for Cinder disks.
by mlipchuk＠redhat.com 07 Dec '15

07 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Re-factor restore snapshot for Cinder disks. ...................................................................... core: Re-factor restore snapshot for Cinder disks. Make RestoreAllCinderSnapshotsCommand to remove also redundant disks/volumes. Change the command accordingly to accept different types of lists, so the process of restore will be alligned with the process we do for images. Change-Id: Ic41c6ec6473e3454430b474c152eb3a75bd843c1 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreAllCinderSnapshotsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreAllCinderSnapshotsParameters.java 3 files changed, 124 insertions(+), 45 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/49420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic41c6ec6473e3454430b474c152eb3a75bd843c1 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RestoreCinderSnapshot should delete volumes by order.
by mlipchuk＠redhat.com 07 Dec '15

07 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: RestoreCinderSnapshot should delete volumes by order. ...................................................................... core: RestoreCinderSnapshot should delete volumes by order. Re-implement restore Cinder snapshot to delete a Cinder volume and all its descendants from the DB by calling RemoveCinderDiskVolume for each volume by order. The order is important for since Cinder can only remove volume after all its snapshots get deleted first. Change-Id: Ife6ac08ca86a4cb2b30174e3de6422d9db5cbb65 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreFromCinderSnapshotCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreFromCinderSnapshotCommandCallback.java 2 files changed, 41 insertions(+), 214 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/49419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife6ac08ca86a4cb2b30174e3de6422d9db5cbb65 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: before unlock a VM, fetch it from the DB
by mlipchuk＠redhat.com 07 Dec '15

07 Dec '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: before unlock a VM, fetch it from the DB ...................................................................... core: before unlock a VM, fetch it from the DB The VM which is used to be unlocked is the VM from the meory, so the VM might be with DOWN status although it was locked on the proccess. Since CoCo handle the class in the memory (unlike the Async Task functionality), after commiting/undo a previewed Cinder snapshot, the VM from the memory is being unlocked but since the status of the memory of the VM is DOWN, the engine doesn't unlock it. The proposed fix is to make the VM property to be null in order to refresh the VM status from db. Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Change-Id: I7edd4e8b23277c57939bd5e965eb4da29e3600d3 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/49418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7edd4e8b23277c57939bd5e965eb4da29e3600d3 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0