- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: ISCSIStorageHelper TODO
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ISCSIStorageHelper TODO ...................................................................... core: ISCSIStorageHelper TODO Replace the TODO's javadoc comment style (/** */) with a regular line comment (//), as having javadoc headers inside a method's body may break some javadoc doclets. Change-Id: I53521971ed3b66282c34cd2776c4cc2378ff0835 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53521971ed3b66282c34cd2776c4cc2378ff0835 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveDiskSnapshotsCommand streaming API
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshotsCommand streaming API ...................................................................... core: RemoveDiskSnapshotsCommand streaming API Replaced the cumbersome LinqUtils call with a more modern and elegant usage of Java 8's streaming API. Change-Id: I91d59653592cc7a7e718126506fca454b7fd51ef Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91d59653592cc7a7e718126506fca454b7fd51ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ISCSIStorageHelper condition
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ISCSIStorageHelper condition ...................................................................... core: ISCSIStorageHelper condition Removed a redundant null check that just adds unneeded complexity to the code. Change-Id: If2236575188cf7ea82332d56b002ca8428d4be73 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2236575188cf7ea82332d56b002ca8428d4be73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageServerConnectionLunMapDaoImpl#getAll(String)
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageServerConnectionLunMapDaoImpl#getAll(String) ...................................................................... core: StorageServerConnectionLunMapDaoImpl#getAll(String) The getAll(String lunId) method was implemented naively be retrieving all the rows from the table and then filtering them in memory. This patch replaces this implementation by a proper stored procedure implementation which is both easier to read, and potentially performs better on large tables by leaving the filtering logic to the database instead of transferring the entire table to the engine's memory and having to filter there. Change-Id: Ied9fbe3e427f37be604ae7d2fec58962f38cba22 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoImpl.java M packaging/dbscripts/storages_san_sp.sql 2 files changed, 19 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied9fbe3e427f37be604ae7d2fec58962f38cba22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageServerConnectionLunMapDaoImpl#getAll()
by amureini＠redhat.com 25 Nov '15

25 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageServerConnectionLunMapDaoImpl#getAll() ...................................................................... core: StorageServerConnectionLunMapDaoImpl#getAll() Before this patch, getAll() was not implemented (it just threw a NotImplementedException), while the private getAllLUNStorageServerConnection method returned all the rows in the table. This patch standardized the StorageServerConnectionLunMapDaoImpl by removing this private method and moving its implementation to the standard getAll() method instead. Change-Id: I94feec8f713b43982931794e468e1365260c65b2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoTest.java 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94feec8f713b43982931794e468e1365260c65b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Make nested class of SSORestApiNegotiationFilter st...
by masayag＠redhat.com 25 Nov '15

25 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: engine : Make nested class of SSORestApiNegotiationFilter static ...................................................................... engine : Make nested class of SSORestApiNegotiationFilter static The nested class AuthResult of class SSORestApiNegotiationFilter can be made static. To avoid find bugs error. Change-Id: I4206240b1ba7a1a6a2295b3e24438c240a3e3db0 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SSORestApiNegotiationFilter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4206240b1ba7a1a6a2295b3e24438c240a3e3db0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin: Unpin numa nodes when preferred host changes
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Unpin numa nodes when preferred host changes ...................................................................... webadmin: Unpin numa nodes when preferred host changes * Pin VM numa nodes to new preferred host when possible. * Unpin all VM numa nodes when new preferred host does not have the corrseponding host numa node. * Only show VM numa nodes of VMs which are pinned to the selected host in the numa node configuration panel. Bug-Url: https://bugzilla.redhat.com/1177259 Change-Id: Iabb16f1b3dbcb7f821046dddaa3b719314598d06 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VmNumaSupportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 39 insertions(+), 30 deletions(-) Approvals: Roman Mohr: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabb16f1b3dbcb7f821046dddaa3b719314598d06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: core: Return empty list if no VM numa nodes are present
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Return empty list if no VM numa nodes are present ...................................................................... core: Return empty list if no VM numa nodes are present Let AddVmNumaNodesCommand and VM always return an empty list instead of null if no numa configuration is present to avoid confusing null checks. Bug-Url: https://bugzilla.redhat.com/1279178 Bug-Url: https://bugzilla.redhat.com/1177259 Change-Id: I095e245227aed5e5c8f6d342d2a8af17b936eb00 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmNumaNodeOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 3 files changed, 12 insertions(+), 8 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I095e245227aed5e5c8f6d342d2a8af17b936eb00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin: GUI refactor NumaNode guid to NumaNode id
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: GUI refactor NumaNode guid to NumaNode id ...................................................................... webadmin: GUI refactor NumaNode guid to NumaNode id Fix GUI, display pinned NUMA nodes by their index (not Guid) --------------------------------------------------------------- In NumaSupportModel class. Refactor p2vNumaNodesMap map. To store pNodes and their pinned vNodes. Change the key from Guid to Integer. Refactor all members using this map. In order to prevent guid consistency maintenance whenever a host is re-added/removed. Change-Id: Ia1261c81ddbc2e18fd273c25945e9cc24032bdd2 Bug-Url: https://bugzilla.redhat.com/1177259 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/NumaSupportPopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java 2 files changed, 11 insertions(+), 11 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1261c81ddbc2e18fd273c25945e9cc24032bdd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Refactor NUMA node validation
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Refactor NUMA node validation ...................................................................... core: Refactor NUMA node validation Run same NUMA validation on VM create/update and on every NUMA related command to avoid (almost) silent disappearance of NUMA configuration when validation of sub-commands fails. Change-Id: I3eef4f2255f68b95d1272858edae370d33f137f4 Bug-Url: https://bugzilla.redhat.com/1265815 Bug-Url: https://bugzilla.redhat.com/1126180 Bug-Url: https://bugzilla.redhat.com/1279178 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/NumaValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/NumaValidatorTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/NumaTestUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmNumaNodeOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 23 files changed, 1,301 insertions(+), 312 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49163 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eef4f2255f68b95d1272858edae370d33f137f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0