- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: Return empty list if no VM numa nodes are present
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Return empty list if no VM numa nodes are present ...................................................................... core: Return empty list if no VM numa nodes are present Let AddVmNumaNodesCommand and VM always return an empty list instead of null if no numa configuration is present to avoid confusing null checks. Bug-Url: https://bugzilla.redhat.com/1279178 Bug-Url: https://bugzilla.redhat.com/1177259 Change-Id: I095e245227aed5e5c8f6d342d2a8af17b936eb00 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmNumaNodeOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 3 files changed, 12 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Passed CI tests Roman Mohr: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I095e245227aed5e5c8f6d342d2a8af17b936eb00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: vnconsole: fix pep8 issues
by sbonazzo＠redhat.com 25 Nov '15

25 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: vnconsole: fix pep8 issues ...................................................................... packaging: vnconsole: fix pep8 issues Fix pep8 issues detected by pep8 1.6.2 Change-Id: Ic3c4e1028b3b87a3e29b21927fcd05c62df36c72 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3c4e1028b3b87a3e29b21927fcd05c62df36c72 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: GUI refactor NumaNode guid to NumaNode id
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: GUI refactor NumaNode guid to NumaNode id ...................................................................... webadmin: GUI refactor NumaNode guid to NumaNode id Fix GUI, display pinned NUMA nodes by their index (not Guid) --------------------------------------------------------------- In NumaSupportModel class. Refactor p2vNumaNodesMap map. To store pNodes and their pinned vNodes. Change the key from Guid to Integer. Refactor all members using this map. In order to prevent guid consistency maintenance whenever a host is re-added/removed. Change-Id: Ia1261c81ddbc2e18fd273c25945e9cc24032bdd2 Bug-Url: https://bugzilla.redhat.com/1177259 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/NumaSupportPopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java 2 files changed, 11 insertions(+), 11 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1261c81ddbc2e18fd273c25945e9cc24032bdd2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: disable hotplug for PPC
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: disable hotplug for PPC ...................................................................... core: disable hotplug for PPC disable hotplug memory for PPC Change-Id: I86270cfcb28eebd37afecb4bc53fd0e0a18d77db Bug-Url: https://bugzilla.redhat.com/1284775 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86270cfcb28eebd37afecb4bc53fd0e0a18d77db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Use pagination when querying errata
by tnisan＠redhat.com 25 Nov '15

25 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Use pagination when querying errata ...................................................................... engine: Use pagination when querying errata Satellite 6.1 limits page size for 20 errata per page. This limit is too small to retrieve therefore specifying a larger amount of errata to get. Katello 2.1 doesn't support pagination, therefore using pagination in request is ignored. Change-Id: Icde94303cb7177ce2f09a784a5f8c105e1bd0885 Bug-Url: https://bugzilla.redhat.com/1284060 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icde94303cb7177ce2f09a784a5f8c105e1bd0885 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fixed error message on check-prod
by dcaro＠redhat.com 25 Nov '15

25 Nov '15

David Caro has submitted this change and it was merged. Change subject: Fixed error message on check-prod ...................................................................... Fixed error message on check-prod Change-Id: Id45ea95a3760c62772de38bf29478112abf8582d Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/custom_hooks/patchset-created.bz.2.correct_product 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id45ea95a3760c62772de38bf29478112abf8582d Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6.1_rc1
by sbonazzo＠redhat.com 25 Nov '15

25 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6.1_rc1 ...................................................................... build: ovirt-live-3.6.1_rc1 Change-Id: I4a7a83d002730d52a377009ad0b7b06fdc40de2b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a7a83d002730d52a377009ad0b7b06fdc40de2b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: disable hotplug for PPC
by mperina＠redhat.com 25 Nov '15

25 Nov '15

Martin Peřina has submitted this change and it was merged. Change subject: core: disable hotplug for PPC ...................................................................... core: disable hotplug for PPC disable hotplug memory for PPC Change-Id: I86270cfcb28eebd37afecb4bc53fd0e0a18d77db Bug-Url: https://bugzilla.redhat.com/1284775 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86270cfcb28eebd37afecb4bc53fd0e0a18d77db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Refactor NUMA node validation
by rgolan＠redhat.com 25 Nov '15

25 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: core: Refactor NUMA node validation ...................................................................... core: Refactor NUMA node validation Run same NUMA validation on VM create/update and on every NUMA related command to avoid (almost) silent disappearance of NUMA configuration when validation of sub-commands fails. Change-Id: I3eef4f2255f68b95d1272858edae370d33f137f4 Bug-Url: https://bugzilla.redhat.com/1265815 Bug-Url: https://bugzilla.redhat.com/1126180 Bug-Url: https://bugzilla.redhat.com/1177259 Bug-Url: https://bugzilla.redhat.com/1279178 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/NumaValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/NumaValidatorTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/NumaTestUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmNumaNodeOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 22 files changed, 1,289 insertions(+), 311 deletions(-) Approvals: Roman Mohr: Verified Roy Golan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eef4f2255f68b95d1272858edae370d33f137f4 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix for netmask prefix out of sync
by alkaplan＠redhat.com 25 Nov '15

25 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: fix for netmask prefix out of sync ...................................................................... engine: fix for netmask prefix out of sync Prefix and netmask represnting the same value will be reported as sync. Eg. netmask "255.255.255.255" represent the same prefix value as "32" Change-Id: Ieeda31a42341023a967dd0fb93052c7ea311bb98 Bug-Url: https://bugzilla.redhat.com/1269481 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfigurations.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java 2 files changed, 17 insertions(+), 6 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeda31a42341023a967dd0fb93052c7ea311bb98 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0