- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Remove not necessary imports
by juan.hernandez＠redhat.com 19 Nov '15

19 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove not necessary imports ...................................................................... restapi: Remove not necessary imports This patch removes an import that isn't necessary in the "StructType" class. Change-Id: Ie7e966a4de3669dfdf939f1646bff7c3a18e3519 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/StructType.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48737 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7e966a4de3669dfdf939f1646bff7c3a18e3519 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add "StructMember" and "MemberMethod" classes
by juan.hernandez＠redhat.com 19 Nov '15

19 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add "StructMember" and "MemberMethod" classes ...................................................................... restapi: Add "StructMember" and "MemberMethod" classes Currently the struct type attributes and links have many, in fact almost all in common, except their name. In order to reduce the code duplication that this generates this patch introduces a new "StructMember" base class to contain all the common fields and methods. The same happens with service methods and locators. This patch introduces a new "ServiceMember" class to simplify that. Change-Id: I56de044533340dc4751f5fb7f234e41c8071ad99 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Attribute.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Link.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Locator.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Method.java A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/ServiceMember.java A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/StructMember.java 6 files changed, 177 insertions(+), 207 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56de044533340dc4751f5fb7f234e41c8071ad99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: sdk: Rename "RSDL" to "Rsdl"
by juan.hernandez＠redhat.com 19 Nov '15

19 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Rename "RSDL" to "Rsdl" ...................................................................... sdk: Rename "RSDL" to "Rsdl" This change has been performed in the XML schema used by the engine, so we need to do it in the SDK generator as well. Change-Id: I8764b0b15e7906dfbbf7b6cac989d8d531a85d80 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/RsdlData.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8764b0b15e7906dfbbf7b6cac989d8d531a85d80 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: fc21: drop support
by sbonazzo＠redhat.com 19 Nov '15

19 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: fc21: drop support ...................................................................... fc21: drop support Drop support for FC21 now that FC23 is available Change-Id: I4b4596dbd6c29e6eeef846d84a469f5ce4aa0d4a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/fabic-ovirt/fabric-ovirt_standard.yaml M jobs/confs/projects/ioprocess/ioprocess_create-rpms.yaml M jobs/confs/projects/lago/lago_standard.yaml M jobs/confs/projects/mom/mom_create-rpms.yaml M jobs/confs/projects/otopi/otopi_create-rpms.yaml M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.5.yaml M jobs/confs/projects/repoman/repoman_build-artifacts.yaml M jobs/confs/projects/vdsm/vdsm_create-rpms.yaml M jobs/confs/projects/vdsm/vdsm_install-rpm-sanity.yaml M jobs/confs/yaml/builders/copy-create-job-artifact.yaml D mock_configs/fedora-21-x86_64.cfg D mock_configs/fedora-21-x86_64_proxied.cfg M mock_configs/mock_runner.sh 14 files changed, 2 insertions(+), 191 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Jenkins CI: Passed CI tests David Caro: Looks good to me; Ready for review -- To view, visit https://gerrit.ovirt.org/48784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b4596dbd6c29e6eeef846d84a469f5ce4aa0d4a Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[master]: cli: Add "optionhelper.py"
by juan.hernandez＠redhat.com 19 Nov '15

19 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Add "optionhelper.py" ...................................................................... cli: Add "optionhelper.py" Change-Id: Idc6ffb5a97fa3705a95da254d4c9852faefbadf7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile A src/ovirtcli/utils/optionhelper.py 2 files changed, 56 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc6ffb5a97fa3705a95da254d4c9852faefbadf7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[master]: cli: Process correct "--parent..." options
by juan.hernandez＠redhat.com 19 Nov '15

19 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Process correct "--parent..." options ...................................................................... cli: Process correct "--parent..." options Currently when the CLI tries to find a parent collection it assumes that the option used is "--type-identifier", but it can also be "--parent-type-identifier" and "--parent-type-name". As a result when the "--parent..." options are used autocompletion doesn't show the correct options. To avoid this issue this patch changes the CLI so that it uses the methods that check this in a more generic way. Change-Id: I42fb362c59d4baad5968c1ac0df15bbe0b7dab8a Bug-Url: https://bugzilla.redhat.com/1282832 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M src/ovirtcli/command/command.py M src/ovirtcli/shell/cmdshell.py 3 files changed, 23 insertions(+), 51 deletions(-) Approvals: Ori Liel: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42fb362c59d4baad5968c1ac0df15bbe0b7dab8a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Host Network QoS should not allow zero values
by alkaplan＠redhat.com 18 Nov '15

18 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Host Network QoS should not allow zero values ...................................................................... webadmin: Host Network QoS should not allow zero values Change-Id: If5220baf3de09c3aa106258ed0faaf98071bd517 Bug-Url: https://bugzilla.redhat.com/1244493 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/HostNetworkQosParametersModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5220baf3de09c3aa106258ed0faaf98071bd517 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Host Network QoS should not allow zero values
by alkaplan＠redhat.com 18 Nov '15

18 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Host Network QoS should not allow zero values ...................................................................... engine: Host Network QoS should not allow zero values Change-Id: I06a253a0e6b737ed02002db25b9b7994d5eda4fe Bug-Url: https://bugzilla.redhat.com/1244493 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNetworkQos.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06a253a0e6b737ed02002db25b9b7994d5eda4fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Set management network in upgrade
by emesika＠redhat.com 18 Nov '15

18 Nov '15

Eli Mesika has submitted this change and it was merged. Change subject: engine: Set management network in upgrade ...................................................................... engine: Set management network in upgrade Set management network in upgrade (take 2). The patch re-dones upgrade script 03_06_0840 as the related configuration key was renamed in the pre-upgrade phase. Change-Id: I8c68c2bfe758beacb41a74912dacc2080cb621a6 Bug-Url: https://bugzilla.redhat.com/1279955 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0010_set_mgmt_network_in_network_cluster.sql 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/48376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c68c2bfe758beacb41a74912dacc2080cb621a6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: org.ovirt.engine.core.bll.common.predicates
by masayag＠redhat.com 18 Nov '15

18 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: org.ovirt.engine.core.bll.common.predicates ...................................................................... core: org.ovirt.engine.core.bll.common.predicates Replace this package's implementation of org.ovirt.engine.core.utils.linq.Predicate to the standard java.util.function.Predicate that has the same functionality. Change-Id: I49cbd5ad19197aeef8e235e691acaf7ca778d8ed Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/ActiveVmAttachedToClusterPredicate.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/RunningVmPredicate.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/VmNetworkCanBeUpdatedPredicate.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/helper/DisplayNetworkClusterHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/predicates/RunningVmPredicateTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/predicates/VmNetworkCanBeUpdatedPredicateTest.java 8 files changed, 15 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49cbd5ad19197aeef8e235e691acaf7ca778d8ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0