- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: org.ovirt.engine.core.vdsbroker.vdsbroker.predicate
by masayag＠redhat.com 22 Nov '15

22 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: org.ovirt.engine.core.vdsbroker.vdsbroker.predicate ...................................................................... core: org.ovirt.engine.core.vdsbroker.vdsbroker.predicate Replace this package's implementation of org.ovirt.engine.core.utils.linq.Predicate to the standard java.util.function.Predicate that has the same functionality. Change-Id: I30e841db23478a9116485ad74822bc3831d3713e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/predicates/DisplayInterfaceEqualityPredicate.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/predicates/IsNetworkOnInterfacePredicate.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/predicates/DisplayInterfaceEqualityPredicateTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/predicates/IsNetworkOnInterfacePredicateTest.java 5 files changed, 16 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30e841db23478a9116485ad74822bc3831d3713e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Optimize equals/hashCode in ux classes
by mperina＠redhat.com 21 Nov '15

21 Nov '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Optimize equals/hashCode in ux classes ...................................................................... core: Optimize equals/hashCode in ux classes 1. Optimizes equals method to contain recommended functionality as described in Effective Java 2nd edition 2. Optimizes objects comparison in equals method to use Objects.equals() 3. Optimizes hashCode method to use Objects.hash()/hashCode() methods Change-Id: I4dedbb85e1ac8f171b180ececbd25adc572fb66b Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperation.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/plugin/PluginData.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/ElementIdStatement.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplySearchStringEvent.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridTimerStateChangeEvent.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/MainModelSelectionChangeEvent.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ValidationResult.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/TestingBackendModel.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/TestingFrontendModel.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModelTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Event.java 12 files changed, 105 insertions(+), 175 deletions(-) Approvals: Martin Peřina: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dedbb85e1ac8f171b180ececbd25adc572fb66b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: cluster fencing policy percentage
by awels＠redhat.com 20 Nov '15

20 Nov '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: cluster fencing policy percentage ...................................................................... webadmin: cluster fencing policy percentage - Properly render percentage using locale specific renderer instead of just appending % Change-Id: I5a7285fc778de06d95cf1cc8e6e2bdf530cd193d Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a7285fc778de06d95cf1cc8e6e2bdf530cd193d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Host->General software sub tab
by awels＠redhat.com 20 Nov '15

20 Nov '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Host->General software sub tab ...................................................................... webadmin: Host->General software sub tab - Fixed issue with layout of host general software sub sub tab. This now takes the entire available width of the panel instead of 1/4 of the available size. Change-Id: I897512662c4df3e2b2cefcd914219794f9d0f3ac Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281297 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I897512662c4df3e2b2cefcd914219794f9d0f3ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: errata table sorting
by awels＠redhat.com 20 Nov '15

20 Nov '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: errata table sorting ...................................................................... webadmin: errata table sorting - Added sorting capabilities to the errata tables Change-Id: Ia477ffa8a25df507963c2187ebfa580d0ee7be21 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1283117 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ErrataTableView.java 1 file changed, 33 insertions(+), 12 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia477ffa8a25df507963c2187ebfa580d0ee7be21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix of missing CONNECT_TO_SERIAL_CONSOLE localization
by piotr.kliczewski＠gmail.com 20 Nov '15

20 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Fix of missing CONNECT_TO_SERIAL_CONSOLE localization ...................................................................... webadmin: Fix of missing CONNECT_TO_SERIAL_CONSOLE localization ActionGroup___CONNECT_TO_SERIAL_CONSOLE() was missing in LocalizedEnum. Change-Id: Iab20b9f8aa933528e0381b495c1adf973959a7eb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281328 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Tomas Jelinek: Looks good to me, approved Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/48752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab20b9f8aa933528e0381b495c1adf973959a7eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: sercon: pass console specParams on device copy
by piotr.kliczewski＠gmail.com 19 Nov '15

19 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: sercon: pass console specParams on device copy ...................................................................... sercon: pass console specParams on device copy When we copy the devices of a VM, we forget to carry around the console device specParams. This aptch fixes that. Change-Id: I5941c45c2bed850da4c543c5ab385c33fd5e6f44 Bug-Url: https://bugzilla.redhat.com/1280370 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Francesco Romani: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5941c45c2bed850da4c543c5ab385c33fd5e6f44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine : Remove SessionDataContainer injection LoginOnBehalf...
by piotr.kliczewski＠gmail.com 19 Nov '15

19 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Remove SessionDataContainer injection LoginOnBehalfCommand ...................................................................... engine : Remove SessionDataContainer injection LoginOnBehalfCommand For 3.6 SessionDataContainer should still be used by calling getInstance. This is not relevant for master where SessionDataContainer has been made a bean. Change-Id: Ibae09c58f790042657a50b2aa5b4c3e85539053b Bug-Url: https://bugzilla.redhat.com/1264385 Bug-Url: https://bugzilla.redhat.com/1264391 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibae09c58f790042657a50b2aa5b4c3e85539053b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: backend: Copy host device spec params on template creation
by piotr.kliczewski＠gmail.com 19 Nov '15

19 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: backend: Copy host device spec params on template creation ...................................................................... backend: Copy host device spec params on template creation Without preserving the contents of host devices's spec params the devices of template (and VMs created from this template) will become unusable - invisible and unmodifiable to the UI. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281433 Change-Id: If35c5a78a7ac1ee1ca7e70658d8ffb7708eeb6b6 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If35c5a78a7ac1ee1ca7e70658d8ffb7708eeb6b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: relying on shared code from ovirt_setup_lib
by sbonazzo＠redhat.com 19 Nov '15

19 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: relying on shared code from ovirt_setup_lib ...................................................................... packaging: setup: relying on shared code from ovirt_setup_lib Relying on shared code from ovirt_setup_lib Change-Id: I884089c5674ab8042cc02fe46ab5a3ca3a599b97 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-engine.spec.in D packaging/setup/ovirt_engine_setup/dialog.py M packaging/setup/ovirt_engine_setup/engine_common/database.py D packaging/setup/ovirt_engine_setup/hostname.py M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_iptables.py M packaging/setup/plugins/ovirt-engine-common/base/network/hostname.py M packaging/setup/plugins/ovirt-engine-common/dockerc/core.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/engine.py M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py M packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py M packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/clear.py M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/pki.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/uninstall.py M packaging/setup/plugins/ovirt-engine-setup/base/dialog/preview.py M packaging/setup/plugins/ovirt-engine-setup/base/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/ssl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/root.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaa.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py 36 files changed, 89 insertions(+), 631 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I884089c5674ab8042cc02fe46ab5a3ca3a599b97 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0