- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddVmCommandTest generics
by amureini＠redhat.com 11 Nov '15

11 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommandTest generics ...................................................................... core: AddVmCommandTest generics Used Java 7's style diamond generics to improve readability. Change-Id: I206fe283d0cefc19dc0aabfef0c1a6d114490e18 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I206fe283d0cefc19dc0aabfef0c1a6d114490e18 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: AddVmCommandTest inline returns
by amureini＠redhat.com 11 Nov '15

11 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommandTest inline returns ...................................................................... core: AddVmCommandTest inline returns Change-Id: I7206b627328b22cd5b6f8524d77d724dc349e154 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7206b627328b22cd5b6f8524d77d724dc349e154 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: AddVmCommandTest remove redundant brackets
by amureini＠redhat.com 11 Nov '15

11 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommandTest remove redundant brackets ...................................................................... core: AddVmCommandTest remove redundant brackets Change-Id: I2f1ecadc1288e238239c19281a5d6872eb9612b6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f1ecadc1288e238239c19281a5d6872eb9612b6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: AddVmCommandTest#initializeMock params
by amureini＠redhat.com 11 Nov '15

11 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommandTest#initializeMock params ...................................................................... core: AddVmCommandTest#initializeMock params Removed the unused sizeRequired parameter. Change-Id: Iee90feed81f568c233c7e0747bb100dfe523fbd1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java 2 files changed, 19 insertions(+), 27 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee90feed81f568c233c7e0747bb100dfe523fbd1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: AddVmCommandTest#mockDisplayTypes params
by amureini＠redhat.com 11 Nov '15

11 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommandTest#mockDisplayTypes params ...................................................................... core: AddVmCommandTest#mockDisplayTypes params Removed the unused clusterVersion parameter. Change-Id: Ia386ccf988cd538de3a8e64f5fe854693f452286 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia386ccf988cd538de3a8e64f5fe854693f452286 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: AddVmCommandTest Matchers' use
by amureini＠redhat.com 11 Nov '15

11 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommandTest Matchers' use ...................................................................... core: AddVmCommandTest Matchers' use Standardize the use of Matchers so all the calls use the (already) statically imported anyXYZ() methods to make the code consistent. Change-Id: Ifaa3a46b3acd2e0d00d43eeb47268d8d27915c93 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaa3a46b3acd2e0d00d43eeb47268d8d27915c93 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: refactor import vm
by ahadas＠redhat.com 11 Nov '15

11 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: core: refactor import vm ...................................................................... core: refactor import vm Simplify the code that extracts memory volume from active snapshot of a VM that is being imported from an export domain. Change-Id: I3d27f4eeba25e36f225ca9c74d7767231bf0cc7c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 9 insertions(+), 17 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/48430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d27f4eeba25e36f225ca9c74d7767231bf0cc7c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Fix NPE when processing NUMA info that lacks distances
by tnisan＠redhat.com 11 Nov '15

11 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: Fix NPE when processing NUMA info that lacks distances ...................................................................... Fix NPE when processing NUMA info that lacks distances This code fakes distances between NUMA nodes to allow adding a host with broken NUMA support and still properly show the nodes in the UI. Change-Id: I0545a65c0b32a12ca7dd617a9e35199b31ad0093 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252055 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0545a65c0b32a12ca7dd617a9e35199b31ad0093 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: when starting Live Merge, check for NOT_STARTED child ...
by tnisan＠redhat.com 11 Nov '15

11 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: when starting Live Merge, check for NOT_STARTED child commands ...................................................................... core: when starting Live Merge, check for NOT_STARTED child commands When a Live Merge is started, the RemoveSnapshotCommandCallback does not look for child commands with the NOT_STARTED command status. This causes a race where the child commands may not be detected properly by the parent, causing the actual merge process to be skipped. This adds the needed check to the command callback, eliminating the race condition and ensuring the merge will occur. Change-Id: If47d26d8bedaf0bb4a39cae472533399178b4fdd Bug-Url: https://bugzilla.redhat.com/1280160 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Greg Padgett: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If47d26d8bedaf0bb4a39cae472533399178b4fdd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: Make VDSBrokerFrontend a CDI bean
by shavivi＠redhat.com 11 Nov '15

11 Nov '15

Shahar Havivi has submitted this change and it was merged. Change subject: backend: Make VDSBrokerFrontend a CDI bean ...................................................................... backend: Make VDSBrokerFrontend a CDI bean Change-Id: Ia76d93f24259ad93915d82dc04c7b9c667ed4255 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia76d93f24259ad93915d82dc04c7b9c667ed4255 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0