- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: engine: NPE in GLUSTERFSStorageHelper
by tnisan＠redhat.com 11 Nov '15

11 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: NPE in GLUSTERFSStorageHelper ...................................................................... engine: NPE in GLUSTERFSStorageHelper Fixing the ConnectHostToStoragePoolServersParameters constructor, to include 'StoragePool'. In the flow of refreshing storage connections and pool metada due to Vdsm reports, the ConnectHostToStoragePoolServersParameters constructor was used without 'StoragePool'. Several classes like CINDERStorageHelper and GLUSTERFSStorageHelper are expecting the parameter to have a StoragePool populated. Change-Id: I3b80bcc9606677912e88dc265d36c8c9f8ba8138 Bug-Url: https://bugzilla.redhat.com/1277570 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ConnectHostToStoragePoolServersParameters.java 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/48378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b80bcc9606677912e88dc265d36c8c9f8ba8138 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: vdsbroker: Remove workaround for JBoss 7 bug in ResourceManager
by mperina＠redhat.com 11 Nov '15

11 Nov '15

Martin Peřina has submitted this change and it was merged. Change subject: vdsbroker: Remove workaround for JBoss 7 bug in ResourceManager ...................................................................... vdsbroker: Remove workaround for JBoss 7 bug in ResourceManager Change-Id: I5c9b3e3d305eb28ecb12756a47c1827043ed174c Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 5 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c9b3e3d305eb28ecb12756a47c1827043ed174c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Added sleep after postgresql service start in engine upgrade...
by eedri＠redhat.com 11 Nov '15

11 Nov '15

Eyal Edri has submitted this change and it was merged. Change subject: Added sleep after postgresql service start in engine upgrade jobs ...................................................................... Added sleep after postgresql service start in engine upgrade jobs Change-Id: Ib259b59db478fb49d0fea77309149108b724d22b Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/ovirt-engine_upgrade_to_3.5/upgrade.sh M jobs/ovirt-engine_upgrade_to_3.6/upgrade.sh M jobs/ovirt-engine_upgrade_to_master/upgrade.sh 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Sharon Naftaly: Verified; Ready for review Eyal Edri: Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/48355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib259b59db478fb49d0fea77309149108b724d22b Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Set the jdk used by master upgrade jobs to java-1.8.0-openjdk
by eedri＠redhat.com 11 Nov '15

11 Nov '15

Eyal Edri has submitted this change and it was merged. Change subject: Set the jdk used by master upgrade jobs to java-1.8.0-openjdk ...................................................................... Set the jdk used by master upgrade jobs to java-1.8.0-openjdk Change-Id: If84d01265c04fb354772c5501e856c4bbe4561a3 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml M jobs/confs/yaml/templates/engine-upgrade.yaml 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Sharon Naftaly: Verified; Ready for review Juan Hernandez: Looks good to me Eyal Edri: Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If84d01265c04fb354772c5501e856c4bbe4561a3 Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

1 0

Change in jenkins[master]: ovirt-engine-extension-aaa-ldap: exclude fedora on 3.5
by sbonazzo＠redhat.com 11 Nov '15

11 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-extension-aaa-ldap: exclude fedora on 3.5 ...................................................................... ovirt-engine-extension-aaa-ldap: exclude fedora on 3.5 Change-Id: Ica0cb6945e102632483f13a98fd035af22c73a27 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml 1 file changed, 21 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica0cb6945e102632483f13a98fd035af22c73a27 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: when starting Live Merge, check for NOT_STARTED child ...
by amureini＠redhat.com 11 Nov '15

11 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: when starting Live Merge, check for NOT_STARTED child commands ...................................................................... core: when starting Live Merge, check for NOT_STARTED child commands When a Live Merge is started, the RemoveSnapshotCommandCallback does not look for child commands with the NOT_STARTED command status. This causes a race where the child commands may not be detected properly by the parent, causing the actual merge process to be skipped. This adds the needed check to the command callback, eliminating the race condition and ensuring the merge will occur. Change-Id: If47d26d8bedaf0bb4a39cae472533399178b4fdd Bug-Url: https://bugzilla.redhat.com/1280160 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If47d26d8bedaf0bb4a39cae472533399178b4fdd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: GUI refactor NumaNode guid to NumaNode id
by rgolan＠redhat.com 10 Nov '15

10 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: webadmin: GUI refactor NumaNode guid to NumaNode id ...................................................................... webadmin: GUI refactor NumaNode guid to NumaNode id Fix GUI, display pinned NUMA nodes by their index (not Guid) --------------------------------------------------------------- In NumaSupportModel class. Refactor p2vNumaNodesMap map. To store pNodes and their pinned vNodes. Change the key from Guid to Integer. Refactor all members using this map. In order to prevent guid consistency maintenance whenever a host is re-added/removed. Change-Id: Ia1261c81ddbc2e18fd273c25945e9cc24032bdd2 Bug-Url: https://bugzilla.redhat.com/1177259 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/NumaSupportPopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java 2 files changed, 11 insertions(+), 11 deletions(-) Approvals: Dudi Maroshi: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1261c81ddbc2e18fd273c25945e9cc24032bdd2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: packaging: ensuring it saves broker.conf during upgrades
by msivak＠redhat.com 10 Nov '15

10 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: packaging: ensuring it saves broker.conf during upgrades ...................................................................... packaging: ensuring it saves broker.conf during upgrades /var/lib/ovirt-hosted-engine-ha/broker.conf got populated by rpm install with its default and /etc/ovirt-hosted-engine-ha/broker.conf got written over that only if empty. Only after that the upgrade procedure will copy to the shared storage. Change-Id: I79e556d741a03c464ebd9c8a97b3c71c657e0234 Bug-Url: https://bugzilla.redhat.com/1279548 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79e556d741a03c464ebd9c8a97b3c71c657e0234 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: packaging: ensuring it saves broker.conf during upgrades
by msivak＠redhat.com 10 Nov '15

10 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: packaging: ensuring it saves broker.conf during upgrades ...................................................................... packaging: ensuring it saves broker.conf during upgrades /var/lib/ovirt-hosted-engine-ha/broker.conf got populated by rpm install with its default and /etc/ovirt-hosted-engine-ha/broker.conf got written over that only if empty. Only after that the upgrade procedure will copy to the shared storage. Change-Id: I79e556d741a03c464ebd9c8a97b3c71c657e0234 Bug-Url: https://bugzilla.redhat.com/1279548 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79e556d741a03c464ebd9c8a97b3c71c657e0234 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: configure: Increase release
by dougsland＠redhat.com 10 Nov '15

10 Nov '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: configure: Increase release ...................................................................... configure: Increase release Change-Id: Id4df471720d688778f929bd30f665742c46b0c21 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/48383 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4df471720d688778f929bd30f665742c46b0c21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0