- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: Restart hosted engine services after crash
by msivak＠redhat.com 12 Oct '15

12 Oct '15

Martin Sivák has submitted this change and it was merged. Change subject: Restart hosted engine services after crash ...................................................................... Restart hosted engine services after crash Change-Id: I174bd1ab900095185694bdd280991ff30354baca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1030441 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M initscripts/ovirt-ha-agent.service M initscripts/ovirt-ha-broker.service 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Artyom Lukianov: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I174bd1ab900095185694bdd280991ff30354baca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fixed Quota description size limits
by tnisan＠redhat.com 12 Oct '15

12 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fixed Quota description size limits ...................................................................... core: Fixed Quota description size limits When trying to copy a quota an error messsage was thrown saying that the size limit should be between 1 and 250. This error message was the result of not giving the right limits for the description of the quota. An empty description is 0 character long. Therefore, the limit was changed and now it is [0-250]. Change-Id: I6acad4fe290552dcdbd73bcd77e12c65f924d3c2 Bug-Url: https://bugzilla.redhat.com/1245664 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> (cherry picked from commit 1619a3525505e47c8f8ad46a8e1d0c9fc4d0be66) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/45240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6acad4fe290552dcdbd73bcd77e12c65f924d3c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Username of logged-in user appears in error dialog i...
by tnisan＠redhat.com 12 Oct '15

12 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Username of logged-in user appears in error dialog instead of pool name ...................................................................... engine: Username of logged-in user appears in error dialog instead of pool name When there are errors on starting VM from pool the error title is the logged in user and not the pool name. Bug-Url: https://bugzilla.redhat.com/1090934 Change-Id: Icc32fe50e1fe82b84a198fe1494430e102f425c2 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolSimpleUserCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc32fe50e1fe82b84a198fe1494430e102f425c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: db: executed config cleanup as upgrade script
by oourfali＠redhat.com 12 Oct '15

12 Oct '15

Oved Ourfali has submitted this change and it was merged. Change subject: db: executed config cleanup as upgrade script ...................................................................... db: executed config cleanup as upgrade script Up to now when a config entry was deprecated, we had to remove it in the pre-upgrade step calling fn_db_delete_config_value from 0000_config.sql. This may be problematic if a reference to the deleted entry exists in one of the upgrade scripts, in such case the entry will be removed in the pre-upgrade step and then the upgrade script referring this key will fail and cause all the upgrade process to fail. This patch moves all deprecated config entries to an upgrade script resolving this issue and adds additional benefit of executing all this mass removals only once instead doing that again and again on each upgrade. >From now on, please delete deprecated config entries in a regular upgrade script. Change-Id: I062b6c9df0f812e3e36cdfed36854dddb045c62d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1269796 Signed-off-by: emesika <emesika(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1870_delete_deprecated_config_values.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 177 insertions(+), 160 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47117 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I062b6c9df0f812e3e36cdfed36854dddb045c62d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Username of logged-in user appears in error dialog i...
by shavivi＠redhat.com 12 Oct '15

12 Oct '15

Shahar Havivi has submitted this change and it was merged. Change subject: engine: Username of logged-in user appears in error dialog instead of pool name ...................................................................... engine: Username of logged-in user appears in error dialog instead of pool name When there are errors on starting VM from pool the error title is the logged in user and not the pool name. Bug-Url: https://bugzilla.redhat.com/1090934 Change-Id: Icc32fe50e1fe82b84a198fe1494430e102f425c2 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolSimpleUserCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc32fe50e1fe82b84a198fe1494430e102f425c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Change error code according to vdsm
by amureini＠redhat.com 12 Oct '15

12 Oct '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Change error code according to vdsm ...................................................................... core: Change error code according to vdsm vdsm throws UnsupportedGlusterVolumeReplicaCountError with error code 480, engine error changed accordingly. Change-Id: I4e16526b1af49bdbd5bdb361b243cb8fae34d8d9 Bug-Url: https://bugzilla.redhat.com/1270732 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/47215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e16526b1af49bdbd5bdb361b243cb8fae34d8d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: support dnf version locking
by sbonazzo＠redhat.com 12 Oct '15

12 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: support dnf version locking ...................................................................... packaging: setup: support dnf version locking OTOPI 1.4.0 support DNF package manager. Upgrade support with DNF package manager requires changes in versionlock plugin configuration since DNF and YUM are not sharing the same configuration. This patch add a new dependency on Fedora adding the DNF versionlock plugin and configure it as it does for YUM. Add also the versionlock plugin configuration to the backupped data. Change-Id: I16a53c0f39eb8e5a7698ac4fcbba971081da6d24 Bug-Url: https://bugzilla.redhat.com/1270139 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M packaging/bin/engine-backup.sh M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 4 files changed, 85 insertions(+), 60 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16a53c0f39eb8e5a7698ac4fcbba971081da6d24 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: add missing indexes:
by emesika＠redhat.com 12 Oct '15

12 Oct '15

Eli Mesika has submitted this change and it was merged. Change subject: db: add missing indexes: ...................................................................... db: add missing indexes: This patch includes missing indexes suggested by pgcluu (http://pgcluu.darold.net/) PostgreSQL automatically creates indexes on primary keys and unique constraints, but not on the referencing side of foreign key relationships. Since a DELETE of a row from the referenced table or an UPDATE of a referenced column will require a scan of the referencing table for rows matching the old value, it is often a good idea to index the referencing columns. Change-Id: I09b43335e7cde29235839df00f590fef346d3547 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1270584 Signed-off-by: emesika <emesika(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1900_add_index_to_fk_columns.sql 1 file changed, 91 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09b43335e7cde29235839df00f590fef346d3547 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: core: Exclude import VM from CopyImageGroup CDA
by tnisan＠redhat.com 11 Oct '15

11 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Exclude import VM from CopyImageGroup CDA ...................................................................... core: Exclude import VM from CopyImageGroup CDA Change-Id: I08fdc64a64ec328d4b62f6990cd766257c781b2e Bug-Url: https://bugzilla.redhat.com/1269948 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08fdc64a64ec328d4b62f6990cd766257c781b2e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine : vmconsole permissions violates engine permission sc...
by masayag＠redhat.com 11 Oct '15

11 Oct '15

Moti Asayag has submitted this change and it was merged. Change subject: engine : vmconsole permissions violates engine permission scheme ...................................................................... engine : vmconsole permissions violates engine permission scheme VM consoles should get list of VMs using user group permissions. CONNECT_TO_SERIAL_CONSOLE action group has been added to SUPER_USER, VM_OPERATOR and INSTANCE_OPERATOR. Any user with the above role either by direct permissions or inherited throught the ad group should be able to list the VMs for which they have inherited permissions on. Change-Id: I87bef899b1c87066630de857e17e973342f20f2c Bug-Url: https://bugzilla.redhat.com/1264385 Bug-Url: https://bugzilla.redhat.com/1264391 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsForAnotherUserQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsForUserAndActionGroupQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LoginOnBehalfParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetEntitiesWithPermittedActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/VMConsoleProxyServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_06_1890_add_connect_to_serial_console_action_group.sql M packaging/dbscripts/vms_sp.sql 30 files changed, 423 insertions(+), 57 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87bef899b1c87066630de857e17e973342f20f2c Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0