- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: Validate inexistance of connection extension upon update
by tnisan＠redhat.com 11 Oct '15

11 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Validate inexistance of connection extension upon update ...................................................................... core: Validate inexistance of connection extension upon update When updating a storage server connection extension, make sure that another connection for the same host and target combination does not exist Change-Id: I90c5f56356e8b1ad75861760b6375cd23869db35 Bug-Url: https://bugzilla.redhat.com/1265133 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionExtensionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionExtensionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionExtensionCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionExtensionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageServerConnectionExtensionValidator.java 5 files changed, 28 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90c5f56356e8b1ad75861760b6375cd23869db35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Remove disks and storage domain option from add VM ...
by tnisan＠redhat.com 11 Oct '15

11 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Remove disks and storage domain option from add VM from config ...................................................................... restapi: Remove disks and storage domain option from add VM from config Change-Id: I0fdc659be984dd74ad19f904b884d6ebdc9cdb34 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1082977 --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fdc659be984dd74ad19f904b884d6ebdc9cdb34 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Exclude import VM from CopyImageGroup CDA
by tnisan＠redhat.com 11 Oct '15

11 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Exclude import VM from CopyImageGroup CDA ...................................................................... core: Exclude import VM from CopyImageGroup CDA Change-Id: I08fdc64a64ec328d4b62f6990cd766257c781b2e Bug-Url: https://bugzilla.redhat.com/1269948 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/47177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08fdc64a64ec328d4b62f6990cd766257c781b2e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Exclude import VM from CopyImageGroup CDA
by derez＠redhat.com 11 Oct '15

11 Oct '15

Daniel Erez has submitted this change and it was merged. Change subject: core: Exclude import VM from CopyImageGroup CDA ...................................................................... core: Exclude import VM from CopyImageGroup CDA Change-Id: I08fdc64a64ec328d4b62f6990cd766257c781b2e Bug-Url: https://bugzilla.redhat.com/1269948 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/47176 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08fdc64a64ec328d4b62f6990cd766257c781b2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: formatted ActivateStorageDomainCommand
by amureini＠redhat.com 11 Oct '15

11 Oct '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: formatted ActivateStorageDomainCommand ...................................................................... core: formatted ActivateStorageDomainCommand Change-Id: I45b01be4a070c244794cdb2a565bf9a96a459e80 Bug-Url: https://bugzilla.redhat.com/1164938 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45b01be4a070c244794cdb2a565bf9a96a459e80 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add tests for storage server connection extension
by tnisan＠redhat.com 11 Oct '15

11 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Add tests for storage server connection extension ...................................................................... core: Add tests for storage server connection extension Change-Id: I00ff096f9ae67e507605855c8f19858318645db9 Bug-Url: https://bugzilla.redhat.com/1265133 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageServerConnectionExtensionValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionExtensionCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageServerConnectionExtensionValidatorTest.java 3 files changed, 121 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Vered Volansky: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46816 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00ff096f9ae67e507605855c8f19858318645db9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Validate inexistance of connection extension upon update
by tnisan＠redhat.com 11 Oct '15

11 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Validate inexistance of connection extension upon update ...................................................................... core: Validate inexistance of connection extension upon update When updating a storage server connection extension, make sure that another connection for the same host and target combination does not exist Change-Id: I90c5f56356e8b1ad75861760b6375cd23869db35 Bug-Url: https://bugzilla.redhat.com/1265133 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionExtensionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionExtensionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionExtensionCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionExtensionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageServerConnectionExtensionValidator.java 5 files changed, 28 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Vered Volansky: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46814 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90c5f56356e8b1ad75861760b6375cd23869db35 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: packagers: minidnf: free base if beginTransaction fails
by Alon Bar-Lev 11 Oct '15

11 Oct '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: minidnf: free base if beginTransaction fails ...................................................................... packagers: minidnf: free base if beginTransaction fails Change-Id: I953e5d36573a5023dba2e8aef02f552fce32ef3f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/minidnf.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I953e5d36573a5023dba2e8aef02f552fce32ef3f Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: core: improve balance selection of vm for migration
by tnisan＠redhat.com 11 Oct '15

11 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: improve balance selection of vm for migration ...................................................................... core: improve balance selection of vm for migration Iterate over source hosts, to find vm that can be migrated, without over utilize memory or CPU of destination host. Before was selected some random source host, and from this host was selected single vm with minimum cpu usage, but maybe with big amount of memory usage and so over utilizied destination host memory. In result we had that balancing not migrate any of vms. Change-Id: I67947fa4463b8bb12d04ee8f4126fa93683c9e14 Bug-Url: https://bugzilla.redhat.com/1258780 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> (cherry picked from commit 737d14b5722a3cbbd5630e4d40e47e1f063e3e76) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java 1 file changed, 21 insertions(+), 41 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67947fa4463b8bb12d04ee8f4126fa93683c9e14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: improve balance selection of vm for migration
by tnisan＠redhat.com 11 Oct '15

11 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: improve balance selection of vm for migration ...................................................................... core: improve balance selection of vm for migration Iterate over source hosts, to find vm that can be migrated, without over utilize memory or CPU of destination host. Before was selected some random source host, and from this host was selected single vm with minimum cpu usage, but maybe with big amount of memory usage and so over utilizied destination host memory. In result we had that balancing not migrate any of vms. Change-Id: I67947fa4463b8bb12d04ee8f4126fa93683c9e14 Bug-Url: https://bugzilla.redhat.com/1258780 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> (cherry picked from commit 737d14b5722a3cbbd5630e4d40e47e1f063e3e76) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java 1 file changed, 21 insertions(+), 41 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Artyom Lukianov: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67947fa4463b8bb12d04ee8f4126fa93683c9e14 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0