- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: setup: adding an hint about serial console configuration
by sbonazzo＠redhat.com 08 Oct '15

08 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: adding an hint about serial console configuration ...................................................................... setup: adding an hint about serial console configuration If the user wants to manually install the Guest OS and no graphical connection is available, he could stll use the serial console but it has also to be enabled on guest side. Change-Id: Iec235fb4755ee88bd190c5b6a2a666e661d99b79 Bug-Url: https://bugzilla.redhat.com/1215436 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec235fb4755ee88bd190c5b6a2a666e661d99b79 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Disable warnings about private modules
by mperina＠redhat.com 08 Oct '15

08 Oct '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Disable warnings about private modules ...................................................................... core: Disable warnings about private modules The application server marks its modules as "private" using the "jaxb.api" property: <property name="jboss.api" value="private"/> When one of these "private" modules is used by an application the server issues the following warning during deployment of the application: JBAS018567: Deployment "deployment.myapp.ear" is using a private module ("org.apache.commons.lang:main") which may be changed or removed in future versions without notice. We are well aware of this, and we don't consider it problematic. This patch modifies the configuration of the logging subsystem so that warnings issued for that category will be ignred. Change-Id: I28ba11f34f1864500cf9e6f69b6765c3049cdf3e Bug-Url: https://bugzilla.redhat.com/1269413 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28ba11f34f1864500cf9e6f69b6765c3049cdf3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove disks and storage domain option from add VM ...
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Remove disks and storage domain option from add VM from config ...................................................................... restapi: Remove disks and storage domain option from add VM from config Change-Id: I0fdc659be984dd74ad19f904b884d6ebdc9cdb34 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1082977 --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fdc659be984dd74ad19f904b884d6ebdc9cdb34 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: db: executed config cleanup as upgrade script
by emesika＠redhat.com 08 Oct '15

08 Oct '15

Eli Mesika has submitted this change and it was merged. Change subject: db: executed config cleanup as upgrade script ...................................................................... db: executed config cleanup as upgrade script Up to now when a config entry was deprecated, we had to remove it in the pre-upgrade step calling fn_db_delete_config_value from 0000_config.sql. This may be problematic if a reference to the deleted entry exists in one of the upgrade scripts, in such case the entry will be removed in the pre-upgrade step and then the upgrade script referring this key will fail and cause all the upgrade process to fail. This patch moves all deprecated config entries to an upgrade script resolving this issue and adds additional benefit of executing all this mass removals only once instead doing that again and again on each upgrade. >From now on, please delete deprecated config entries in a regular upgrade script. Change-Id: I062b6c9df0f812e3e36cdfed36854dddb045c62d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1269796 Signed-off-by: emesika <emesika(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1880_delete_deprecated_config_values.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 177 insertions(+), 174 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I062b6c9df0f812e3e36cdfed36854dddb045c62d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: spice proxy not present in .vv file
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: spice proxy not present in .vv file ...................................................................... core: spice proxy not present in .vv file Just incorrect negation Change-Id: Ica120223b50bc8befd4387a0ba491c50e9e5f4b7 Bug-Url: https://bugzilla.redhat.com/1266497 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica120223b50bc8befd4387a0ba491c50e9e5f4b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Select the first CPU profile when multiple are available
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: Select the first CPU profile when multiple are available ...................................................................... Select the first CPU profile when multiple are available This patch fixes a regression where a VM could not be added to a cluster where multiple CPU profiles were defined without having a specific CPU profile assigned by the REST call. The fix is not ideal as we should redo the whole mechanism to make sure all permissions and quotas are obeyed. Change like that would be too invasive at this stage of development and we will address it for the next version or update. Change-Id: I462579ff12c8c4f97c72c08e12637cfedd766f10 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1262293 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 86ad52390c7328edd643a1a71ce4b6e48a480e31) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I462579ff12c8c4f97c72c08e12637cfedd766f10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal, webadmin: fixed login form validation
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: fixed login form validation ...................................................................... userportal, webadmin: fixed login form validation Login form was submitting blank fields, but not returning a "fields cannot be blank" message to the user. Fixed. Change-Id: I5bf7a3ea682a8e769d84aa590820c441d4fa178f Bug-Url: https://bugzilla.redhat.com/1251003 Bug-Url: https://bugzilla.redhat.com/1254940 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/47106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bf7a3ea682a8e769d84aa590820c441d4fa178f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal, webadmin: fixed login form column widths
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: fixed login form column widths ...................................................................... userportal, webadmin: fixed login form column widths Gave more width to labels and less to fields, to prevent text wrapping. Change-Id: I929f05509547e37fce5c99c4274f8577b390ec45 Bug-Url: https://bugzilla.redhat.com/1253302 Bug-Url: https://bugzilla.redhat.com/1254954 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/47103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I929f05509547e37fce5c99c4274f8577b390ec45 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Prevent auto-refresh engine's errata
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Prevent auto-refresh engine's errata ...................................................................... webadmin: Prevent auto-refresh engine's errata Auto-refresh of engine's errata causes the webadmin (and the engine) to behave slowly. The errata should be fetched for the engine only if the 'Errata' node is clicked on the system tree. Change-Id: I74d9ee14bc21c2b561ed651f7e5649b8c8ce9311 Bug-Url: https://bugzilla.redhat.com/1260499 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabEngineErrataPresenter.java 2 files changed, 0 insertions(+), 20 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47099 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74d9ee14bc21c2b561ed651f7e5649b8c8ce9311 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix scrolling in attach disk panel
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix scrolling in attach disk panel ...................................................................... webadmin: Fix scrolling in attach disk panel Change-Id: Iea9505bbe95b3f160fed4c554aa677717d4762ee Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1269206 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.ui.xml 2 files changed, 8 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea9505bbe95b3f160fed4c554aa677717d4762ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0