- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Contextual alert messages
by vszocs＠redhat.com 07 Oct '15

07 Oct '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Contextual alert messages ...................................................................... webadmin,userportal: Contextual alert messages This patch introduces an infrastructure for displaying contextual alert messages in top-center part of oVirt's main (post-login) UI. Being part of gwt-common module, this infrastructure is usable from both WebAdmin and UserPortal applications through AlertManager class. Messages shown via AlertManager are visible only within the main section; any messages requested while in login section will be 'replayed' once the user logs in. Messages shown via AlertManager are one-line messages. If the message overflows its designated alert box area, a tooltip is added so that moving mouse over that area reveals the full message. This patch also implements an 'Uncaught exception' alert message triggered by global uncaught exception handler (see BaseApplicationInit.initUncaughtExceptionHandler). This is to inform users about UI-specific runtime errors that might break UI behavior. Screenshots: 'Danger' alert http://imgur.com/xcZhcaK 'Warning' alert http://imgur.com/Jgdl6vA 'Success' alert http://imgur.com/U9EGejw 'Info' alert http://imgur.com/llLVR9d 'Danger' alert, with tooltip http://imgur.com/CDpgics Change-Id: Ic0928ea873305bf7246f6b7c6ec255fa785ca1b3 Bug-Url: https://bugzilla.redhat.com/1215727 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/ElementTooltip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainSectionPresenter.java M packaging/branding/ovirt.brand/branding.properties M packaging/branding/ovirt.brand/ovirt.css 10 files changed, 260 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/46191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0928ea873305bf7246f6b7c6ec255fa785ca1b3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: DOM flag to guard user interaction
by vszocs＠redhat.com 07 Oct '15

07 Oct '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: DOM flag to guard user interaction ...................................................................... webadmin,userportal: DOM flag to guard user interaction Both WebAdmin and UserPortal are single-page web applications comprised of multiple places (UI states). Transitions between application's places are triggered either via UI interaction (e.g. clicking a main tab) or via manual URL change. Once the application starts transitioning from one place to another, user interaction should be avoided. For human users, this is accomplished via invisible "glass" overlay [1] that effectively blocks user-triggered DOM events (e.g. click) from reaching application's UI. [1] com.gwtplatform.mvp.client.RootPresenter.RootView#glass For automated test scripts, checking for "glass" overlay can be unnecessarily complex. This patch ensures that DOM <body> flag (data attribute) is set to reflect the current status of the application:  <body data-app-status="busy">  <body data-app-status="ready"> ... </body> Change-Id: I214493322774cf7727433c3a63d6ebfa7d3177cc Bug-Url: https://bugzilla.redhat.com/1150581 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/LockInteractionManager.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/46796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I214493322774cf7727433c3a63d6ebfa7d3177cc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: move memory related utility method to utils class
by ahadas＠redhat.com 07 Oct '15

07 Oct '15

Arik Hadas has submitted this change and it was merged. Change subject: core: move memory related utility method to utils class ...................................................................... core: move memory related utility method to utils class Move the mapping of storage domain type to memory volume type to the MemoryUtils class. 1. It is the approapriate place for it to reside it as it is a utility method which is related to memory. 2. It removes wrong dependency between the memory volume builder for memory in live snapshots and the hiberante command. Change-Id: I49176df3d416448e2063438ccec6fbd50b251c64 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java 3 files changed, 13 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/46510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49176df3d416448e2063438ccec6fbd50b251c64 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: Make pki renewal doc url customizable
by sbonazzo＠redhat.com 07 Oct '15

07 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Make pki renewal doc url customizable ...................................................................... packaging: setup: Make pki renewal doc url customizable Change-Id: I0bc6b86f045205182375543fb19437b64ba11567 Bug-Url: https://bugzilla.redhat.com/1255808 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 2 files changed, 11 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bc6b86f045205182375543fb19437b64ba11567 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: exttool: aaa: do not add entity name by default
by tnisan＠redhat.com 07 Oct '15

07 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: exttool: aaa: do not add entity name by default ...................................................................... exttool: aaa: do not add entity name by default adding name by default with '*' does not enable search by id. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177762 Change-Id: Ie06467662e912c32e871db84b3bb1d607d9fcb09 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie06467662e912c32e871db84b3bb1d607d9fcb09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Select the first CPU profile when multiple are available
by rgolan＠redhat.com 07 Oct '15

07 Oct '15

Roy Golan has submitted this change and it was merged. Change subject: Select the first CPU profile when multiple are available ...................................................................... Select the first CPU profile when multiple are available This patch fixes a regression where a VM could not be added to a cluster where multiple CPU profiles were defined without having a specific CPU profile assigned by the REST call. The fix is not ideal as we should redo the whole mechanism to make sure all permissions and quotas are obeyed. Change like that would be too invasive at this stage of development and we will address it for the next version or update. Change-Id: I462579ff12c8c4f97c72c08e12637cfedd766f10 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1262293 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I462579ff12c8c4f97c72c08e12637cfedd766f10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Add tooltips to alias and source domain in move di...
by tnisan＠redhat.com 07 Oct '15

07 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add tooltips to alias and source domain in move disk dialog ...................................................................... webadmin: Add tooltips to alias and source domain in move disk dialog Added tooltips to disk alias and source domain name in disk allocation view it will now show a tooltip with the complete names Change-Id: Iabdd221d8f317f1e37a1c4cd836b9ac1722e9040 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1149450 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabdd221d8f317f1e37a1c4cd836b9ac1722e9040 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: post ovirt-hosted-engine-ha-1.3.0
by msivak＠redhat.com 07 Oct '15

07 Oct '15

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.3.0 ...................................................................... build: post ovirt-hosted-engine-ha-1.3.0 Change-Id: I21eb11249b68eb38ab7f44172e1bac49e031fa8d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21eb11249b68eb38ab7f44172e1bac49e031fa8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: jsonrpc: set the protocol as default
by piotr.kliczewski＠gmail.com 07 Oct '15

07 Oct '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: jsonrpc: set the protocol as default ...................................................................... jsonrpc: set the protocol as default We want to phase out xmlrpc so for cluster levels 3.6+ we won't let the user to use xmlrpc and set jsonrpc as default. Whenever we upgrade version of cluster we forbid when there are host which still use xmlrpc. As part of this patch we remove protocol which was never implemented and there are no plans to provide implementation. Change-Id: I34dbd73ea5d79a002ac5714f41b910f7e171daf0 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1249374 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsProtocol.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HostProtocol.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 15 files changed, 90 insertions(+), 13 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34dbd73ea5d79a002ac5714f41b910f7e171daf0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: build: post ovirt-hosted-engine-setup-1.3.0
by sbonazzo＠redhat.com 07 Oct '15

07 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-1.3.0 ...................................................................... build: post ovirt-hosted-engine-setup-1.3.0 Change-Id: I5b8b0491ee657de27e5f36c35ac97590cc530e1c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b8b0491ee657de27e5f36c35ac97590cc530e1c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0