- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Surround vds command with try catch.
by mlipchuk＠redhat.com 06 Oct '15

06 Oct '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Surround vds command with try catch. ...................................................................... core: Surround vds command with try catch. Avoid NPE when calling a query which fails on executing a VDS connect/disconnect command. The proposed fix is to surround the query calls of the VDS commands with try/catch, so the query will not fail and return Null as a result. Change-Id: Ife176c6db31382053d6f96747b1bc6011a630582 Bug-Url: https://bugzilla.redhat.com/1263695 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/47020 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife176c6db31382053d6f96747b1bc6011a630582 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: validate full fqdn
by sbonazzo＠redhat.com 06 Oct '15

06 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: validate full fqdn ...................................................................... packaging: setup: validate full fqdn ovirt-hosted-engine-setup must validate the full fqdn instead of just validate the domain part of the hostname. Change-Id: I9dd0e6a39b2e4c920be18daa72fe142ff9f9a050 Bug-Url: https://bugzilla.redhat.com/1221176 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/fqdn.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/46987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dd0e6a39b2e4c920be18daa72fe142ff9f9a050 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Findbugs cleanup
by juan.hernandez＠redhat.com 06 Oct '15

06 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Findbugs cleanup ...................................................................... core: Findbugs cleanup The findbugs general filters file has beem moved to the "ovirt-findbugs-filters" project, so it isn't required in the root directory any longer. The RPM dependencies introduced by the custom findbugs plugin aren't needed either, as it has been removed. Change-Id: Ide0ad1af46865d1081923f3c7068f4fd781813f2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D exclude-filters-general.xml M ovirt-engine.spec.in M pom.xml 3 files changed, 6 insertions(+), 65 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide0ad1af46865d1081923f3c7068f4fd781813f2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: validate full fqdn
by sbonazzo＠redhat.com 06 Oct '15

06 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: validate full fqdn ...................................................................... packaging: setup: validate full fqdn ovirt-engine must validate the full fqdn instead of just the domain part of the hostname. Change-Id: Ibd848130c2da7285c08500f7ef69d4d0069749f0 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/hostname.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/46988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd848130c2da7285c08500f7ef69d4d0069749f0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Allow edit of wipe after delete when the VM is not...
by tnisan＠redhat.com 06 Oct '15

06 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow edit of wipe after delete when the VM is not down ...................................................................... webadmin: Allow edit of wipe after delete when the VM is not down In fact, wipe after delete is possible in any case unless when the VM is a part of a pool Change-Id: Ic7030fd98045d624cba048ca6f0eeb1c85a58f62 Bug-Url: https://bugzilla.redhat.com/1258901 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7030fd98045d624cba048ca6f0eeb1c85a58f62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Indent disk notes upon disk removal
by tnisan＠redhat.com 06 Oct '15

06 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Indent disk notes upon disk removal ...................................................................... webadmin: Indent disk notes upon disk removal Change-Id: I38f0758e313aaeb01a2381ee5a6daa1efe96103f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1139249 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractDiskRemoveConfirmationPopupView.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38f0758e313aaeb01a2381ee5a6daa1efe96103f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Show correct error message on image export
by tnisan＠redhat.com 06 Oct '15

06 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Show correct error message on image export ...................................................................... webadmin: Show correct error message on image export The error message when no extenal image provider is configured wrongly was that no storage domain is available, it was changed to show the correct reason Change-Id: I9ba2a8a0b2f009ffb81671345e5b36275ce6e338 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1142786 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ExportRepoImageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportExportRepoImageBaseModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportRepoImageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 4 files changed, 16 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ba2a8a0b2f009ffb81671345e5b36275ce6e338 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: disks main-tab - warning on live migrate disks
by tnisan＠redhat.com 06 Oct '15

06 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: disks main-tab - warning on live migrate disks ...................................................................... webadmin: disks main-tab - warning on live migrate disks Disks main-tab -> Move dialog: display a relevant warning when a disk is attached to a running VM. Change-Id: I7726f9b5e3de80e08a1d65d8c04ab3b5260cd392 Bug-Url: https://bugzilla.redhat.com/1264643 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/CopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 4 files changed, 65 insertions(+), 39 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Daniel Erez: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/47016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7726f9b5e3de80e08a1d65d8c04ab3b5260cd392 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Force version 3.x of findbugs
by juan.hernandez＠redhat.com 06 Oct '15

06 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Force version 3.x of findbugs ...................................................................... core: Force version 3.x of findbugs This patch changes the findbugs configuration so that instead of using a custom plugin it uses an artifact containing the shared filters. This artifact is then added to the class path of the findbugs plugin, together with version 3.x of findbugs. This allows us to use the old version of the plugin (which supports multiple filter files) with the new version of findbugs itself (which supports Java 8). In the future, we should be able to use the new version of the plugin, when it eventually supports multiple filter files: Support multiple include and exclude filter files https://github.com/gleclaire/findbugs-maven-plugin/pull/28 Change-Id: Idf0d7202c125320188280ffc9eae1ba36c785fc2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml A backend/manager/modules/auth-plugin/exclude-filters.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml A backend/manager/modules/logger/exclude-filters.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/tools/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml A build-tools-root/ovirt-checkstyle-extension/exclude-filters.xml A build-tools-root/ovirt-findbugs-filters/pom.xml R build-tools-root/ovirt-findbugs-filters/src/main/resources/exclude-filters-general.xml D build-tools-root/ovirt-findbugs-maven-plugin/pom.xml D build-tools-root/ovirt-findbugs-maven-plugin/src/main/java/org/ovirt/maven/plugins/findbugs/FindbugsMojo.java M build-tools-root/pom.xml D findbugs.sh M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M pom.xml 43 files changed, 139 insertions(+), 1,879 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve; Passed CI tests Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf0d7202c125320188280ffc9eae1ba36c785fc2 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: remove addVmTemplateCinderDisks from transaction
by tnisan＠redhat.com 06 Oct '15

06 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: remove addVmTemplateCinderDisks from transaction ...................................................................... core: remove addVmTemplateCinderDisks from transaction AddVmTemplateCommand: Extracted 'addVmTemplateCinderDisks' invocation from within transaction. Change-Id: I847d80d4798aafd59b92e060039b25efd71840b9 Bug-Url: https://bugzilla.redhat.com/1264677 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 5 files changed, 17 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I847d80d4798aafd59b92e060039b25efd71840b9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0