- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Remove NIC "active"
by juan.hernandez＠redhat.com 14 Sep '15

14 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove NIC "active" ...................................................................... restapi: Remove NIC "active" The NIC "active" property was replaced by "plugged" some time ago. This patch removes it completely. Change-Id: I0a5a77297f751e5b6c63a2dee69b0d46b0c2a3ec Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a5a77297f751e5b6c63a2dee69b0d46b0c2a3ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove NIC "network" and "port_mirroring"
by juan.hernandez＠redhat.com 14 Sep '15

14 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove NIC "network" and "port_mirroring" ...................................................................... restapi: Remove NIC "network" and "port_mirroring" The NIC "network" and "port_mirroring" elements have been replaced by the "vnic_profile" element, so when creating or updating a NIC instead of specifying the network and port mirroring configuration, these are previusly specified creating a VNIC profile: POST /vnicprofiles <vnic_profile> <name>myprofile</name> <network id="..."/> <port_mirroring>true</port_mirroring> </vnic_profile> And then the NIC is created or updated referencing the existing VNIC profile: PUT /vms/{vm:id}/nics/{nic:id} <nic> <vnic_profile id="/vnicprofiles/..."> </nic> The old elements and their meaning were preserved for backwards compatibility, but this patch removes them almost completely. Note that the "network" element hasn't been removed from the XML schema because it is still used by the "initialization" element, but it will be completely ignored if provided when creating or updating a NIC. Change-Id: I1d6b2544c3b362cbebbca78e3276e8d182c78c3a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNicResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateNicResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NicMapperTest.java 17 files changed, 76 insertions(+), 625 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d6b2544c3b362cbebbca78e3276e8d182c78c3a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: scheduler: Select first schedulable VM from candidate pool
by piotr.kliczewski＠gmail.com 14 Sep '15

14 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: scheduler: Select first schedulable VM from candidate pool ...................................................................... scheduler: Select first schedulable VM from candidate pool When enforcing affinity groups, the enforcer should check every possible candidate until it finds the first schedulable migration instead of choosing one possible candidate randomly and do nothing if the migration of that candidate is not schedulable. Bug-Url: https://bugzilla.redhat.com/1251742 Change-Id: Icd7d039a49252028f8ce14b5ddcb3e9183e62e9a Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java 2 files changed, 77 insertions(+), 38 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd7d039a49252028f8ce14b5ddcb3e9183e62e9a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: scheduler: Fix migration free cluster detection
by piotr.kliczewski＠gmail.com 14 Sep '15

14 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: scheduler: Fix migration free cluster detection ...................................................................... scheduler: Fix migration free cluster detection Accidently the VdsId was used where the VdsGroupId should have been used. This change directly queries for all VdsGroups where no VM is currently migrating. - Remove getAllByStatus() from VmDynamicDao - Add VdsGroupDao#getWithoutMigratingVms and use it in AREM Bug-Url: https://bugzilla.redhat.com/1251742 Change-Id: Ib2d3383750babf1d1f295d423939bb1fa03e5bee Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDaoTest.java M packaging/dbscripts/vds_groups_sp.sql M packaging/dbscripts/vms_sp.sql 11 files changed, 62 insertions(+), 88 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2d3383750babf1d1f295d423939bb1fa03e5bee Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: HA reservation needs to take the full VM's memory into account
by rgolan＠redhat.com 13 Sep '15

13 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: HA reservation needs to take the full VM's memory into account ...................................................................... HA reservation needs to take the full VM's memory into account The current HA reservation code only counted the used memory of HA VMs. But the engine will refuse to migrate the VM when there is not enough memory when compared to the minimum guaranteed settings. This patch updates the computation and uses the minimum guaranteed memory size or the currently used amount of memory whichever is higher. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1220134 Change-Id: Ib3af7e370f004f7c22335c507e4e191b90166f6d Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified Dudi Maroshi: Looks good to me, but someone else must approve Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3af7e370f004f7c22335c507e4e191b90166f6d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix getUnderUtilizedCPUHosts function to get correct h...
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fix getUnderUtilizedCPUHosts function to get correct hosts ...................................................................... core: fix getUnderUtilizedCPUHosts function to get correct hosts power_saving balance module ignore CPU under utilizied hosts, because incorrect timestamp condition Change-Id: Ia104faadff453a179a6e0f9496d55e964a117c24 Bug-Url: https://bugzilla.redhat.com/1258739 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> (cherry picked from commit a80123dadd379833c14d5096265a1e3554865db0) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Verified Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Artyom Lukianov: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia104faadff453a179a6e0f9496d55e964a117c24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: scheduler: Fix migration free cluster detection
by rgolan＠redhat.com 13 Sep '15

13 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: scheduler: Fix migration free cluster detection ...................................................................... scheduler: Fix migration free cluster detection Accidently the VdsId was used where the VdsGroupId should have been used. This change directly queries for all VdsGroups where no VM is currently migrating. - Remove getAllByStatus() from VmDynamicDao - Add VdsGroupDao#getWithoutMigratingVms and use it in AREM Bug-Url: https://bugzilla.redhat.com/1251742 Change-Id: Ib2d3383750babf1d1f295d423939bb1fa03e5bee Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDaoTest.java M packaging/dbscripts/vds_groups_sp.sql M packaging/dbscripts/vms_sp.sql 10 files changed, 62 insertions(+), 89 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Tomer Saban: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2d3383750babf1d1f295d423939bb1fa03e5bee Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: improve balance selection of vm for migration
by rgolan＠redhat.com 13 Sep '15

13 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: core: improve balance selection of vm for migration ...................................................................... core: improve balance selection of vm for migration Iterate over source hosts, to find vm that can be migrated, without over utilize memory or CPU of destination host. Before was selected some random source host, and from this host was selected single vm with minimum cpu usage, but maybe with big amount of memory usage and so over utilizied destination host memory. In result we had that balancing not migrate any of vms. Change-Id: I67947fa4463b8bb12d04ee8f4126fa93683c9e14 Bug-Url: https://bugzilla.redhat.com/1258780 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java 1 file changed, 21 insertions(+), 41 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Artyom Lukianov: Verified -- To view, visit https://gerrit.ovirt.org/45574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67947fa4463b8bb12d04ee8f4126fa93683c9e14 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add lock on Extend SD command
by amureini＠redhat.com 13 Sep '15

13 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Add lock on Extend SD command ...................................................................... engine: Add lock on Extend SD command In order to prevent to run the Extend Storage Domain command twice at the same time, an exclusive lock is added to the command. Running this command twice will put the VG in a partial state, creating a PV twice on the same device. Change-Id: Ib9062ba235daa1d25298f1d295b17d15e1528c80 Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1258632 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/46082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9062ba235daa1d25298f1d295b17d15e1528c80 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: EventsSupported configuratoin. check the EventsSupported con...
by ofrenkel＠redhat.com 13 Sep '15

13 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: EventsSupported configuratoin. check the EventsSupported configuratoin for cross object type support and not just for vms. ...................................................................... EventsSupported configuratoin. check the EventsSupported configuratoin for cross object type support and not just for vms. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258812 Change-Id: I1ed2c87047b515c670d8bd0ea5d88c452087aa50 Signed-off-by: emarcian <emarcian(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed2c87047b515c670d8bd0ea5d88c452087aa50 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0