- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: wrong validation order and wrong translation.
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: wrong validation order and wrong translation. ...................................................................... core: wrong validation order and wrong translation. Change-Id: Ia3c327dc5b02d68e3f17a2884b57a66d4be3f570 Bug-Url: https://bugzilla.redhat.com/1217943 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3c327dc5b02d68e3f17a2884b57a66d4be3f570 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: unable to remove unmanaged network
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: unable to remove unmanaged network ...................................................................... webadmin: unable to remove unmanaged network Change-Id: Ia3730e394bacb74741922d773758c8d1d34ff6d5 Bug-Url: https://bugzilla.redhat.com/1257027 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3730e394bacb74741922d773758c8d1d34ff6d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fill-in default bonding options if no options are spec...
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fill-in default bonding options if no options are specified ...................................................................... core: fill-in default bonding options if no options are specified when some bond in given modified_bonds collection does not have bond option set (is null or empty string), set it to default "mode=4 miimon=100" Change-Id: I8b5f8e598cfefea1365ec11855bc7d7a638b39f0 Bug-Url: https://bugzilla.redhat.com/1249119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b5f8e598cfefea1365ec11855bc7d7a638b39f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: end-migration of powering up vm
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: end-migration of powering up vm ...................................................................... core: end-migration of powering up vm The monitoring didn't recognize a transition of powering up on the source host to powering up on the destination host as successful migration. Therefore, runningSucceeded method of the migrate-command was not called and in case of a migration between different clusters, the cluster of the VM was not updated. Change-Id: Ifbafd0b22d8a9c1d5e1635321ee21ce9bb7f2aa3 Bug-Url: https://bugzilla.redhat.com/1177236 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/46080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbafd0b22d8a9c1d5e1635321ee21ce9bb7f2aa3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix graphics on import
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fix graphics on import ...................................................................... core: fix graphics on import 1. restore display type values: the values for cirrus (vnc) and qxl changed, this breaks backward compatibility with previously exported vms, so restored to original values. 2. the code that create graphics device on import was called too soon, and device was removed while reloading the vm from export domain during canDoAction, so moved the call to a better place. 3. fixed that code to select spice for qxl, if os support it, to match the previous values in the engine (qxl was always spice) Change-Id: I3fd8351a3f18428cfe905a39221756608b64da05 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261446 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DisplayType.java A packaging/dbscripts/upgrade/03_06_1820_fix_display_type_numbers.sql 4 files changed, 19 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd8351a3f18428cfe905a39221756608b64da05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: balloon always reset when editing VM from REST
by ofrenkel＠redhat.com 13 Sep '15

13 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: balloon always reset when editing VM from REST ...................................................................... core: balloon always reset when editing VM from REST Since the balloonEnabled in VmTemplateParametersBase was small boolean, it was not possible to decide if the passed false means really "false" or remove. Fixed the same way as it it done on the update VM case. Change-Id: I16adef671bc77e26f56657add59621a1aa9b1c4a Bug-Url: https://bugzilla.redhat.com/1241279 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java 2 files changed, 19 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16adef671bc77e26f56657add59621a1aa9b1c4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fill-in default bonding options if no options are spec...
by alkaplan＠redhat.com 12 Sep '15

12 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: fill-in default bonding options if no options are specified ...................................................................... core: fill-in default bonding options if no options are specified when some bond in given modified_bonds collection does not have bond option set (is null or empty string), set it to default "mode=4 miimon=100" Change-Id: I8b5f8e598cfefea1365ec11855bc7d7a638b39f0 Bug-Url: https://bugzilla.redhat.com/1249119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b5f8e598cfefea1365ec11855bc7d7a638b39f0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: wrong validation order and wrong translation.
by alkaplan＠redhat.com 12 Sep '15

12 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: wrong validation order and wrong translation. ...................................................................... core: wrong validation order and wrong translation. Change-Id: Ia3c327dc5b02d68e3f17a2884b57a66d4be3f570 Bug-Url: https://bugzilla.redhat.com/1217943 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44242 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3c327dc5b02d68e3f17a2884b57a66d4be3f570 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: setup: Move aaa-jdbc dependency to setup
by piotr.kliczewski＠gmail.com 11 Sep '15

11 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: setup: Move aaa-jdbc dependency to setup ...................................................................... setup: Move aaa-jdbc dependency to setup Moves ovirt-engine-extension-aaa-jdbc dependency from ovirt-engine-backend to ovirt-engine-setup-plugin-ovirt-engine. Change-Id: Ie980fef0b035b4d2880560ceff8e2194a75d7b10 Bug-Url: https://bugzilla.redhat.com/1260573 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified -- To view, visit https://gerrit.ovirt.org/46063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie980fef0b035b4d2880560ceff8e2194a75d7b10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: setup: Move aaa-jdbc dependency to setup
by sbonazzo＠redhat.com 11 Sep '15

11 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: Move aaa-jdbc dependency to setup ...................................................................... setup: Move aaa-jdbc dependency to setup Moves ovirt-engine-extension-aaa-jdbc dependency from ovirt-engine-backend to ovirt-engine-setup-plugin-ovirt-engine and adds message to user that that upgrading schema for custom aaa-jdbc profiles may be necessary. Change-Id: Ie980fef0b035b4d2880560ceff8e2194a75d7b10 Bug-Url: https://bugzilla.redhat.com/1260573 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie980fef0b035b4d2880560ceff8e2194a75d7b10 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0