- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Enable memory hotplug on ppc64
by tjelinek＠redhat.com 10 Sep '15

10 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Enable memory hotplug on ppc64 ...................................................................... core: Enable memory hotplug on ppc64 Change-Id: I8dc6eae1d6b6e112a3805fb2095ba58a831fcb9d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1224886 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dc6eae1d6b6e112a3805fb2095ba58a831fcb9d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: build: cleanup war packaging
by masayag＠redhat.com 10 Sep '15

10 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: build: cleanup war packaging ...................................................................... build: cleanup war packaging archive classes as jar. avoid archiving maven information. Change-Id: I6a6a28f11993f86794c955f210543c02ac209185 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/docs/pom.xml M backend/manager/modules/services/pom.xml A backend/manager/modules/welcome/exclude-filters.xml M backend/manager/modules/welcome/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 6 files changed, 124 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6a28f11993f86794c955f210543c02ac209185 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix graphics on import
by ofrenkel＠redhat.com 09 Sep '15

09 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix graphics on import ...................................................................... core: fix graphics on import 1. restore display type values: the values for cirrus (vnc) and qxl changed, this breaks backward compatibility with previously exported vms, so restored to original values. 2. the code that create graphics device on import was called too soon, and device was removed while reloading the vm from export domain during canDoAction, so moved the call to a better place. 3. fixed that code to select spice for qxl, if os support it, to match the previous values in the engine (qxl was always spice) Change-Id: I3fd8351a3f18428cfe905a39221756608b64da05 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261446 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DisplayType.java A packaging/dbscripts/upgrade/03_06_1830_fix_display_type_numbers.sql 4 files changed, 19 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Frank Kobzik: Looks good to me, but someone else must approve Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd8351a3f18428cfe905a39221756608b64da05 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Serial console public key config
by juan.hernandez＠redhat.com 09 Sep '15

09 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Serial console public key config ...................................................................... restapi: Serial console public key config Add REST API to list, add and delete SSH Public Keys to users. Due to internal limitations, at most one key can be registered to any user. The API, however, already expose a collection interface to accomodate future extensions. Change-Id: I8a4fb034637d57e7d61255bdb4ad0b6ea1076717 Bug-Url: https://bugzilla.redhat.com/1254445 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/SSHPublicKeyResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/SSHPublicKeysResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/UserResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendSSHPublicKeyResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendSSHPublicKeysResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/SSHPublicKeyMapper.java 10 files changed, 329 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/45054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a4fb034637d57e7d61255bdb4ad0b6ea1076717 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Network utilisation is not shown for the VM
by ofrenkel＠redhat.com 09 Sep '15

09 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Network utilisation is not shown for the VM ...................................................................... core: Network utilisation is not shown for the VM Network utilization was not shown for a vm. The network utilization was calculated but not added to the network utilization history. Change-Id: I81100cc8369abe1ff8929478e1556c4e1ab81c2a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1196640 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81100cc8369abe1ff8929478e1556c4e1ab81c2a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: packaging: fixing variable substitution and requiring sudo
by msivak＠redhat.com 09 Sep '15

09 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: packaging: fixing variable substitution and requiring sudo ...................................................................... packaging: fixing variable substitution and requiring sudo Fixing variable substitution and requiring sudo Change-Id: Icf576b814145f19f9f94eb94d210dfe85bc6bfdc Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in M sudoers/Makefile.am 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf576b814145f19f9f94eb94d210dfe85bc6bfdc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: block move and copy for Cinder disks
by derez＠redhat.com 09 Sep '15

09 Sep '15

Daniel Erez has submitted this change and it was merged. Change subject: core: block move and copy for Cinder disks ...................................................................... core: block move and copy for Cinder disks Blocking move/copy operations on CanDo for Cinder disks: * Added validation on DiskValidator. * Modified CanDo on MoveDisksCommand and CopyImageGroupCommand. * Updated tests accordingly. Change-Id: I3c166b4f0190d0384283d69eab3e188b35986b2b Bug-Url: https://bugzilla.redhat.com/1258932 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 62 insertions(+), 25 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c166b4f0190d0384283d69eab3e188b35986b2b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: brokerlink: ensuring that makefile is working in blocking mode
by msivak＠redhat.com 09 Sep '15

09 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: brokerlink: ensuring that makefile is working in blocking mode ...................................................................... brokerlink: ensuring that makefile is working in blocking mode socket.makefile() requires a socket in blocking mode. Enforcing it. Change-Id: I8379d0be600efb1e50b9e291ccfba5fc61143f20 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/env/constants.py.in M ovirt_hosted_engine_ha/lib/brokerlink.py M ovirt_hosted_engine_ha/lib/util.py 3 files changed, 15 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8379d0be600efb1e50b9e291ccfba5fc61143f20 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: frontend: Show all pinned hosts in general model forms
by tnisan＠redhat.com 09 Sep '15

09 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Show all pinned hosts in general model forms ...................................................................... frontend: Show all pinned hosts in general model forms A vm can be pinned to multiple VMs. Only one of them was shown. Show them as a comma separated list of all host names, including a tooltip. Affected locations are: * General overview tab for VMs (AdminPortal) * General overview tab for VMs (UserPortal) * General overview tab for Pools (AdminPortal) * General overview tab for Pools (UserPortal) Change-Id: I4e9b8e5288efb5ea5f612e93e6361685b7f32999 Bug-Url: https://bugzilla.redhat.com/1256683 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> (cherry picked from commit 63e0045341b55b2ca0d506a09837a35302f3ab5c) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java 6 files changed, 29 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Roman Mohr: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e9b8e5288efb5ea5f612e93e6361685b7f32999 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Initialize volume for volume classification.
by mlipchuk＠redhat.com 09 Sep '15

09 Sep '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Initialize volume for volume classification. ...................................................................... core: Initialize volume for volume classification. Cloned Cinder disk should have volume classification specified as volume. Change-Id: I76094a8220e93ce26d109d6a10834d58f8d6acee Bug-Url: https://bugzilla.redhat.com/1255221 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/45901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76094a8220e93ce26d109d6a10834d58f8d6acee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0