- Engine-commits - oVirt List Archives

Change in jenkins[master]: virtio-win-drivers: publish
by sbonazzo＠redhat.com 09 Sep '15

09 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: virtio-win-drivers: publish ...................................................................... virtio-win-drivers: publish Publish virtio-win-drivers on 3.6 and master repos. Change-Id: I1dbf613acfe5a0f44bee6473952c40c94372da0a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/45781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dbf613acfe5a0f44bee6473952c40c94372da0a Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: network: NetworkView equals incorrect
by tnisan＠redhat.com 09 Sep '15

09 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: network: NetworkView equals incorrect ...................................................................... network: NetworkView equals incorrect NetworkView.equals does not compare provider names correctly. Bug-Url: https://bugzilla.redhat.com/1180891 Change-Id: Ib2135cfa196efc4db9222c90f541a0a14f115d47 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2135cfa196efc4db9222c90f541a0a14f115d47 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal: User portal error message when changing VM clust...
by tnisan＠redhat.com 09 Sep '15

09 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal: User portal error message when changing VM cluster inconsistent with webadmin ...................................................................... userportal: User portal error message when changing VM cluster inconsistent with webadmin The error message displayed in user portal when changing VM cluster is inconsistant with the admin portal. This is because the user portal invoked first the ChangeVMCluster command, and then the UpdateVm command, without checking if the first command was successful. The meaningful message from the first command was overshaddowed by the less accurate message from the second command. Now the second command will only be invoked if the first command was successful. Change-Id: I6daaf41c4e09516eb503178b39d3a603dc11c7d1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149092 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6daaf41c4e09516eb503178b39d3a603dc11c7d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: redundant scrollbar in SetupNetworks dialog
by alkaplan＠redhat.com 09 Sep '15

09 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: redundant scrollbar in SetupNetworks dialog ...................................................................... webadmin: redundant scrollbar in SetupNetworks dialog The setup networks dialog was slightly too small and a redundant vertical scroll bar was displayed. The dialog has been made slightly higher to accomodate all its contents without the scroll bar. Change-Id: I3af6cdcdccd59ba45292d13ffd16cb6d820987ce Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1140526 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Marcin Mirecki: Verified Alona Kaplan: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3af6cdcdccd59ba45292d13ffd16cb6d820987ce Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: attach operation fails for new network with label
by alkaplan＠redhat.com 09 Sep '15

09 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: attach operation fails for new network with label ...................................................................... engine: attach operation fails for new network with label Attaching a network to NIC fails via label when the NIC has a label and a new network is created with the same label. (Same error for VLAN/non-VLAN and non-VM network) Change-Id: Ib03c247150982e23a9642caba8e3890e6715f2d1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252125 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib03c247150982e23a9642caba8e3890e6715f2d1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: sharedconf: always read/write the shared configuration as VD...
by msivak＠redhat.com 09 Sep '15

09 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: sharedconf: always read/write the shared configuration as VDSM user ...................................................................... sharedconf: always read/write the shared configuration as VDSM user The shared conf lib is in use also by ovirt-hosted-engine-setup which is executed as root. On NFS shared storage, root could be inhibited to write so ensure we are always writing as VDSM user. Removing latest dependency on heconflib from from ovirt-hosted-engine-setup Change-Id: I973c1423b7f07b37014d2c1f688f28f730a7eddc Bug-Url: https://bugzilla.redhat.com/1254671 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/env/config.py M ovirt_hosted_engine_ha/lib/heconflib.py 2 files changed, 16 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I973c1423b7f07b37014d2c1f688f28f730a7eddc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: setup: relying on heconflib from ovirt-hosted-engine-ha
by sbonazzo＠redhat.com 09 Sep '15

09 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: relying on heconflib from ovirt-hosted-engine-ha ...................................................................... setup: relying on heconflib from ovirt-hosted-engine-ha Since https://gerrit.ovirt.org/#/c/44836/ HAConfLib has been moved to ovirt-hosted-engine-ha package cause it's needed also on the 3.5 -> 3.6 upgrade path which doesn't involve ovirt-hosted-engine-setup. Relying just on that copy to makes maintenance easier. Change-Id: I00f14453aadd803bfb05800dd922a03d46d08336 Bug-Url: https://bugzilla.redhat.com/1254671 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/Makefile.am D src/ovirt_hosted_engine_setup/heconflib.py M src/ovirt_hosted_engine_setup/util.py M src/plugins/ovirt-hosted-engine-setup/storage/heconf.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py M src/plugins/ovirt-hosted-engine-setup/vm/image.py 7 files changed, 14 insertions(+), 369 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00f14453aadd803bfb05800dd922a03d46d08336 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: pki: remove ssh-keygen hacks
by sbonazzo＠redhat.com 09 Sep '15

09 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: pki: remove ssh-keygen hacks ...................................................................... pki: remove ssh-keygen hacks ssh-keygen hacks were introduced to bridge the gap of el6 old and patched ssh-keygen. we no longer support el6 so these hacks can be removed in favor of standard ssh-keygen. Change-Id: I9d50ae2f654175e6eae03fc89266c46b2a265501 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in M packaging/bin/pki-enroll-openssh-cert.sh D packaging/bin/pki-ssh-keygen.py M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ssh.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py 6 files changed, 45 insertions(+), 127 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d50ae2f654175e6eae03fc89266c46b2a265501 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: encode non-ASCII disk alias/description
by tnisan＠redhat.com 09 Sep '15

09 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: encode non-ASCII disk alias/description ...................................................................... core: encode non-ASCII disk alias/description Patch Ie2642ae7 causes the disk alias and description to be stored in the disk's metadata. Since vdsm expects for ASCII characters only, and since both fields can contain non-ASCII characters, the operation fails on vdsm. This patch encodes these fields if they contain non-ASCII characters using HEX encoding (and decodes when reading them), so that vdsm can handle these fields even if they contain non-ASCII characters. Change-Id: I3180ea2458ca9bd426513108e741dd0f56c8b96e Bug-Url: https://bugzilla.redhat.com/1249130 Bug-Url: https://bugzilla.redhat.com/1219680 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java 3 files changed, 205 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/45900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3180ea2458ca9bd426513108e741dd0f56c8b96e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup:avoid asking cluster name on automatic depl...
by sbonazzo＠redhat.com 09 Sep '15

09 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup:avoid asking cluster name on automatic deployment ...................................................................... packaging: setup:avoid asking cluster name on automatic deployment If the user selected to automatically execute engine-setup on the appliace for sure we have just the Default cluster so asking is just a waste of time. Bug-Url: https://bugzilla.redhat.com/1260161 Change-Id: Ib0fa01648069ad356a427b8517060a69ee64868b Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 7133664b357516b9cc85af303e7badd583ae06e9) --- M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0fa01648069ad356a427b8517060a69ee64868b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0