- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Support host certificate enrollment
by oourfali＠redhat.com 02 Aug '15

02 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Support host certificate enrollment ...................................................................... restapi: Support host certificate enrollment The patch adds support for enrolling certificates for hosts. The ability to enroll certificate replaces the use of the blown installation process for this specific case. POST: /api/hosts/{host:id}/enrollcertificate Change-Id: I73058677ca732ded768362ded769c8833613ad3d Bug-Url: https://bugzilla.redhat.com/1188759 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java 5 files changed, 34 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73058677ca732ded768362ded769c8833613ad3d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: host-deploy: Support renewing host certificate
by oourfali＠redhat.com 02 Aug '15

02 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: Support renewing host certificate ...................................................................... host-deploy: Support renewing host certificate The patch provides the administrator the ability to renew host certificate without the need to reinstall the host as used before. Change-Id: I00cbd07725c076e1c0039149eade3878773bc209 Bug-Url: https://bugzilla.redhat.com/1188759 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostEnrollCertificateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostEnrollCertificateInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 137 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43914 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00cbd07725c076e1c0039149eade3878773bc209 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Custom jboss login plugin module for JMX
by masayag＠redhat.com 02 Aug '15

02 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Custom jboss login plugin module for JMX ...................................................................... core: Custom jboss login plugin module for JMX This plugin will enable us to authenticate engine admin users into Jboss's JMX interface. We can either invoke then the jbosscli.sh or jconsole or whatever tool that uses JMX and needs authentication. - only superusers can login - only 127.0.0.1 is exposed - failed login fails noisely - there is no proper error printed to the screen USAGE: $JBOSS_HOME/bin/jboss-cli.sh \ --controller=127.0.0.1:8706 --connect --user=admin@internal COMMAND if COMMAND is missing it enters interactive mode. Examples of COMMANDs: - increase bll log level to debug: /subsystem=logging/logger=org.ovirt.engine.core.bll:write-attribute(name=level,value=DEBUG)" - add logger /subsystem=logging/logger=org.ovirt.engine:add - get the engine data-source statistics: ls /subsystem=datasources/data-source=ENGINEDataSource/statistics=jdbc - get Threading info ls /core-service=platform-mbean/type=threading/ [1] Jboss custom login modules: https://docs.jboss.org/author/display/AS71/Security+Realms [2] CLI recepies - https://docs.jboss.org/author/display/WFLY8/CLI+Recipes Change-Id: I0e504c9b429f7fe02d42b0170e6e3a08b801efae Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A backend/manager/modules/auth-plugin/pom.xml A backend/manager/modules/auth-plugin/src/main/java/org/ovirt/engine/core/jboss_auth_plugin/OvirtAuthPlugIn.java A backend/manager/modules/auth-plugin/src/main/java/org/ovirt/engine/core/jboss_auth_plugin/OvirtAuthPlugInProvider.java A backend/manager/modules/auth-plugin/src/main/modules/org/ovirt/engine/core/auth-plugin/main/module.xml A backend/manager/modules/auth-plugin/src/main/resources/META-INF/services/org.jboss.as.domain.management.plugin.PlugInProvider A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/isUserApplicationContainerManagerQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/pom.xml M packaging/services/ovirt-engine/ovirt-engine.xml.in 9 files changed, 197 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/29693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e504c9b429f7fe02d42b0170e6e3a08b801efae Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: page: Be more specififc about the Engine password
by fabiand＠redhat.com 31 Jul '15

31 Jul '15

Fabian Deutsch has submitted this change and it was merged. Change subject: page: Be more specififc about the Engine password ...................................................................... page: Be more specififc about the Engine password Setting an engine password will enable SSH and set#s the root password. This was not said explicitly before, but should be said, to give the user a sense for any potential risk. Change-Id: I7d1a309bafe545c4a71e8ef315a9330c964cc732 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1245143 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> Reviewed-on: https://gerrit.ovirt.org/44236 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> Tested-by: Fabian Deutsch <fabiand(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/44252 Continuous-Integration: Fabian Deutsch <fabiand(a)redhat.com> --- M src/engine_page.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d1a309bafe545c4a71e8ef315a9330c964cc732 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: page: Be more specififc about the Engine password
by fabiand＠redhat.com 31 Jul '15

31 Jul '15

Fabian Deutsch has submitted this change and it was merged. Change subject: page: Be more specififc about the Engine password ...................................................................... page: Be more specififc about the Engine password Setting an engine password will enable SSH and set#s the root password. This was not said explicitly before, but should be said, to give the user a sense for any potential risk. Change-Id: I7d1a309bafe545c4a71e8ef315a9330c964cc732 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1245143 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> Reviewed-on: https://gerrit.ovirt.org/44236 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> Tested-by: Fabian Deutsch <fabiand(a)redhat.com> --- M src/engine_page.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d1a309bafe545c4a71e8ef315a9330c964cc732 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Remove outdated patternfly css fix in CPPV
by gshereme＠redhat.com 31 Jul '15

31 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: Remove outdated patternfly css fix in CPPV ...................................................................... webadmin: Remove outdated patternfly css fix in CPPV One of the Patternfly-Webkit css workarounds is now obsolete and broke the ClusterPolicyPopupView dialog by moving input fields out of their einclosing horizontal panel. Change-Id: Icb795d3f9d5f0713373d6092a1700c02dd53f2ea Bug-Url: https://bugzilla.redhat.com/1238266 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 1 insertion(+), 7 deletions(-) Approvals: Dudi Maroshi: Looks good to me, but someone else must approve Roman Mohr: Verified Greg Sheremeta: Looks good to me, approved; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb795d3f9d5f0713373d6092a1700c02dd53f2ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: template main tab -> vm subtab -> vm name may disa...
by tjelinek＠redhat.com 31 Jul '15

31 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: template main tab -> vm subtab -> vm name may disappear ...................................................................... webadmin: template main tab -> vm subtab -> vm name may disappear The problem was that the vm name in this subtab did not have the size set. If the webadmin was opened in a screen where the name did not fit in, it was collapsed completely. Fixed by setting it the same width as the host name has. Change-Id: Icfd85eb615f6c7ecec378015594d85fdf0864ccb Bug-Url: https://bugzilla.redhat.com/1209185 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateVmView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfd85eb615f6c7ecec378015594d85fdf0864ccb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: dropped engine related fc21 jobs
by dcaroest＠redhat.com 31 Jul '15

31 Jul '15

David Caro has submitted this change and it was merged. Change subject: dropped engine related fc21 jobs ...................................................................... dropped engine related fc21 jobs Dropped engine related fc21 jobs to save jenkins resources as announced on oVirt mailing lists. Change-Id: I1e5a07a088d71d214deb24dd5968f91af6d7b327 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/builders/copy-create-job-artifact.yaml M jobs/confs/yaml/jobs/ebay-cors-filter/ebay-cors-filter.yaml M jobs/confs/yaml/jobs/jasper-reports/jasper-reports_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-dwh/ovirt-dwh_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-sdk-java/ovirt-engine-sdk-java_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-wildfly-overlay/ovirt-engine-wildfly-overlay.yaml M jobs/confs/yaml/jobs/ovirt-engine-wildfly/ovirt-engine-wildfly.yaml M jobs/confs/yaml/jobs/ovirt-image-uploader/ovirt-image-uploader_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-reports/ovirt-reports_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt/publish-rpms-nightly-master.yaml M jobs/confs/yaml/jobs/unboundid-ldapsdk/unboundid-ldapsdk_create-rpms.yaml M jobs/confs/yaml/jobs/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml 14 files changed, 16 insertions(+), 32 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for review Jenkins CI: Passed CI tests David Caro: Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/44223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e5a07a088d71d214deb24dd5968f91af6d7b327 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: Added standard ci scripts
by sbonazzo＠redhat.com 31 Jul '15

31 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Added standard ci scripts ...................................................................... Added standard ci scripts This way it can run completely inside mock Change-Id: Ia812dcd02d49453f05315f3727aa006183346153 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M .gitignore A automation/build-artifacts.packages A automation/build-artifacts.repos A automation/build-artifacts.sh A automation/check-patch.packages A automation/check-patch.sh 6 files changed, 34 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia812dcd02d49453f05315f3727aa006183346153 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <kiril.nesenko(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: Corrected an issue with time conversion logic
by sabose＠redhat.com 31 Jul '15

31 Jul '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Corrected an issue with time conversion logic ...................................................................... gluster: Corrected an issue with time conversion logic In the API convertTime() while getting input time value as no of millis, Calendar.HOUR was used which is problematic and there used to be 12 Hrs difference after converting the time to other time zone. Corrected the same to use Calendar.HOUR_OF_DAY. Change-Id: I795d53e2a7a333864087bfe3a0b85fb6eb9375d0 Bug-Url: https://bugzilla.redhat.com/1244714 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shubhendu Tripathi: Verified Sahina Bose: Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I795d53e2a7a333864087bfe3a0b85fb6eb9375d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0