- Engine-commits - oVirt List Archives

Change in jenkins[master]: ovirt-engine_upgrade_3.5_to_master: updated answers
by sbonazzo＠redhat.com 30 Jul '15

30 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine_upgrade_3.5_to_master: updated answers ...................................................................... ovirt-engine_upgrade_3.5_to_master: updated answers updated answers files for 3.5 setup / cleanup Change-Id: I2390c6be0798f5e134347684dff42045cec9b80a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/ovirt-engine_upgrade_3.5_to_master/cleanup.file.otopi M jobs/ovirt-engine_upgrade_3.5_to_master/setup.file.otopi 2 files changed, 51 insertions(+), 36 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/44200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2390c6be0798f5e134347684dff42045cec9b80a Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine : Add null check for cmd entity in CoCo
by oourfali＠redhat.com 30 Jul '15

30 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Add null check for cmd entity in CoCo ...................................................................... engine : Add null check for cmd entity in CoCo CommandExecutor.invokeCallbackMethods should check if command entity exists before setting initial and remaining delay. Change-Id: I583fed12c03bd2ecad6bf584a9e8eaaaa034a8fe Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I583fed12c03bd2ecad6bf584a9e8eaaaa034a8fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: sercon: send correct content-type from client
by sbonazzo＠redhat.com 30 Jul '15

30 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: sercon: send correct content-type from client ...................................................................... sercon: send correct content-type from client Declare the correct content-type for requests from client. Roughly after the move to Wildfly, the ovirt-vmconsole-list.py helper stopped working, because the server-side applet was not able anymore to fetch the request body. That happened because the ovirt-vmconsole-list.py helper was using an incorrect content-type for its requests: it stated that the body is encoded using MIME type 'application/x-www-form-urlencoded', but that was false. When we use the x-www-form-urlencoded content type the server tries to interpret it as form, and thus it consumes all the body input stream looking for "a=b&c=d&...". This may have changed from jboss to wildfly, but the key point was that the incorrect (and default) content-type sent by client may confuse a well-behaving conformant server, leading into troubles. This patch fixes the client using the correct content-type: 'text/plain'. Change-Id: Iecd37a03d18aa720f00011c91d23a27738afacd2 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/44170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecd37a03d18aa720f00011c91d23a27738afacd2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Revert "webadmin: fix assert error in GroupedListModelListBox"
by gshereme＠redhat.com 30 Jul '15

30 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: Revert "webadmin: fix assert error in GroupedListModelListBox" ...................................................................... Revert "webadmin: fix assert error in GroupedListModelListBox" This reverts commit 531dac99cd8c725ae5a7ef45fb2a885e628a704a. Change-Id: I5885dd1c756f09f58addda3670e034cb1b4e4ee5 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GroupedListModelListBox.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified Oved Ourfali: Verified -- To view, visit https://gerrit.ovirt.org/44190 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5885dd1c756f09f58addda3670e034cb1b4e4ee5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: dbutils: Restore taskcleaner_sp_3_5.sql
by sbonazzo＠redhat.com 30 Jul '15

30 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: dbutils: Restore taskcleaner_sp_3_5.sql ...................................................................... packaging: dbutils: Restore taskcleaner_sp_3_5.sql Was wrongly removed in commit a1adf1576697d14752ae2e0f73d32e70bb8d93a4 Change-Id: Ieb794b8f8c563d1f87c3dbf9374d081ae6ff95b9 Bug-Url: https://bugzilla.redhat.com/1243125 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh A packaging/setup/dbutils/taskcleaner_sp_3_5.sql 2 files changed, 71 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb794b8f8c563d1f87c3dbf9374d081ae6ff95b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Add initial files for 3.5 to master upgrade
by sbonazzo＠redhat.com 30 Jul '15

30 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add initial files for 3.5 to master upgrade ...................................................................... Add initial files for 3.5 to master upgrade Required for http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-3.5_merged Change-Id: I76d33fdbb1e61f264229557a9a812ae00d2d1db9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/ovirt-engine_upgrade_3.5_to_master/build_engine_rpm.sh A jobs/ovirt-engine_upgrade_3.5_to_master/cleanup.file.otopi A jobs/ovirt-engine_upgrade_3.5_to_master/cleanup.sh A jobs/ovirt-engine_upgrade_3.5_to_master/setup.file.otopi A jobs/ovirt-engine_upgrade_3.5_to_master/upgrade.sh 5 files changed, 749 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/44160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76d33fdbb1e61f264229557a9a812ae00d2d1db9 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: Makefile: sort generated
by sbonazzo＠redhat.com 30 Jul '15

30 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: Makefile: sort generated ...................................................................... build: Makefile: sort generated Change-Id: If0daddf0552256da7e63beceb004763b059ea341 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0daddf0552256da7e63beceb004763b059ea341 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: wgt: publish wgt dependencies rpms
by sbonazzo＠redhat.com 30 Jul '15

30 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: wgt: publish wgt dependencies rpms ...................................................................... wgt: publish wgt dependencies rpms Change-Id: I9cb8ccf65ee1f1aa00ca727da2a3ef2420bde985 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/jobs/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cb8ccf65ee1f1aa00ca727da2a3ef2420bde985 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: run VDS commands with factory
by ofrenkel＠redhat.com 30 Jul '15

30 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: run VDS commands with factory ...................................................................... core: run VDS commands with factory Commands should not be directly created and called. Change-Id: I95b5825907aa15880a147d9957533af51907e080 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1245088 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HibernateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResumeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java 7 files changed, 60 insertions(+), 70 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95b5825907aa15880a147d9957533af51907e080 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: set empty mgmt network when cluster is detached
by alkaplan＠redhat.com 30 Jul '15

30 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: set empty mgmt network when cluster is detached ...................................................................... webadmin: set empty mgmt network when cluster is detached Set empty mgmt network when cluster is detached. Change-Id: Ife77c59fd4b91046882dd4451b8b149cf17bf7a1 Bug-Url: https://bugzilla.redhat.com/1206891 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/44039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife77c59fd4b91046882dd4451b8b149cf17bf7a1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0