- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: weadmin, userportal: added comments to uicommon popup and ev...
by gshereme＠redhat.com 29 Jul '15

29 Jul '15

Greg Sheremeta has submitted this change and it was merged. Change subject: weadmin, userportal: added comments to uicommon popup and event infra ...................................................................... weadmin, userportal: added comments to uicommon popup and event infra Change-Id: I2d496a53e6089e499cdbda4a0aec74f7f3a15316 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DetailTabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/SearchableDetailModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/AbstractTabPanel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Event.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractSubTabTableView.java 8 files changed, 129 insertions(+), 70 deletions(-) Approvals: Greg Sheremeta: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d496a53e6089e499cdbda4a0aec74f7f3a15316 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: host-deploy: introduce deploy unit
by masayag＠redhat.com 29 Jul '15

29 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: host-deploy: introduce deploy unit ...................................................................... host-deploy: introduce deploy unit deploy unit will enable more flexible selection of what is enabled during session. it will also enable to share code between deploy and management processes. this is major rework of host-deploy usage, should not change anything actually sent to host. side effect is much shorter sources. Change-Id: Ida75efb7d42b1317b541d8720911f2578cc8b900 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeploy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployIptablesUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployKdumpUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployMiscUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployOpenStackUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployPKIUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployPackagesUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployVdsmUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployVmconsoleUnit.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsMgmtPackages.java 14 files changed, 1,366 insertions(+), 1,099 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida75efb7d42b1317b541d8720911f2578cc8b900 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: introduce ImportVmFromVmwareModel
by ahadas＠redhat.com 29 Jul '15

29 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: introduce ImportVmFromVmwareModel ...................................................................... webadmin: introduce ImportVmFromVmwareModel Import VM from OVA file has a lot in common with import from VMware. Therefore, ImportVmFromExternalProviderModel is changed to hold the common things and VMware-specific things are moved to ImportVmFromVmwareModel. Change-Id: I7f0ed04073a6ee1e2b79852568c6d283a0dde3b4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromVmwareModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 3 files changed, 139 insertions(+), 110 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f0ed04073a6ee1e2b79852568c6d283a0dde3b4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-host-deploy[master]: common: initialize the incomplete variables
by Alon Bar-Lev 29 Jul '15

29 Jul '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: common: initialize the incomplete variables ...................................................................... common: initialize the incomplete variables engine can use common method for both deploy and mgmt and acquire partial setup messages always. Change-Id: I3919a3435e49a8b072992182edf07c4d67c2b846 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M configure.ac M po/POTFILES.in M src/plugins/ovirt-host-common/Makefile.am A src/plugins/ovirt-host-common/core/Makefile.am A src/plugins/ovirt-host-common/core/__init__.py A src/plugins/ovirt-host-common/core/misc.py M src/plugins/ovirt-host-deploy/core/misc.py 7 files changed, 134 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3919a3435e49a8b072992182edf07c4d67c2b846 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Added null check to AREM
by rgolan＠redhat.com 29 Jul '15

29 Jul '15

Roy Golan has submitted this change and it was merged. Change subject: core: Added null check to AREM ...................................................................... core: Added null check to AREM Added a null check for affinity group entity ids on AREM methods in the AffinityRulesUtils class, Because it failed the REST api tests. Change-Id: I7c057290a8cb8a9a688a4c964b8120bf6436dcc8 Bug-Url: https://bugzilla.redhat.com/1245066 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/AddAffinityGroupCommandTest.java 2 files changed, 22 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c057290a8cb8a9a688a4c964b8120bf6436dcc8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: 'Next start configuration' dialog label changed
by tjelinek＠redhat.com 29 Jul '15

29 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: 'Next start configuration' dialog label changed ...................................................................... webadmin: 'Next start configuration' dialog label changed 'Next Restart Configuration' -> 'Next Start Configuration'. Dialog label changed to avoid confusion that restart action might apply changes. Change-Id: Id31702a1526d4202b74cf25e2dbeb0b2609628a6 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id31702a1526d4202b74cf25e2dbeb0b2609628a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: AddBricksToGlusterVolumeCommand redundancy
by amureini＠redhat.com 29 Jul '15

29 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddBricksToGlusterVolumeCommand redundancy ...................................................................... core: AddBricksToGlusterVolumeCommand redundancy AddBricksToGlusterVolumeCommand.canDoAction() checks that getParameters().getBricks() is not null or empty. Therefore, it's redundant to re-check it in the executeCommand() method. This patch fixes Coverity defect CID 1311883. Change-Id: Idff9d7d7c1ac04c23de64debac6ae652b2780dc7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java 1 file changed, 11 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idff9d7d7c1ac04c23de64debac6ae652b2780dc7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: move containsUnregisteredEntities to StorageDomainDynamic
by tnisan＠redhat.com 29 Jul '15

29 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: core: move containsUnregisteredEntities to StorageDomainDynamic ...................................................................... core: move containsUnregisteredEntities to StorageDomainDynamic The field containsUnregisteredEntities is not determined by the user, but is calculated according to its actions. Thus, it should be in StorageDomainDynamic and not in StorageDomainStatic. Change-Id: Ic725b03b35de0388519e19768db426df868b0022 Bug-Url: https://bugzilla.redhat.com/1247144 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java 3 files changed, 14 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/44140 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic725b03b35de0388519e19768db426df868b0022 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.3]: packaging: post ovirt-host-deploy-1.3.2
by Alon Bar-Lev 29 Jul '15

29 Jul '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: post ovirt-host-deploy-1.3.2 ...................................................................... packaging: post ovirt-host-deploy-1.3.2 Change-Id: Id038f02adc7c1f3b60f64890c3dffeec73dd8b29 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id038f02adc7c1f3b60f64890c3dffeec73dd8b29 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.3]: packaging: ovirt-host-deploy-1.3.2
by Alon Bar-Lev 29 Jul '15

29 Jul '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: ovirt-host-deploy-1.3.2 ...................................................................... packaging: ovirt-host-deploy-1.3.2 Change-Id: Icf893889fc7338cfd0000d2bfe70a69d334d3e88 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac M ovirt-host-deploy-offline.spec.in M ovirt-host-deploy.spec.in 4 files changed, 9 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf893889fc7338cfd0000d2bfe70a69d334d3e88 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0