- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: setup: add also appliance hostname in its /etc/hosts
by sbonazzo＠redhat.com 28 Jul '15

28 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: add also appliance hostname in its /etc/hosts ...................................................................... packaging: setup: add also appliance hostname in its /etc/hosts Now engine-setup on the appliance ensures that the appliance is able to resolve itself hostname. Allowing it via /etc/hosts for static configurations. Change-Id: Idf3899de1a0e96f6169349fe29fff6a917a53cce Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf3899de1a0e96f6169349fe29fff6a917a53cce Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: avoid check of fqdn
by dougsland＠redhat.com 28 Jul '15

28 Jul '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: avoid check of fqdn ...................................................................... engine_page: avoid check of fqdn To keep the previous behaviour during TUI registration, do not check FQDN of certificate. Change-Id: I8301722fa39cc0d5fcc25e69bee04c1d2888b46a Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/44064 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> --- M src/engine_page.py 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8301722fa39cc0d5fcc25e69bee04c1d2888b46a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: graphicsProtocol in changed fields list
by ofrenkel＠redhat.com 28 Jul '15

28 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: graphicsProtocol in changed fields list ...................................................................... core: graphicsProtocol in changed fields list After editing parameters of a running VM, list of changed fields that will be updated on the next run is displayed to user. Graphics devices are presented in this list as separate devices (SPICE and VNC) while corresponding to the single field in the UI ("Graphics protocol"). To correct this, 'name' parameter was introduced into @EditableDeviceOnVmStatusField annotation. If it is present, its value will be displayed to the user in the changed fields list, instead of device type name. If two devices have the same name, it will be included into the list only once. This allows, in our case, to present SPICE and VNC devices as single 'graphicsProtocol' field. Change-Id: I95facdae456ca904f1e0d1ece32a96658992b2eb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238742 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableDeviceOnVmStatusField.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceUpdate.java 5 files changed, 42 insertions(+), 25 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95facdae456ca904f1e0d1ece32a96658992b2eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: comments fix of 'using hostNetworkingAPI from gui'...
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: comments fix of 'using hostNetworkingAPI from gui' patch ...................................................................... webadmin: comments fix of 'using hostNetworkingAPI from gui' patch Change-Id: I894a860488ed8fb0526b03e9b7407a2bb9cd64e8 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/VfsConfigAction.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 3 files changed, 25 insertions(+), 52 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I894a860488ed8fb0526b03e9b7407a2bb9cd64e8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fixing bug- edited bond should be sent to the setu...
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fixing bug- edited bond should be sent to the setup networks ...................................................................... webadmin: fixing bug- edited bond should be sent to the setup networks Change-Id: I82149d44fe9af20591ae236dcd75996d8c95abd5 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82149d44fe9af20591ae236dcd75996d8c95abd5 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix wrong construction of attachment
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fix wrong construction of attachment ...................................................................... webadmin: fix wrong construction of attachment Change-Id: I3ec9e97403f0cb13f9e70cf034cb220658d73e41 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java 3 files changed, 45 insertions(+), 23 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ec9e97403f0cb13f9e70cf034cb220658d73e41 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: always sent 'OverrideConfiguration' as true
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: always sent 'OverrideConfiguration' as true ...................................................................... webadmin: always sent 'OverrideConfiguration' as true Change-Id: I13969b02a4637c8f10692c566ef5c83d7e3350a4 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java 4 files changed, 56 insertions(+), 18 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13969b02a4637c8f10692c566ef5c83d7e3350a4 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: remove LabelUlabelAction from HostSetupNetworksModel
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: remove LabelUlabelAction from HostSetupNetworksModel ...................................................................... webadmin: remove LabelUlabelAction from HostSetupNetworksModel labels and removed labels should be passed via the HostSetupNetworks parameters. Change-Id: I5872cac522d931486ee9c19a36658f601ed6abcc Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/action/LabelUnlabelUiAction.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 4 files changed, 54 insertions(+), 229 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5872cac522d931486ee9c19a36658f601ed6abcc Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: use NicLabel instead of DataFromHostSetupNetworksM...
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: use NicLabel instead of DataFromHostSetupNetworksModel.LabelOnNic ...................................................................... webadmin: use NicLabel instead of DataFromHostSetupNetworksModel.LabelOnNic Change-Id: Iba589e8c71c0dd7a9437b06631449116630d5dc6 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/action/LabelUnlabelUiAction.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 5 files changed, 24 insertions(+), 68 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43663 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba589e8c71c0dd7a9437b06631449116630d5dc6 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: using hostNetworkingAPI from gui.
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: using hostNetworkingAPI from gui. ...................................................................... webadmin: using hostNetworkingAPI from gui. Change-Id: Ib9d99c4963a0b0013797d1e6ed1612edaf19f0b0 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/action/LabelUnlabelUiAction.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/VfsConfigAction.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/BondNetworkInterfaceModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationCommandTarget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java 10 files changed, 1,317 insertions(+), 115 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/38234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9d99c4963a0b0013797d1e6ed1612edaf19f0b0 Gerrit-PatchSet: 85 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0