- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: intorducing NicLabel entity
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: intorducing NicLabel entity ...................................................................... engine: intorducing NicLabel entity Change-Id: I7b456cc123fb35bf582bf23f7ff24b0370b8fefe Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NicLabel.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NicLabelNicIdOrNicNameIsSetConstraint.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/NicLabelNicIdOrNicNameIsSet.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 138 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b456cc123fb35bf582bf23f7ff24b0370b8fefe Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: remove nicName valdation from NetworkAttachment
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: remove nicName valdation from NetworkAttachment ...................................................................... engine: remove nicName valdation from NetworkAttachment Via NetworkAttachment entity NIC cannot be created; it's only referenced. Therefote, the 'NetworkAttachment.nicName' doesn't contain the new desired name of a nic. So there is no need to validate its length. The relevant command should validate there is (or soon will be created) an interface with this name. Change-Id: Iba66a8c66a5570c1c6a81c00d83642e4b82cbf07 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba66a8c66a5570c1c6a81c00d83642e4b82cbf07 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: fix comment in HostSetupNetworksParameters
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: fix comment in HostSetupNetworksParameters ...................................................................... engine: fix comment in HostSetupNetworksParameters The HostSetupNetworksParameters.networkAttachments list reperesents new and updated attachments, not removed attachments. Change-Id: I32ee654e5c061a70d53f7c44b3fa55e3aa414278 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43659 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32ee654e5c061a70d53f7c44b3fa55e3aa414278 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: add missed replacement to host status validation error
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: add missed replacement to host status validation error ...................................................................... engine: add missed replacement to host status validation error Change-Id: I80dc0cc49436e8490b4f3b131c273f1feef817ab Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80dc0cc49436e8490b4f3b131c273f1feef817ab Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: nullifying network_name before updating vds_interface
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: nullifying network_name before updating vds_interface ...................................................................... engine: nullifying network_name before updating vds_interface vds_interface table has vds_id_network_name unique constrsaint. The constaint is violated if a network is moved from one nic to another. To avoid the violation we first have to nullify the network_names of the updated nics and then do the update. Change-Id: Ie14d9c933687401d177ec50f211a65867d7a3f8f Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkInterfacesPersisterImpl.java M packaging/dbscripts/network_sp.sql 5 files changed, 70 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie14d9c933687401d177ec50f211a65867d7a3f8f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: move containsUnregisteredEntities to StorageDomainDynamic
by amureini＠redhat.com 28 Jul '15

28 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: move containsUnregisteredEntities to StorageDomainDynamic ...................................................................... core: move containsUnregisteredEntities to StorageDomainDynamic The field containsUnregisteredEntities is not determined by the user, but is calculated according to its actions. Thus, it should be in StorageDomainDynamic and not in StorageDomainStatic. Change-Id: Ic725b03b35de0388519e19768db426df868b0022 Bug-Url: https://bugzilla.redhat.com/1247144 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java 3 files changed, 14 insertions(+), 15 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, approved; Passed CI tests Maor Lipchuk: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/44024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic725b03b35de0388519e19768db426df868b0022 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix CreateAllSnapshotsFromVmCommand space validation
by amureini＠redhat.com 28 Jul '15

28 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix CreateAllSnapshotsFromVmCommand space validation ...................................................................... core: Fix CreateAllSnapshotsFromVmCommand space validation Previously un-plugged and non-shareable disks were not checked for space, as they should have been. Change-Id: I9f42f387781425d16f53a0e8a34d859365808ec0 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java 2 files changed, 15 insertions(+), 28 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f42f387781425d16f53a0e8a34d859365808ec0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix RunVmStateless storage space validation
by amureini＠redhat.com 28 Jul '15

28 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix RunVmStateless storage space validation ...................................................................... core: Fix RunVmStateless storage space validation Previously only plugged disks were checked for space, now also unplugged disks are checked. Change-Id: I1b612552c592a7a1e37c45edf8054ea1f7c3d25c Bug-Url: https://bugzilla.redhat.com/1181133 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve; Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/43926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b612552c592a7a1e37c45edf8054ea1f7c3d25c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix move disk space allocation validation
by amureini＠redhat.com 28 Jul '15

28 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix move disk space allocation validation ...................................................................... core: fix move disk space allocation validation The validation that was used was good for copy-collapse, only in moving a disk we don't collapse and need the validation for a disk with snapshot (no collapsing). Change-Id: Ia72b2e0f116ee0ebe43ad4255261bb6b15efd9d9 Bug-Url: https://bugzilla.redhat.com/1168708 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/43994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia72b2e0f116ee0ebe43ad4255261bb6b15efd9d9 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: fix reading of bond options
by alkaplan＠redhat.com 28 Jul '15

28 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: fix reading of bond options ...................................................................... engine: fix reading of bond options Change-Id: I1e172dd7470785e712db1ceed50462eee92a2fb2 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e172dd7470785e712db1ceed50462eee92a2fb2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0