- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Missing breaks in VdsBrokerObjectsBuilder
by amureini＠redhat.com 19 Jul '15

19 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Missing breaks in VdsBrokerObjectsBuilder ...................................................................... core: Missing breaks in VdsBrokerObjectsBuilder This patch adds the missing break statements in VdsBrokerObjectsBuilder.buildDiskImagesFromDevices(Map<String, Object>). It fixed Coverity defect 1311881. Change-Id: Ib4d77b2253f4442523bd9ab7678fce3024e9d7d4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43801 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4d77b2253f4442523bd9ab7678fce3024e9d7d4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Documentation fix to S_S_C_Resource
by amureini＠redhat.com 19 Jul '15

19 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Documentation fix to S_S_C_Resource ...................................................................... restapi: Documentation fix to S_S_C_Resource Documentation for getStorageConnectionSubResource in StorageServerConnectionsResource, stated that @param id is the StorageDomain's id- when actually it is the server connection id. Change-Id: I78a76b3f5886b3cd984092fc94e774b8115c60e6 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionsResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/43804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78a76b3f5886b3cd984092fc94e774b8115c60e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Modifiers for TestStorageHandlingCommandBase
by amureini＠redhat.com 19 Jul '15

19 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Modifiers for TestStorageHandlingCommandBase ...................................................................... core: Modifiers for TestStorageHandlingCommandBase Fixed modifiers for TestStorageHandlingCommandBase, as per Coverity defect CID 1311876. Change-Id: I8948caee30417b3d28f344734e35d737e66475fc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8948caee30417b3d28f344734e35d737e66475fc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Prevent NPE in VmsMonitoring
by rgolan＠redhat.com 19 Jul '15

19 Jul '15

Roy Golan has submitted this change and it was merged. Change subject: core: Prevent NPE in VmsMonitoring ...................................................................... core: Prevent NPE in VmsMonitoring Prevent an NPE in case the VM's data cannot be parsed. Note: This patch fixes a coverity defect #1311880. Change-Id: Ic507ef0f22fecdde1ffd5a77d3b546ac1fb68cf0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic507ef0f22fecdde1ffd5a77d3b546ac1fb68cf0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding WipeVolumeVDSCommand
by laravot＠redhat.com 19 Jul '15

19 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: core: adding WipeVolumeVDSCommand ...................................................................... core: adding WipeVolumeVDSCommand Change-Id: I2b2cf2f4d70028c44aabc123c39f27ceda58ace2 Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/WipeVolumeVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/WipeVolumeVDSCommand.java 7 files changed, 79 insertions(+), 0 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b2cf2f4d70028c44aabc123c39f27ceda58ace2 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding IsolateVolumeVDSCommand
by laravot＠redhat.com 19 Jul '15

19 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: core: adding IsolateVolumeVDSCommand ...................................................................... core: adding IsolateVolumeVDSCommand This vdsm verb is used to move a volume/image from image group to another image group. Change-Id: If586b22cc506fbb6a74aa9a53e97e2597ba40305 Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/IsolateVolumeVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IsolateVolumeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 7 files changed, 89 insertions(+), 1 deletion(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If586b22cc506fbb6a74aa9a53e97e2597ba40305 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding AllocateVolumeVDSCommand
by laravot＠redhat.com 19 Jul '15

19 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: core: adding AllocateVolumeVDSCommand ...................................................................... core: adding AllocateVolumeVDSCommand Change-Id: Id1251931cb9af02024d42739802fec01744ce387 Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/AllocateVolumeVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AllocateVolumeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 7 files changed, 103 insertions(+), 0 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1251931cb9af02024d42739802fec01744ce387 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding CopyVolumeDataVDSCommand
by laravot＠redhat.com 19 Jul '15

19 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: core: adding CopyVolumeDataVDSCommand ...................................................................... core: adding CopyVolumeDataVDSCommand Change-Id: Iea7e7202c3c79a4d4aaebe0a1427d5b1c0941ab0 Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CopyVolumeDataVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CopyVolumeDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 7 files changed, 106 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41705 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea7e7202c3c79a4d4aaebe0a1427d5b1c0941ab0 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Adding VdsmImageLocationInfo
by laravot＠redhat.com 19 Jul '15

19 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: core: Adding VdsmImageLocationInfo ...................................................................... core: Adding VdsmImageLocationInfo Change-Id: Ibb4a396b8725b69002867eb8d4573e5d39b4efbc Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalLocationInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HttpLocationInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LocationInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsmImageLocationInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LocationInfoHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DownloadImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UploadImageVDSCommandParameters.java 7 files changed, 110 insertions(+), 36 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb4a396b8725b69002867eb8d4573e5d39b4efbc Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding CreateVolumeContainerVDSCommand
by laravot＠redhat.com 19 Jul '15

19 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: core: adding CreateVolumeContainerVDSCommand ...................................................................... core: adding CreateVolumeContainerVDSCommand Change-Id: I5a26ff3681e781acd627557b557d1eeeeec3083f Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVolumeVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVolumeContainerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 7 files changed, 182 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a26ff3681e781acd627557b557d1eeeeec3083f Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0