- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Wrap cert validity check with try-catch
by oourfali＠redhat.com 23 Jul '15

23 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Wrap cert validity check with try-catch ...................................................................... engine: Wrap cert validity check with try-catch In certain cases the startup of the service fails. This patch capture the exception and prints it to allow a simple debug. Change-Id: Ibe1dfafe7775286fbe30c4b6893ac2c2215527c6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java 1 file changed, 35 insertions(+), 26 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe1dfafe7775286fbe30c4b6893ac2c2215527c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: use proper width values in form panel
by awels＠redhat.com 22 Jul '15

22 Jul '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: use proper width values in form panel ...................................................................... userportal,webadmin: use proper width values in form panel - The widths of the form items on the panel were defined but then promptly reset to half the available width on updates. This patch fixes the updates so they take the original value into account. Change-Id: I355404e186defb1a2901b2ad9e520515818d102a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230723 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.java 2 files changed, 53 insertions(+), 18 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I355404e186defb1a2901b2ad9e520515818d102a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in samples-uiplugins[master]: Introducing ProgressBar plugin (initial demo version)
by vszocs＠redhat.com 22 Jul '15

22 Jul '15

Vojtech Szocs has submitted this change and it was merged. Change subject: Introducing ProgressBar plugin (initial demo version) ...................................................................... Introducing ProgressBar plugin (initial demo version) This plugin tracks user's progress of using the oVirt system through achievements organized in different categories. The goal of this plugin is to encourage users to explore all features available in oVirt. This plugin uses following development stack: * AngularJS, Model-View-Controller framework for JavaScript http://angularjs.org/ * Bootstrap, visual component framework for CSS http://getbootstrap.com/ * UI Bootstrap, Bootstrap's visual components ported to AngularJS http://angular-ui.github.io/bootstrap/ * Jasmine, Behavior-Driven Development style testing framework for JavaScript http://pivotal.github.io/jasmine/ * Karma, test runner for JavaScript http://karma-runner.github.io/ Check out README file for details on installation and setting up local development environment. Change-Id: I77b44668eb9fa5ce4c7753feffd86fe6b94f1d49 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- A progressbar-plugin-demo/.gitignore A progressbar-plugin-demo/README A progressbar-plugin-demo/karma.conf.js A progressbar-plugin-demo/progressbar.json A progressbar-plugin-demo/src/css/progress-tab.css A progressbar-plugin-demo/src/js/init-service.js A progressbar-plugin-demo/src/js/init.js A progressbar-plugin-demo/src/js/tab-controller.js A progressbar-plugin-demo/src/js/tab.js A progressbar-plugin-demo/src/lib/angular/js/angular-animate.js A progressbar-plugin-demo/src/lib/angular/js/angular-animate.min.js A progressbar-plugin-demo/src/lib/angular/js/angular-animate.min.js.map A progressbar-plugin-demo/src/lib/angular/js/angular-cookies.js A progressbar-plugin-demo/src/lib/angular/js/angular-cookies.min.js A progressbar-plugin-demo/src/lib/angular/js/angular-cookies.min.js.map A progressbar-plugin-demo/src/lib/angular/js/angular-loader.js A progressbar-plugin-demo/src/lib/angular/js/angular-loader.min.js A progressbar-plugin-demo/src/lib/angular/js/angular-loader.min.js.map A progressbar-plugin-demo/src/lib/angular/js/angular-resource.js A progressbar-plugin-demo/src/lib/angular/js/angular-resource.min.js A progressbar-plugin-demo/src/lib/angular/js/angular-resource.min.js.map A progressbar-plugin-demo/src/lib/angular/js/angular-route.js A progressbar-plugin-demo/src/lib/angular/js/angular-route.min.js A progressbar-plugin-demo/src/lib/angular/js/angular-route.min.js.map A progressbar-plugin-demo/src/lib/angular/js/angular-sanitize.js A progressbar-plugin-demo/src/lib/angular/js/angular-sanitize.min.js A progressbar-plugin-demo/src/lib/angular/js/angular-sanitize.min.js.map A progressbar-plugin-demo/src/lib/angular/js/angular-touch.js A progressbar-plugin-demo/src/lib/angular/js/angular-touch.min.js A progressbar-plugin-demo/src/lib/angular/js/angular-touch.min.js.map A progressbar-plugin-demo/src/lib/angular/js/angular.js A progressbar-plugin-demo/src/lib/angular/js/angular.min.js A progressbar-plugin-demo/src/lib/angular/js/angular.min.js.map A progressbar-plugin-demo/src/lib/angular/version.txt A progressbar-plugin-demo/src/lib/bootstrap/css/bootstrap-theme.css A progressbar-plugin-demo/src/lib/bootstrap/css/bootstrap-theme.min.css A progressbar-plugin-demo/src/lib/bootstrap/css/bootstrap.css A progressbar-plugin-demo/src/lib/bootstrap/css/bootstrap.min.css A progressbar-plugin-demo/src/lib/bootstrap/fonts/glyphicons-halflings-regular.eot A progressbar-plugin-demo/src/lib/bootstrap/fonts/glyphicons-halflings-regular.svg A progressbar-plugin-demo/src/lib/bootstrap/fonts/glyphicons-halflings-regular.ttf A progressbar-plugin-demo/src/lib/bootstrap/fonts/glyphicons-halflings-regular.woff A progressbar-plugin-demo/src/lib/bootstrap/version.txt A progressbar-plugin-demo/src/lib/ui-bootstrap/js/ui-bootstrap-tpls.js A progressbar-plugin-demo/src/lib/ui-bootstrap/js/ui-bootstrap-tpls.min.js A progressbar-plugin-demo/src/lib/ui-bootstrap/js/ui-bootstrap.js A progressbar-plugin-demo/src/lib/ui-bootstrap/js/ui-bootstrap.min.js A progressbar-plugin-demo/src/lib/ui-bootstrap/version.txt A progressbar-plugin-demo/src/plugin.html A progressbar-plugin-demo/src/progress-tab.html A progressbar-plugin-demo/test/js/init-service-specs.js A progressbar-plugin-demo/test/js/test-util.js A progressbar-plugin-demo/test/lib/angular/js/angular-mocks.js A progressbar-plugin-demo/test/lib/angular/version.txt 54 files changed, 42,897 insertions(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/23013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77b44668eb9fa5ce4c7753feffd86fe6b94f1d49 Gerrit-PatchSet: 2 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: select virtio drivers iso on import vm
by ahadas＠redhat.com 22 Jul '15

22 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: select virtio drivers iso on import vm ...................................................................... webadmin: select virtio drivers iso on import vm The user can now select which virtio drivers to use when he imports a VM from an external provider (using virt-v2v). This selection is optional. Change-Id: I7fd184bb4847dd07e1ac6b831c6857eeb8a16fc7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.ui.xml 4 files changed, 108 insertions(+), 29 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fd184bb4847dd07e1ac6b831c6857eeb8a16fc7 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix stored procedure with SQL language.
by rgolan＠redhat.com 22 Jul '15

22 Jul '15

Roy Golan has submitted this change and it was merged. Change subject: core: Fix stored procedure with SQL language. ...................................................................... core: Fix stored procedure with SQL language. Stored procedure with SQL language. Need special arguments references. As specified here: http://www.postgresql.org/docs/current/static/xfunc-sql.html section 35.4.1 This bug need further consideration to be caught by testing framework. Solution: change stored procedure to use plpgsql language. Change-Id: If59c2349d16dde4f6a64e654230db66fe3bd53f2 Bug-Url: https://bugzilla.redhat.com/1244154 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M packaging/dbscripts/vms_sp.sql 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Dudi Maroshi: Verified Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/43884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If59c2349d16dde4f6a64e654230db66fe3bd53f2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: deploying new YAML conf: ignore empty xml diff file
by eedri＠redhat.com 22 Jul '15

22 Jul '15

Eyal Edri has submitted this change and it was merged. Change subject: deploying new YAML conf: ignore empty xml diff file ...................................................................... deploying new YAML conf: ignore empty xml diff file Change-Id: I1625e4596c83cd8b1b25dd1e5b3bee18aa20c56f Signed-off-by: Paz Dangur <pdangur(a)redhat.com> --- M jobs/confs/groovy-scripts/archive_jobs.groovy 1 file changed, 13 insertions(+), 11 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests Paz Dangur: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/43806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1625e4596c83cd8b1b25dd1e5b3bee18aa20c56f Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Vertical alignment of Run Once dialog > Linux boot...
by vszocs＠redhat.com 22 Jul '15

22 Jul '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Vertical alignment of Run Once dialog > Linux boot options ...................................................................... webadmin: Vertical alignment of Run Once dialog > Linux boot options Fix of vertical alignmet in 'Run Once' dialog, section 'Linux boot options' Change-Id: I811402cd8ffd5acde51ba9c9ecc1617c678e57e4 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1200952 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml 1 file changed, 19 insertions(+), 8 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43840 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811402cd8ffd5acde51ba9c9ecc1617c678e57e4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Set volume classification as snapshot for image snapshot.
by mlipchuk＠redhat.com 22 Jul '15

22 Jul '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Set volume classification as snapshot for image snapshot. ...................................................................... core: Set volume classification as snapshot for image snapshot. Volume classification is a DB column which specifies whether a volume is an active volume or a snapshot. Once a snapshot is added, we should update the volume classification of the snapshot to snapshot instead of volume. Change-Id: Ieed6f7183bb2540dcbcf8d2ddd36a4bf4dfe6a61 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/43813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieed6f7183bb2540dcbcf8d2ddd36a4bf4dfe6a61 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Avoid NPE when trying to commit Cinder snapshot
by mlipchuk＠redhat.com 22 Jul '15

22 Jul '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Avoid NPE when trying to commit Cinder snapshot ...................................................................... core: Avoid NPE when trying to commit Cinder snapshot Avoid NPE once we commit a Cinder snapshot which doesn't has any descendants Change-Id: Ifb0a12462750860e217b01c0e333d804d07e875e Bug-Url: https://bugzilla.redhat.com/1245505 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreFromCinderSnapshotCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/43812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb0a12462750860e217b01c0e333d804d07e875e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove visibility modifier from HostResource
by masayag＠redhat.com 22 Jul '15

22 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Remove visibility modifier from HostResource ...................................................................... restapi: Remove visibility modifier from HostResource Change-Id: Iba4c2c132798451f45aeee148d374215a98c5c1b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostResource.java 1 file changed, 22 insertions(+), 22 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/43883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba4c2c132798451f45aeee148d374215a98c5c1b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0