- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: api: cleanup
by masayag＠redhat.com 15 Jul '15

15 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: api: cleanup ...................................................................... api: cleanup I do not know process of deprication of api but we have not used following methods in 3.5 so it should be ok to remove them for 3.6. Change-Id: Ifa1acf386d1860cd31440c97890f87941086f717 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/StartSpiceVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageConnectionsListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/StartSpiceVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 12 files changed, 0 insertions(+), 252 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa1acf386d1860cd31440c97890f87941086f717 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: Improve View/Table JavaDoc
by vszocs＠redhat.com 15 Jul '15

15 Jul '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Improve View/Table JavaDoc ...................................................................... webadmin,userportal: Improve View/Table JavaDoc This patch addresses source code documentation concerns raised by Greg: https://gerrit.ovirt.org/#/c/42824/3 Change-Id: I9a5437c8b282389e5b898485d908d6bd071a32f8 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java 2 files changed, 90 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a5437c8b282389e5b898485d908d6bd071a32f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: clear format of allowable characters in error msg
by masayag＠redhat.com 15 Jul '15

15 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: clear format of allowable characters in error msg ...................................................................... clear format of allowable characters in error msg Clear format of allowable characters in error messages "a-z0-9A-Z" or "-_" => 'a-z', 'A-Z', '0-9', '_' or '-' Change-Id: If7c387a6e256135d820c09cede74ee593be88b8d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1235118 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 32 insertions(+), 32 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7c387a6e256135d820c09cede74ee593be88b8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix AbstractActionTable.setWidth
by vszocs＠redhat.com 15 Jul '15

15 Jul '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix AbstractActionTable.setWidth ...................................................................... webadmin,userportal: Fix AbstractActionTable.setWidth Fixed a bug where "width" parameter wasn't used at all. Change-Id: I575d131273d2b3af385ffe2f2b818cc929baf29e Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/43402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I575d131273d2b3af385ffe2f2b818cc929baf29e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: ovirt-setup-lib: check patches on el6 too
by sbonazzo＠redhat.com 15 Jul '15

15 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-setup-lib: check patches on el6 too ...................................................................... ovirt-setup-lib: check patches on el6 too Change-Id: I0d598424f44ff83688659e4cc4d789a1b927833a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/jobs/ovirt-setup-lib/ovirt-setup-lib_build-artifacts.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d598424f44ff83688659e4cc4d789a1b927833a Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Add server pool VM image
by tjelinek＠redhat.com 15 Jul '15

15 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Add server pool VM image ...................................................................... frontend: Add server pool VM image Visually differentiate between pool VM of type 'Desktop' and 'Server'. Change-Id: I4c0cd62eba45d3a5fd0a79c5bc54cd9e69ce3ba1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1046407 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmTypeColumn.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/many_servers.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/many_servers_changes.png 4 files changed, 17 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/43599 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c0cd62eba45d3a5fd0a79c5bc54cd9e69ce3ba1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: rename test method
by amureini＠redhat.com 15 Jul '15

15 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: rename test method ...................................................................... core: rename test method Renamed the method testAddingMixedTypes to assertAddingMixedTypes. Some runners have issues with test methods starting with the word test that aren't public and no-arg, even though this is clearly a JUnit 4 test and not a JUnit 3 test. Change-Id: I1bf6e3b0a3f2e78ef370de2296d6982f717eeff5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43604 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bf6e3b0a3f2e78ef370de2296d6982f717eeff5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add tests for isStorageDomainNotInAnyPool()
by amureini＠redhat.com 15 Jul '15

15 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Add tests for isStorageDomainNotInAnyPool() ...................................................................... core: Add tests for isStorageDomainNotInAnyPool() StorageDomainToPoolRelationValidartor#isStorageDomainNotInAnyPool() used to be tested indirectly (read: wrongly) in RemoveStorageDomainCommandTest. This wrong behavior was removed in a87cfdf6cedeaadb8fd3b69dd7567f581348414f, which, in spite of being correct in its own right, had the unfortunate side effect of losing some test coverage. This patch introduces new tests for the methods we lost coverage on, in the right place this time. Change-Id: I7ed344b8e6e8e1a29f0417a5a8f5a7c82ff06086 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ed344b8e6e8e1a29f0417a5a8f5a7c82ff06086 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Don't use Matchers.any
by amureini＠redhat.com 15 Jul '15

15 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't use Matchers.any ...................................................................... core: Don't use Matchers.any Changed StorageDomainToPoolRelationValidatorTest to use the actual IDs from the test objects (the storage domain and storage pool) instead of any(Guid.class). This makes the test stricter and helps validate we pass the correct objects around. Change-Id: I245a032fd666d853635540cd3a0625266e1eec40 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I245a032fd666d853635540cd3a0625266e1eec40 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove useless spyValidator() calls
by amureini＠redhat.com 15 Jul '15

15 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove useless spyValidator() calls ...................................................................... core: Remove useless spyValidator() calls Removed useless calls to spyValidator() - this is already done in the setUp(), and there's no reason to repeat it. Change-Id: I9c9e3efba4e8f9c51ce88db1c3c872f2e671d177 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c9e3efba4e8f9c51ce88db1c3c872f2e671d177 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0