- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Use explicit collection expressions
by amureini＠redhat.com 15 Jul '15

15 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use explicit collection expressions ...................................................................... core: Use explicit collection expressions Removed the confusing usage of ArrayLists and instead used Collections.singletonList(Object) and Collections.emptyList(). This both makes the test more explicit and easier to read and prevents mistakes in the future where someone may add something to these collections by mistake. Change-Id: I295d834307456a786e45880462bc6e3ce7974be7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java 1 file changed, 3 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295d834307456a786e45880462bc6e3ce7974be7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: standardize asserts
by amureini＠redhat.com 15 Jul '15

15 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: standardize asserts ...................................................................... core: standardize asserts Standardized the asserts in StorageDomainToPoolRelationValidatorTest to use assertThat with matchers from ValidationResultMatchers. This allows us to reduce code bloating (e.g., checking a validation twice - once to make sure it failed and then to verify the error message, having the same assertion message over and over, etc.). Change-Id: I2e2901dc8581ccabc28819e87c4e82bc3bbe412c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java 1 file changed, 20 insertions(+), 45 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e2901dc8581ccabc28819e87c4e82bc3bbe412c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Generic inference
by amureini＠redhat.com 15 Jul '15

15 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Generic inference ...................................................................... core: Generic inference Removed explicit generic parameters where they could be inferred as per Java 7 coding conventions. Change-Id: I4786c8a0e1dd1eb99f4ba7432d49fd90e2baada1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4786c8a0e1dd1eb99f4ba7432d49fd90e2baada1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Small typo prevented running all the mocks an once
by dcaroest＠redhat.com 15 Jul '15

15 Jul '15

David Caro has submitted this change and it was merged. Change subject: Small typo prevented running all the mocks an once ...................................................................... Small typo prevented running all the mocks an once Change-Id: I5d1ff10eb0152e80bb5e8f80c0daf42105446780 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/43415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d1ff10eb0152e80bb5e8f80c0daf42105446780 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: setting SELinux context on the loopback de...
by sbonazzo＠redhat.com 15 Jul '15

15 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: setting SELinux context on the loopback device ...................................................................... packaging: setup: setting SELinux context on the loopback device Hosted-engine with SPM requires a fake shared storage domain on a loopback device. Fixing its SELinux context to avoid SELinux denials when sanlock tries to use it. Using python selinuxlib binding instead of calling selinux utilities Change-Id: Ie3d66e137fbbe301bb93915c4330e41faa243414 Bug-Url: https://bugzilla.redhat.com/1242448 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 4 files changed, 27 insertions(+), 45 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3d66e137fbbe301bb93915c4330e41faa243414 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Avoid duplicated log appenders
by juan.hernandez＠redhat.com 15 Jul '15

15 Jul '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Avoid duplicated log appenders ...................................................................... sdk: Avoid duplicated log appenders Currently when the debug mode is enabled two appenders are added to the "org.apache.http" logger, one is added to the root category and another is added to the "org.apache.http" logger itself. This results in duplicated log messages. This patch changes the SDK so that only one appender is added. This change was done before, in commit a9776fd, but that changed only the generated code, so the change was lost after regenerating the SDK. This patch changes it generated code and in the template, so it won't be lost next time the SDK is regenerated. Change-Id: Ibf617e61a5d8b0ffefc172454228562078bcf0b5 Related: https://gerrit.ovirt.org/40518 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/java/templates/ApiTemplate M sdk/Makefile M sdk/src/main/java/org/ovirt/engine/sdk/Api.java 3 files changed, 1 insertion(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf617e61a5d8b0ffefc172454228562078bcf0b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[master]: cli: Don't remove "--" before validating parent options
by juan.hernandez＠redhat.com 15 Jul '15

15 Jul '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Don't remove "--" before validating parent options ...................................................................... cli: Don't remove "--" before validating parent options Currently the validation of the options that reference parents is performed comparing the option name without the "--" prefix, and this results in validation failures. This patch changes the CLI so that the validation is performed without removing that prefix. Change-Id: I115607bd3b18d82a0222b3757b17d958195ba035 Bug-Url: https://bugzilla.redhat.com/1241117 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I115607bd3b18d82a0222b3757b17d958195ba035 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: builtin: internal: encode password as PBE and add defaults
by masayag＠redhat.com 15 Jul '15

15 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: builtin: internal: encode password as PBE and add defaults ...................................................................... builtin: internal: encode password as PBE and add defaults this will enable to use the builtin internal extension as standalone extension in more secure method. will be useful for devenv and other special installation. in future the EngineExtensionsManager will no longer load the internal extension, setup will create extension configuration to load it, the password can be encoded using the ovirt-engine-crypto-tool. the engine-config AdminUser, AdminPassword setting will be depreciated once above method will be applied. for now, this change is transparent. Change-Id: Icc206c58c867b82400fff54d2b46df5cc203111a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java 3 files changed, 43 insertions(+), 33 deletions(-) Approvals: Alon Bar-Lev: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc206c58c867b82400fff54d2b46df5cc203111a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: publish-rpms-nightly-master: add ovirt-setup-lib
by sbonazzo＠redhat.com 15 Jul '15

15 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: publish-rpms-nightly-master: add ovirt-setup-lib ...................................................................... publish-rpms-nightly-master: add ovirt-setup-lib Add ovirt-setup-lib to published projects on nightly master. Change-Id: Iaf3fa1b9bade9b7f649325617e45c27c3ccacdfe Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/builders/copy-create-job-artifact.yaml M jobs/confs/yaml/jobs/ovirt/publish-rpms-nightly-master.yaml 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf3fa1b9bade9b7f649325617e45c27c3ccacdfe Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Set root password label overlap
by oourfali＠redhat.com 15 Jul '15

15 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Set root password label overlap ...................................................................... webadmin: Set root password label overlap - Fixed issue with over lapping text on 'Set Root Password' when using foreman provisioned hosts. And the translation was too long to fit on one line. Change-Id: I2612cf51177148dc8fa0d3417dad345e8590bb93 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1236979 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2612cf51177148dc8fa0d3417dad345e8590bb93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0