- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Build correctly instance type NIC links
by juan.hernandez＠redhat.com 10 Jul '15

10 Jul '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Build correctly instance type NIC links ...................................................................... restapi: Build correctly instance type NIC links The collection of NICs of instance types has been implemented reusing the class that implements the collection of NICs of templates. As a side effect the links to these NICs point to the templates collection instead of to the instance types collection. This patch introduces a new class to implement the collection of NICs of instance types, so that the "setParents" method that is used as part of the calculation of the link can be overriden to set a instance type as parent instead of a template. Change-Id: Ib3ab0857517a1fefc88b835457aa4b4241a3bb5d Bug-Url: https://bugzilla.redhat.com/1241574 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java 3 files changed, 23 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3ab0857517a1fefc88b835457aa4b4241a3bb5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal: make template from snapshot does not work in use...
by tjelinek＠redhat.com 10 Jul '15

10 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: make template from snapshot does not work in userportal ...................................................................... userportal: make template from snapshot does not work in userportal 2 issues: 1: user poral used the webadmin's NewTemplateVmModelBehavior while it was supposed to use the UserPortalNewTemplateVmModelBehavior 2: the userportal's VmSnapshotListModelProvider completely ignored the getCloneTemplateCommand Change-Id: I9f72dad9a5522f87ae085528168d5a1b9ccec275 Bug-Url: https://bugzilla.redhat.com/1231729 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/VmSnapshotListModelProvider.java 4 files changed, 19 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f72dad9a5522f87ae085528168d5a1b9ccec275 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: made show/hide advanced options with static width
by tjelinek＠redhat.com 10 Jul '15

10 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: made show/hide advanced options with static width ...................................................................... webadmin: made show/hide advanced options with static width Change-Id: I2dfde1002e858f763a85f08116262e18b08ec0a8 Bug-Url: https://bugzilla.redhat.com/1063765 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/VmPopupResources.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/VmPopupStyle.css M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UtilsModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/template/TemplateEditPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmClonePopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/instancetypes/InstanceTypesPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolNewPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/template/TemplateEditPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmClonePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmPopupView.java 13 files changed, 55 insertions(+), 22 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dfde1002e858f763a85f08116262e18b08ec0a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Instance images part ignored when created VM from ...
by tjelinek＠redhat.com 10 Jul '15

10 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Instance images part ignored when created VM from template list ...................................................................... webadmin: Instance images part ignored when created VM from template list The method which calls the image creation was called only from vm list - it has to be called from the base list to be available everywhere. Change-Id: Ie57f05e8feaed5923dc16144ecac183e1b888241 Bug-Url: https://bugzilla.redhat.com/1225517 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 2 files changed, 3 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie57f05e8feaed5923dc16144ecac183e1b888241 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Extending the standard mock runner
by dcaroest＠redhat.com 10 Jul '15

10 Jul '15

David Caro has submitted this change and it was merged. Change subject: Extending the standard mock runner ...................................................................... Extending the standard mock runner - Added fix when running on fc22 (dnf based) - Added possiblity to specify custom repos and mounts: * file: $script.req[.$dist] || $script.packages[.$dist] content: packages to install, one per line * file: $script.mounts[.$dist] content: src[:dst] tuples with source directory to mount where, one per line * file: $script.repos[.$dist] content: [name:] url tuples with the repos to add, one per line - Improved log collection, now one dir per action inside $PWD/logs dir - Ability to specify custom mock confs dir (that way you can use installed defaults or the ones pulled from jenkins/mock_configs repo that will be used by jenkins) - Using different root for each repo combination, that allows a correct usage of the mock caches - Allow using proxified configs - Fixed issues with permissions when building with rpmbuild inside the mock env - Outputting the time taken on each main action - Using nosync if available to speed up disk operations Change-Id: I2cc47c8a4d497fcf3039dc6575c152b6a507c0d2 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/epel-6-x86_64.cfg M mock_configs/mock_runner.sh M mock_configs/site-defaults.cfg 3 files changed, 645 insertions(+), 178 deletions(-) Approvals: David Caro: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/42667 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cc47c8a4d497fcf3039dc6575c152b6a507c0d2 Gerrit-PatchSet: 14 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

1 0

Change in ovirt-release[master]: Added pyxattr and userspace-rcu to EPEL 6 repository for Glu...
by sbonazzo＠redhat.com 10 Jul '15

10 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Added pyxattr and userspace-rcu to EPEL 6 repository for Gluster 3.7.2 ...................................................................... Added pyxattr and userspace-rcu to EPEL 6 repository for Gluster 3.7.2 Change-Id: I3b0aebb7fb47f48f4cf74f30b92566bec49d2812 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.5/configure.ac M ovirt-release-3.5/ovirt-el6-deps.repo.in M ovirt-release-3.5/ovirt-el7-deps.repo.in M ovirt-release-3.5/ovirt-release35.spec.in M ovirt-release-3.6/configure.ac M ovirt-release-3.6/ovirt-el6-deps.repo.in M ovirt-release-3.6/ovirt-release36.spec.in M ovirt-release-master/configure.ac M ovirt-release-master/ovirt-el6-deps.repo.in M ovirt-release-master/ovirt-release-master.spec.in 10 files changed, 17 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b0aebb7fb47f48f4cf74f30b92566bec49d2812 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Randomize otopi events schedule
by dcaroest＠redhat.com 10 Jul '15

10 Jul '15

David Caro has submitted this change and it was merged. Change subject: Randomize otopi events schedule ...................................................................... Randomize otopi events schedule Change all answer files to make otopi randomize events. This will hopefully help catch scheduling bugs faster. Change-Id: I16e38f8fda78f85b952594d5e4ad5e1e8e273a1c Related-To: https://bugzilla.redhat.com/1241445 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/ovirt-engine_upgrade_stable_to_3.4/cleanup.file.otopi M jobs/ovirt-engine_upgrade_stable_to_3.4/setup.file.otopi M jobs/ovirt_engine_upgrade_params/answer.file.otopi M jobs/ovirt_engine_upgrade_params/cleanup.file.otopi 4 files changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for review David Caro: Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/43406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16e38f8fda78f85b952594d5e4ad5e1e8e273a1c Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Rename SetVm_poolBeingDestroyed
by ahadas＠redhat.com 10 Jul '15

10 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: core: Rename SetVm_poolBeingDestroyed ...................................................................... core: Rename SetVm_poolBeingDestroyed SetVm_poolBeingDestroyed stored procedure renamed to SetVmPoolBeingDestroyed. Change-Id: Iae80c5f8fe2cb554d20c9d316dc755124379bacf Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDaoImpl.java M packaging/dbscripts/vm_pools_sp.sql 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae80c5f8fe2cb554d20c9d316dc755124379bacf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: host-deploy: cleanup: use constant for vmconsole condition
by masayag＠redhat.com 09 Jul '15

09 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: host-deploy: cleanup: use constant for vmconsole condition ...................................................................... host-deploy: cleanup: use constant for vmconsole condition Change-Id: I04e670e7afb916a8eb38a43bbb0bdd31653a35e6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeploy.java 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04e670e7afb916a8eb38a43bbb0bdd31653a35e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Removal of VM pool with VMs
by ahadas＠redhat.com 09 Jul '15

09 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: engine: Removal of VM pool with VMs ...................................................................... engine: Removal of VM pool with VMs Rewritten RemoveVmPoolCommand to support removal of VM pools with VMs in it. The following operations are performed: 1. Execute StopVm for each running VM in the pool. 2. Wait until all VMs in the pool are down. 3. Execute RemoveVmFromPool for each VM in the pool to detach it and RemoveVm to remove it completely. 4. After detaching all VMs, remove the pool. Change-Id: I58b0f37903447b49edf74bea5a51108818701698 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168249 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1720_vm_pools_add_is_being_destroyed.sql M packaging/dbscripts/vm_pools_sp.sql 25 files changed, 478 insertions(+), 79 deletions(-) Approvals: Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/40557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58b0f37903447b49edf74bea5a51108818701698 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0