- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: support for username+domain on import vm
by ahadas＠redhat.com 09 Jul '15

09 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: support for username+domain on import vm ...................................................................... webadmin: support for username+domain on import vm When importing VM from vCenter 6.0, one needs to provide the domain along with the user name (e.g username@domain). Thus, the validation of ASCII characters in the username is removed and the '@' in the username is replaced with '%40' so the URI will be valid. Change-Id: Icabc34f40195d071c3389cee1bba57073672c93e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NameAndOptionalDomainValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 27 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icabc34f40195d071c3389cee1bba57073672c93e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: UX: addHost form leaves json checkbox locked when ...
by oourfali＠redhat.com 09 Jul '15

09 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: UX: addHost form leaves json checkbox locked when switching between clusters ...................................................................... webadmin: UX: addHost form leaves json checkbox locked when switching between clusters Edit host dialog should display the protocol saved in the database. Change-Id: Ie12aff2897c53b1de3c68086904110034ed0cee4 Bug-Url: https://bugzilla.redhat.com/1209754 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie12aff2897c53b1de3c68086904110034ed0cee4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add missing login priv to importer_exporter
by amureini＠redhat.com 09 Jul '15

09 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Add missing login priv to importer_exporter ...................................................................... core: Add missing login priv to importer_exporter Change-Id: Ibba4aa0bd138fe831d463f63fb23d275e13c98c7 Bug-Url: https://bugzilla.redhat.com/1108153 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1710_add_login_export_import_admin.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibba4aa0bd138fe831d463f63fb23d275e13c98c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: jobs: Add yaml job for ovirt-register
by tlitovsk＠redhat.com 09 Jul '15

09 Jul '15

Anatoly Litovsky has submitted this change and it was merged. Change subject: jobs: Add yaml job for ovirt-register ...................................................................... jobs: Add yaml job for ovirt-register Change-Id: Ifcc0c5018373671e0574cf8d8d605a69124b9d72 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-register/ovirt-register.yaml A jobs/confs/yaml/scms/ovirt-register-scms.yaml 2 files changed, 35 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Jenkins CI: Passed CI tests Anatoly Litovsky: Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/43291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcc0c5018373671e0574cf8d8d605a69124b9d72 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI

1 0

Change in ovirt-engine[master]: restapi: Add 'placeholder' attribute to VmHostDevice resources
by juan.hernandez＠redhat.com 09 Jul '15

09 Jul '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add 'placeholder' attribute to VmHostDevice resources ...................................................................... restapi: Add 'placeholder' attribute to VmHostDevice resources So far the backend only returned the devices that are to be attached to the VM. Now it returns all host devices configured for the VM and distinguishes IOMMU placeholder devices with additional boolean flag. This patch exposes to the REST users that some host device is configured on the VM only as a placeholder using the optional <placeholder>true</placeholder> element. Change-Id: I76e9945cb680537a83b036b6f87cf5aeb33fa420 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmHostDeviceResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmHostDevicesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendHostDevicesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostDeviceResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostDevicesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmHostDeviceResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmHostDevicesResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostDeviceMapper.java 9 files changed, 59 insertions(+), 19 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/43316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76e9945cb680537a83b036b6f87cf5aeb33fa420 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: null check in CommandBase.parentHasCallback()
by ofrenkel＠redhat.com 09 Jul '15

09 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: null check in CommandBase.parentHasCallback() ...................................................................... core: null check in CommandBase.parentHasCallback() Fixed NullPointerException thrown in CommandBase.parentHasCallback(), when parentCommand is set, but parentParameters are not set in the command's parameters (for example, AddVmPoolWithVmsCommand called from CommonVmPoolWithVmsCommand). Change-Id: I2e24a042cb990e62367a160627657b95bf2921e3 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e24a042cb990e62367a160627657b95bf2921e3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: build: drop fc20 builds from master
by sbonazzo＠redhat.com 09 Jul '15

09 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: drop fc20 builds from master ...................................................................... build: drop fc20 builds from master Dropped fc20 builds from all projects. For reference: http://lists.ovirt.org/pipermail/users/2015-June/033454.html Change-Id: Ieb4711e2a7c207b592a48ba132b1f809957da48e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/builders/copy-create-job-artifact.yaml M jobs/confs/yaml/jobs/ebay-cors-filter/ebay-cors-filter.yaml M jobs/confs/yaml/jobs/ioprocess/ioprocess_create-rpms.yaml M jobs/confs/yaml/jobs/jasper-reports/jasper-reports_create-rpms.yaml M jobs/confs/yaml/jobs/mom/mom_create-rpms.yaml M jobs/confs/yaml/jobs/otopi/otopi_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-dwh/ovirt-dwh_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-jdbc/ovirt-engine-extension-aaa-jdbc_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-misc/ovirt-engine-extension-aaa-misc_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-extension-logger-log4j/ovirt-engine-extension-logger-log4j_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-sdk-java/ovirt-engine-sdk-java_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml M jobs/confs/yaml/jobs/ovirt-engine-wildfly-overlay/ovirt-engine-wildfly-overlay.yaml M jobs/confs/yaml/jobs/ovirt-engine-wildfly/ovirt-engine-wildfly.yaml M jobs/confs/yaml/jobs/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-image-uploader/ovirt-image-uploader_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-reports/ovirt-reports_create-rpms.yaml M jobs/confs/yaml/jobs/repoman/repoman_build-artifacts.yaml M jobs/confs/yaml/jobs/unboundid-ldapsdk/unboundid-ldapsdk_create-rpms.yaml M jobs/confs/yaml/jobs/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml 23 files changed, 12 insertions(+), 23 deletions(-) Approvals: Fabian Deutsch: Looks good to me Piotr Kliczewski: Looks good to me Sandro Bonazzola: Verified; Ready for merge Martin Peřina: Looks good to me Juan Hernández: Looks good to me Eyal Edri: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb4711e2a7c207b592a48ba132b1f809957da48e Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernández Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Invoke FullList command using the resource manager
by rgolan＠redhat.com 09 Jul '15

09 Jul '15

Roy Golan has submitted this change and it was merged. Change subject: core: Invoke FullList command using the resource manager ...................................................................... core: Invoke FullList command using the resource manager Direct constructor usage of commands is a violation of the API Bug-Url: https://bugzilla.redhat.com/1160094 Change-Id: I3c9c2314a1c0d5dd307b6401739c3b052dd3ec68 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FullListVDSCommand.java 4 files changed, 15 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Verified; Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c9c2314a1c0d5dd307b6401739c3b052dd3ec68 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: refactor live merge code to handle async child command
by amureini＠redhat.com 09 Jul '15

09 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: refactor live merge code to handle async child command ...................................................................... core: refactor live merge code to handle async child command In the spirit of DRY, combine two blocks of code that were largely the same. Change-Id: Ife74a1787c2671fbdb2d2c4dc99e38b088f69dfe Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 1 file changed, 26 insertions(+), 27 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife74a1787c2671fbdb2d2c4dc99e38b088f69dfe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: handle Live Merge when top volume is larger than base
by amureini＠redhat.com 09 Jul '15

09 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: handle Live Merge when top volume is larger than base ...................................................................... core: handle Live Merge when top volume is larger than base When a Live Merge is perfomed today, it internally performs a block commit operation to copy data from a volume to its parent. If the disk had been extended after the snapshot was created, the sizes of the two volumes will not match. In most cases the size is adjusted properly by the underlying processes performing the merge; to account for this, engine will update the size of the volume in the database to reflect the new, correct size. In the case of a raw volume on block storage, an explicit extension needs to take place before the merge. For this, a new child command of Live Merge has been added to run before the merge starts. For further detail, see comments to: https://bugzilla.redhat.com/show_bug.cgi?id=1232481 Change-Id: I628323b799a37691c40ea97590d4967f3ebf4a2b Bug-Url: https://bugzilla.redhat.com/1236758 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ExtendImageSizeParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotSingleDiskLiveStep.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 7 files changed, 212 insertions(+), 3 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I628323b799a37691c40ea97590d4967f3ebf4a2b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0