- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: cleanup SessionDataContainer
by masayag＠redhat.com 05 Jul '15

05 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: aaa: cleanup SessionDataContainer ...................................................................... aaa: cleanup SessionDataContainer remove public from non public methods. remove unused methods. remove unused SetDataOnSession command. modify GetValueBySession query which is actually a non generic hack to GetDbUserBySession as this is actually what it does. Change-Id: Ia102443336f73959a9e1f2942cf1dc4225683ada Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDbUserBySessionQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SetDataOnSessionCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetDataOnSessionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetValueBySessionQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/CurrentFilter.java 9 files changed, 13 insertions(+), 109 deletions(-) Approvals: Alon Bar-Lev: Verified Ori Liel: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia102443336f73959a9e1f2942cf1dc4225683ada Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: add CEPH version to hosts general sub-tab
by derez＠redhat.com 05 Jul '15

05 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add CEPH version to hosts general sub-tab ...................................................................... webadmin: add CEPH version to hosts general sub-tab Adding 'CEPH version' text-box to 'Hosts -> General -> Software'. Change-Id: Ibb0e136b67b560f1fe4bcfe71ffebad384e00585 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java 3 files changed, 20 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb0e136b67b560f1fe4bcfe71ffebad384e00585 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: disable RemoveStorageDomain for Cinder
by derez＠redhat.com 05 Jul '15

05 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: disable RemoveStorageDomain for Cinder ...................................................................... core: disable RemoveStorageDomain for Cinder Similarly to Glance domains, RemoveStorageDomainCommand should be blocked for Cinder domains (since it's handled by RemoveProviderCommand). Change-Id: I4470c80cc50a350bfaf5026fecd9f302de052930 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4470c80cc50a350bfaf5026fecd9f302de052930 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: NonOperational vds on libvirt secrets register error
by derez＠redhat.com 05 Jul '15

05 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: NonOperational vds on libvirt secrets register error ...................................................................... core: NonOperational vds on libvirt secrets register error Update VDS status to NonOperational on failure of libvirt secrets registration. Change-Id: I8a4f08f18c9f870cd6aacab3d331787b67e3f3ff Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 8 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a4f08f18c9f870cd6aacab3d331787b67e3f3ff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: check librbd1 package availability on vds activation
by derez＠redhat.com 05 Jul '15

05 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: check librbd1 package availability on vds activation ...................................................................... core: check librbd1 package availability on vds activation Validate librbd1 package availability on ConnectHostToStoragePoolServersCommand. Change-Id: I9fd975930327211a4670ab23b30f25ba99b8379b Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 6 files changed, 64 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd975930327211a4670ab23b30f25ba99b8379b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: check librbd1 package availability on connection
by derez＠redhat.com 05 Jul '15

05 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: check librbd1 package availability on connection ...................................................................... core: check librbd1 package availability on connection Validate librbd1 package availability on runConnectionStorageToDomain method (in CINDERStorageHelper). Change-Id: Ia335ee86a82b5522f015cd11d521a027366b4225 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia335ee86a82b5522f015cd11d521a027366b4225 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding dao test for librbd version
by derez＠redhat.com 05 Jul '15

05 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: adding dao test for librbd version ...................................................................... core: adding dao test for librbd version Adding 'testLibrbdVersion' to VdsDynamicDAOTest. Change-Id: Icc105f27f3abad0852bf606ffd4242265c610a74 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc105f27f3abad0852bf606ffd4242265c610a74 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: retrieve and store librbd1 package version
by derez＠redhat.com 05 Jul '15

05 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: retrieve and store librbd1 package version ...................................................................... core: retrieve and store librbd1 package version Retrieving 'librbd1' package version from vdsm (getCapabilities), and stores its value on VdsDynamic. Change-Id: I9b7775842bec8502bd745b80d63c3eaad3690bf8 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1690_add_librbd1_version_to_vds_dynamic.sql M packaging/dbscripts/vds_sp.sql 9 files changed, 36 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b7775842bec8502bd745b80d63c3eaad3690bf8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: ear: remove built-in extension
by masayag＠redhat.com 05 Jul '15

05 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: ear: remove built-in extension ...................................................................... ear: remove built-in extension not needed, probably leftover from migration period. Change-Id: Icc3006aeebaa2ba7f9abe4595a6409d11b292128 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ear/src/main/application/META-INF/jboss-deployment-structure.xml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc3006aeebaa2ba7f9abe4595a6409d11b292128 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: handle boolean values correctly in search
by emesika＠redhat.com 05 Jul '15

05 Jul '15

Eli Mesika has submitted this change and it was merged. Change subject: core: handle boolean values correctly in search ...................................................................... core: handle boolean values correctly in search In some places fields expected a boolean value in the search engine did not use the BitValueAutoCompleter The result was that other values except true/false could be inserted as a value generating the reported error. This patch fixes that. Change-Id: I78b7269f67846bbbb4ed28b0adf0db8a6e2be70b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1235716 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/AuditLogConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdsConditionFieldAutoCompleter.java 2 files changed, 10 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78b7269f67846bbbb4ed28b0adf0db8a6e2be70b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0