- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: remove override from Custom Connection Parameters
by tnisan＠redhat.com 06 Jul '15

06 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: remove override from Custom Connection Parameters ...................................................................... webadmin: remove override from Custom Connection Parameters This checkbox is unnecessary. Change-Id: Ifb54d97a9eb06df07c443bde9ddc1b76948ced80 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml 4 files changed, 25 insertions(+), 67 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/42735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb54d97a9eb06df07c443bde9ddc1b76948ced80 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Change NfsStorageView.ui.xml syntax
by tnisan＠redhat.com 06 Jul '15

06 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Change NfsStorageView.ui.xml syntax ...................................................................... webadmin: Change NfsStorageView.ui.xml syntax Replace HTML with gwt elements. Changed expander visibility to align with other fields in the view. Change-Id: I78a2c4b65534dd6058b2fddfcef1b9369e76f93a Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ShortEntityModelTextBoxEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml 3 files changed, 134 insertions(+), 194 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/42734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78a2c4b65534dd6058b2fddfcef1b9369e76f93a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Remove '*' and bold style from the NFS override de...
by tnisan＠redhat.com 06 Jul '15

06 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove '*' and bold style from the NFS override defaults alert ...................................................................... webadmin: Remove '*' and bold style from the NFS override defaults alert Change-Id: I0c27c97114d2e25e6a5f559405121a462da3f24e Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/42733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c27c97114d2e25e6a5f559405121a462da3f24e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Move up the Gluster alert
by tnisan＠redhat.com 06 Jul '15

06 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Move up the Gluster alert ...................................................................... webadmin: Move up the Gluster alert Leave a small gap after the alert for a cleaner look. Change-Id: Ia9205cdd6b97ec3af02fc723325121adcf67d426 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.ui.xml 1 file changed, 11 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/42732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9205cdd6b97ec3af02fc723325121adcf67d426 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Changed/added path examples for storage
by tnisan＠redhat.com 06 Jul '15

06 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Changed/added path examples for storage ...................................................................... webadmin: Changed/added path examples for storage Changed the exapmle for NFS, added one for POSIX and Gluster. Removed explanations to all the above as this should be clear what "Path" means. Also aligned them with the Path editor above. Change-Id: I29c69ed540c3c606be4a80edd72a783ccd1dae34 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml 7 files changed, 26 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/42523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29c69ed540c3c606be4a80edd72a783ccd1dae34 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Storage popup view Changes
by tnisan＠redhat.com 06 Jul '15

06 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Storage popup view Changes ...................................................................... webadmin: Storage popup view Changes Changes to how the New/Edit/Import Storage dialog looks. * Removed green area. * Created grey area. * Format moved to advanced parameters. * Domain Function and Storage Type were separated. Change-Id: Id8ed6d6818976ef76267b5fd8a3ca19c83fcda06 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 6 files changed, 170 insertions(+), 122 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/42432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8ed6d6818976ef76267b5fd8a3ca19c83fcda06 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix error message, adding vm with disk profile, wrong ...
by tnisan＠redhat.com 06 Jul '15

06 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error message, adding vm with disk profile, wrong storage. ...................................................................... core: Fix error message, adding vm with disk profile, wrong storage. 1. Get the name of the storage domain provided in the request. 2. Add the id of the disk profile to the error message. Disk profile may have same name but in different storages. Change-Id: Id7e39081f2c409513d865473a19e9e8fea71aa4c Bug-Url: https://bugzilla.redhat.com/1220127 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 15 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Dudi Maroshi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7e39081f2c409513d865473a19e9e8fea71aa4c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.5]: automation: add automation scripts
by juan.hernandez＠redhat.com 06 Jul '15

06 Jul '15

Juan Hernandez has submitted this change and it was merged. Change subject: automation: add automation scripts ...................................................................... automation: add automation scripts Added automation scripts as per http://www.ovirt.org/CI/Build_and_test_standards Change-Id: Ice348d6a168428c8ec605e11ddb8af7012e12991 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A automation/README.md A automation/build-artifacts.req A automation/build-artifacts.sh A automation/check-merged.req A automation/check-merged.sh A automation/check-patch.req A automation/check-patch.sh 7 files changed, 37 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me Juan Hernandez: Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice348d6a168428c8ec605e11ddb8af7012e12991 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add debug logs for vm status events
by ofrenkel＠redhat.com 06 Jul '15

06 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: add debug logs for vm status events ...................................................................... core: add debug logs for vm status events while debugging issues around vm-status events, some logs were added for easier debugging: * full event data, including the host that handles the event. * subscriber id of host on subscription. Change-Id: I4d792709766794dcb395ac25b8ba5faa8a7e7ab4 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d792709766794dcb395ac25b8ba5faa8a7e7ab4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Added new needed option
by sbonazzo＠redhat.com 06 Jul '15

06 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Added new needed option ...................................................................... Added new needed option Change-Id: Ifcecf5921b761588e26f468d13f094ff8a3caca4 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/ovirt-engine_upgrade_stable_to_3.4/setup.file.otopi 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Passed CI tests; Ready for merge David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/43185 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcecf5921b761588e26f468d13f094ff8a3caca4 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0