- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Introduce HostNicVfsConfig business entity
by alkaplan＠redhat.com 23 Mar '15

23 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Introduce HostNicVfsConfig business entity ...................................................................... engine: Introduce HostNicVfsConfig business entity Change-Id: If7124708e1fc2ba1ed1d827f9db54fe31a2e4856 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNicVfsConfig.java 1 file changed, 136 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/35947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7124708e1fc2ba1ed1d827f9db54fe31a2e4856 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: adding PCI-passthrough vnic type
by alkaplan＠redhat.com 23 Mar '15

23 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: adding PCI-passthrough vnic type ...................................................................... engine: adding PCI-passthrough vnic type PCI-passthrough vnic type means the vnic should be connected directly to a VF. Change-Id: I69f10593efacb1da63cef5e1b88e37f4dffcd2db Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmInterfaceType.java M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M packaging/conf/osinfo-defaults.properties 5 files changed, 10 insertions(+), 6 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/35945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69f10593efacb1da63cef5e1b88e37f4dffcd2db Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: NetworkSriovSupported config value
by alkaplan＠redhat.com 23 Mar '15

23 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: NetworkSriovSupported config value ...................................................................... engine: NetworkSriovSupported config value Adding NetworkSriovSupprted config value. It will indicate whether the SR-IOV nics are supported and can be managed. Change-Id: Iafda66f0a17cd0bd08a7a8896abeedf118a723fb Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 17 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/35944 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafda66f0a17cd0bd08a7a8896abeedf118a723fb Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: refactor VnicProfileDaoTest to use assertFalse/True
by alkaplan＠redhat.com 23 Mar '15

23 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: refactor VnicProfileDaoTest to use assertFalse/True ...................................................................... engine: refactor VnicProfileDaoTest to use assertFalse/True replace assertEquals(true, actual) with assertTrue(actual) and assertEquals(false, actual) with assertFalase(actual) Change-Id: Ia451871e45adcbd6110d49759c6122c23548c33a Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VnicProfileDaoTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia451871e45adcbd6110d49759c6122c23548c33a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: adding 'passthrough' property to vnicProfile
by alkaplan＠redhat.com 23 Mar '15

23 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: adding 'passthrough' property to vnicProfile ...................................................................... engine: adding 'passthrough' property to vnicProfile The 'passthrough' property will indicate that a VF should be directly attached to the VM. Change-Id: I7ed7e63ad66aa2f5dc7584c96202a5f0c1ab1522 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VnicProfileDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VnicProfileDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/03_06_1080_add_passthrough_to_vnic_profiles.sql 8 files changed, 54 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ed7e63ad66aa2f5dc7584c96202a5f0c1ab1522 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: host_device.vm_id should be engine only field
by alkaplan＠redhat.com 23 Mar '15

23 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: host_device.vm_id should be engine only field ...................................................................... engine: host_device.vm_id should be engine only field The vm id that is reported by the vdsm is the one that was passed to it by the engine. If a device was attached to a vm via a hook, a vm_id won't be reported. It means, the vdsm.vm_id doesn't have any extra value and can be ignored by the engine. Change-Id: I6865c2414db3ff9d92b7c51f4523d85176e5b0c1 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoDbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M packaging/dbscripts/host_device_sp.sql 3 files changed, 6 insertions(+), 17 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6865c2414db3ff9d92b7c51f4523d85176e5b0c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: RefreshHostDevicesCommand should't proceed in case o...
by alkaplan＠redhat.com 23 Mar '15

23 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: RefreshHostDevicesCommand should't proceed in case of vdsm failure ...................................................................... engine: RefreshHostDevicesCommand should't proceed in case of vdsm failure Procceeding with the command casues removal of all the entries in the host_device table. Change-Id: Iec8a4549bd76bce766ea9f7e6dde17b86f7e0a67 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec8a4549bd76bce766ea9f7e6dde17b86f7e0a67 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: read 'interface' property from HostDevListByCaps result
by alkaplan＠redhat.com 23 Mar '15

23 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: read 'interface' property from HostDevListByCaps result ...................................................................... engine: read 'interface' property from HostDevListByCaps result Change-Id: Id4deae6a655fa1db96411a99a9189f975e3667dd Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDevice.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/host_device_sp.sql A packaging/dbscripts/upgrade/03_06_1070_add_iface_column_to_host_device_table.sql 9 files changed, 117 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4deae6a655fa1db96411a99a9189f975e3667dd Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: maintain camelCase
by oourfali＠redhat.com 23 Mar '15

23 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: maintain camelCase ...................................................................... engine: maintain camelCase Change-Id: Ie90f2b66ca6e3af71ffcec1a8b83a4af99fe8617 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java 3 files changed, 24 insertions(+), 24 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie90f2b66ca6e3af71ffcec1a8b83a4af99fe8617 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Fix NPE in VmCountColumn
by tjelinek＠redhat.com 23 Mar '15

23 Mar '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix NPE in VmCountColumn ...................................................................... frontend: Fix NPE in VmCountColumn Integer VDS#getVmMigrating() was assigned to int Change-Id: I7114cc3b9ab92883b86229c7d59addd9a8dff3f2 Bug-Url: https://bugzilla.redhat.com/1204493 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmCountColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/38981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7114cc3b9ab92883b86229c7d59addd9a8dff3f2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0