- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: AsyncDataProvider - getStorageDomainByName
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: AsyncDataProvider - getStorageDomainByName ...................................................................... webadmin: AsyncDataProvider - getStorageDomainByName Adding getStorageDomainByName method to AsyncDataProvider in order to get the storage domain associated to a provider. Change-Id: Icfe16e440fd9413d6e09e886bb66af35ded5a388 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfe16e440fd9413d6e09e886bb66af35ded5a388 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: SystemTreeItemCell - OPENSTACK_VOLUME
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: SystemTreeItemCell - OPENSTACK_VOLUME ...................................................................... webadmin: SystemTreeItemCell - OPENSTACK_VOLUME SystemTreeItemCell - add OPENSTACK_VOLUME to provider branch to ensure openstack icon on system tree. Change-Id: Icdfd4f4ecda451ddac5891150b061c654aee186f Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38932 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdfd4f4ecda451ddac5891150b061c654aee186f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add ProviderType OPENSTACK_VOLUME to enums
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add ProviderType OPENSTACK_VOLUME to enums ...................................................................... webadmin: add ProviderType OPENSTACK_VOLUME to enums enums.java/properties: adding ProviderType OPENSTACK_VOLUME Change-Id: I5689a668c64b284c8fd99c7af4359b49275cc9be Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5689a668c64b284c8fd99c7af4359b49275cc9be Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: common.gwt.xml - OpenStackVolumeProviderProperties
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: common.gwt.xml - OpenStackVolumeProviderProperties ...................................................................... webadmin: common.gwt.xml - OpenStackVolumeProviderProperties Adding OpenStackVolumeProviderProperties to Common.gwt.xml for UI usage. Change-Id: I131315a986fe9a790642ec5277ba5945befa1a99 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I131315a986fe9a790642ec5277ba5945befa1a99 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add StorageType CINDER to enums
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add StorageType CINDER to enums ...................................................................... webadmin: add StorageType CINDER to enums enums.java/properties: adding StorageType CINDER Change-Id: Iea4ac7e78d2487192bb3de88abdbbc9983daf6bd Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea4ac7e78d2487192bb3de88abdbbc9983daf6bd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add StorageDomainType Volume to enums
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add StorageDomainType Volume to enums ...................................................................... webadmin: add StorageDomainType Volume to enums enums.java/properties: adding StorageDomainType Volume Change-Id: Ie8241712e26232bb14c746dd0d53decb22259af1 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8241712e26232bb14c746dd0d53decb22259af1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: handle ExecuteFailedMessages on runAction
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: frontend: handle ExecuteFailedMessages on runAction ...................................................................... frontend: handle ExecuteFailedMessages on runAction Frontend -> handleActionResult: Invoking 'translateExecuteFailedMessages' when 'executeFailedMessages' are available (i.e. translate error messages upon runAction failure). Change-Id: I82fb7f297e92d0848c0b25c43c17fc904f1c06b5 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase_CustomFieldSerializer.java 3 files changed, 14 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82fb7f297e92d0848c0b25c43c17fc904f1c06b5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: catch OpenStackResponseException on execute
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: catch OpenStackResponseException on execute ...................................................................... core: catch OpenStackResponseException on execute CommandBase -> executeWithoutTransaction: catch OpenStackResponseException to handle only when necessary (i.e. when no failure messages have been added). Change-Id: Ic84ee67e0cb83763d26bba82dd03131d5b97a38d Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic84ee67e0cb83763d26bba82dd03131d5b97a38d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: AddProviderCommand - validation for specific types
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: AddProviderCommand - validation for specific types ...................................................................... core: AddProviderCommand - validation for specific types * Verify provider existence and support. * Invoke validateAddProvider method to support specific validate implementations (Cinder/Glance/etc). Change-Id: Ie2f7130fcf3904ac771c403f9c81976140659c33 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2f7130fcf3904ac771c403f9c81976140659c33 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ProviderValidator - validateAddProvider
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: ProviderValidator - validateAddProvider ...................................................................... core: ProviderValidator - validateAddProvider Added validateAddProvider which should include specific validations that each sub-class can override and implement. I.e. each proxy type (Image/Volume/etc) could now have its own set of validations. Change-Id: I84c189cd379e1abdc2c0ab2fa621567f40583113 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84c189cd379e1abdc2c0ab2fa621567f40583113 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0