- Engine-commits - oVirt List Archives

Change in jenkins[master]: Adding centos6 ovirt node builder job
by dcaroest＠redhat.com 23 Feb '15

23 Feb '15

David Caro has submitted this change and it was merged. Change subject: Adding centos6 ovirt node builder job ...................................................................... Adding centos6 ovirt node builder job Change-Id: I518b13c10a305ae498042f7560a34f7eccdde762 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/yaml/jobs/ovirt-node/ovirt-node-job.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve David Caro: Looks good to me, approved Anatoly Litovsky: Verified -- To view, visit http://gerrit.ovirt.org/38064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I518b13c10a305ae498042f7560a34f7eccdde762 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Report errors during db restore
by sbonazzo＠redhat.com 23 Feb '15

23 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Report errors during db restore ...................................................................... packaging: setup: Report errors during db restore Change-Id: I8e1a3e281cee907d652db1193a7e36130de20260 Bug-Url: https://bugzilla.redhat.com/1078871 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 45 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e1a3e281cee907d652db1193a7e36130de20260 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix cpu-profile setting on import dialog
by ahadas＠redhat.com 23 Feb '15

23 Feb '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: fix cpu-profile setting on import dialog ...................................................................... webadmin: fix cpu-profile setting on import dialog In the new two-phases import dialog, the cpu-profile setting was cleared when switching to the second screen and then back to the first screen. This patch fix it by not initializing a new instance of ImportVmFromExportDomainModel on every switch to the second screen. Instead, we initialize it in advance and use the same instance. Change-Id: I8bb3e500952949acf3795a5f92dd6160a4df9171 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 2 files changed, 37 insertions(+), 34 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/37879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bb3e500952949acf3795a5f92dd6160a4df9171 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: optimize getUriBuilder
by juan.hernandez＠redhat.com 23 Feb '15

23 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: optimize getUriBuilder ...................................................................... restapi: optimize getUriBuilder - Whenever we needed to build a Uri we would create a new UriBuilder from the passed in model. The structure of the builder is based on type of the model. This patch instead of creating a new one from scratch each time, caches the UriBuilder and returns a clone. Cloning the builder is much faster than creating a new one from scratch. Using a cloned builder ensures there are no concurrency issues associated with the builder. Change-Id: I86221e8af24da28a7137c0cc0e7aec69943a65c5 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java 2 files changed, 54 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Alexander Wels: Verified -- To view, visit http://gerrit.ovirt.org/37988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86221e8af24da28a7137c0cc0e7aec69943a65c5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix skipped status in fencing
by oourfali＠redhat.com 23 Feb '15

23 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix skipped status in fencing ...................................................................... core: Fix skipped status in fencing Fixes the distinction between two types of skipping fencing operation: 1. Skipped due to status - on/off operation is skipped because host power status is already on/off 2. Skipped due to fencing policy - on/off operation is skipped becuase host is non responsive but it's still connected to storage Change-Id: Ia0c2a76d10a7e501ed5a53b323acb251c05c06fb Bug-Url: https://bugzilla.redhat.com/1192596 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceStatusReturnValue.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSFenceReturnValue.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java 6 files changed, 35 insertions(+), 11 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve Objections: oVirt Jenkins CI Server: Fails -- To view, visit http://gerrit.ovirt.org/37857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0c2a76d10a7e501ed5a53b323acb251c05c06fb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: always set principal when fetching principal record
by oourfali＠redhat.com 23 Feb '15

23 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: always set principal when fetching principal record ...................................................................... aaa: always set principal when fetching principal record although information is available in AuthRecord, and extensions should fall back into optional Principal anyway (as already do), it would be nicer to provide both Principal and AuthRecord if available to simplify extension implementation. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1192791 Change-Id: I1330df35a054713d2e42c00bf70ea52ff0b49021 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java 1 file changed, 26 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Ravi Nori: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1330df35a054713d2e42c00bf70ea52ff0b49021 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: uutil: add universal ticketing utilities
by oourfali＠redhat.com 23 Feb '15

23 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: uutil: add universal ticketing utilities ...................................................................... uutil: add universal ticketing utilities base is the websocket proxy ticket, with symmetric operations in both java and python. a new certificate field was added to allow x509 trust with eku without need to specify certificate at decoder. removal of insecure mode as not required after bootstrapping the feature. library is useful for: 1. websocket proxy 2. serial console proxy 3. sso Change-Id: Ibc87ea4a4ea540dfea09e40f4396d6918e34e019 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SignStringQuery.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java M backend/manager/modules/uutils/exclude-filters.xml M backend/manager/modules/uutils/pom.xml A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/ticket/TicketDecoder.java A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/ticket/TicketEncoder.java M backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml A backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/crypto/ticket/TicketTest.java A backend/manager/modules/uutils/src/test/resources/ticket/ca1.jks A backend/manager/modules/uutils/src/test/resources/ticket/ca1test1.p12 A backend/manager/modules/uutils/src/test/resources/ticket/ca1test2.p12 A backend/manager/modules/uutils/src/test/resources/ticket/ca2.jks M ovirt-engine.spec.in A packaging/pythonlib/ovirt_engine/ticket.py M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.conf.in M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py 17 files changed, 548 insertions(+), 174 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc87ea4a4ea540dfea09e40f4396d6918e34e019 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: add FC Support
by sbonazzo＠redhat.com 23 Feb '15

23 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: add FC Support ...................................................................... packaging: setup: add FC Support Add FC Support to Hosted Engine. See feature page: http://www.ovirt.org/Features/Self_Hosted_Engine_FC_Support for documentation. Change-Id: I344ee4cdc724a8499c451adbcd8860c3d1e20c27 Bug-Url: https://bugzilla.redhat.com/1153278 Bug-Url: https://bugzilla.redhat.com/1036731 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py M src/plugins/ovirt-hosted-engine-setup/storage/Makefile.am M src/plugins/ovirt-hosted-engine-setup/storage/__init__.py R src/plugins/ovirt-hosted-engine-setup/storage/blockd.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M src/plugins/ovirt-hosted-engine-setup/vm/image.py 7 files changed, 174 insertions(+), 98 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/37830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I344ee4cdc724a8499c451adbcd8860c3d1e20c27 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Set geo-rep config Bll command
by kmayilsa＠redhat.com 23 Feb '15

23 Feb '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine : Set geo-rep config Bll command ...................................................................... engine : Set geo-rep config Bll command This patch adds bll command to set geo-rep config. Change-Id: I4d98636a688f9565dff0c86c8820839cb99b1a38 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepConfigListQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetDefaultGeoRepConfigCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepSessionConfigParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionConfiguration.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M packaging/dbscripts/create_views.sql M packaging/dbscripts/gluster_georep_sp.sql A packaging/dbscripts/upgrade/03_06_0900_add_gluster_config_master_table.sql A packaging/dbscripts/upgrade/03_06_0910_insert_config_description.sql A packaging/dbscripts/upgrade/03_06_0920_gluster_geo_rep_alter_config_value_column.sql 23 files changed, 344 insertions(+), 27 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d98636a688f9565dff0c86c8820839cb99b1a38 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Added missing error codes
by kmayilsa＠redhat.com 23 Feb '15

23 Feb '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine : Added missing error codes ...................................................................... engine : Added missing error codes This patch adds a generic geo-rep exception which is the generic parent of all geo-replication exceptions exposed by the vdsm. Change-Id: I6ed434a3d6eaca4609c5b5a2c736b8c2330068d6 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 4 files changed, 6 insertions(+), 0 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ed434a3d6eaca4609c5b5a2c736b8c2330068d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0