- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: replace init with postConstruct for import
by ahadas＠redhat.com 22 Feb '15

22 Feb '15

Arik Hadas has submitted this change and it was merged. Change subject: core: replace init with postConstruct for import ...................................................................... core: replace init with postConstruct for import Replace ImportVmCommandBase#init with postConstruct. Change-Id: I34274806d69a80d55110282ec2ef69bfb7891593 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 5 files changed, 17 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/38020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34274806d69a80d55110282ec2ef69bfb7891593 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: lock name of imported vm in base command
by ahadas＠redhat.com 22 Feb '15

22 Feb '15

Arik Hadas has submitted this change and it was merged. Change subject: core: lock name of imported vm in base command ...................................................................... core: lock name of imported vm in base command Move the name lock of imported VM to reside in ImportVmCommandBase so all import commands will use it. Change-Id: I59ed68ad2eecd657afc4a5302d14a95bee23729d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java 2 files changed, 21 insertions(+), 17 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/38019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59ed68ad2eecd657afc4a5302d14a95bee23729d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Uppercase 'U' in 'user initiated console session'
by ofrenkel＠redhat.com 22 Feb '15

22 Feb '15

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Uppercase 'U' in 'user initiated console session' ...................................................................... engine: Uppercase 'U' in 'user initiated console session' Using uppercase letter 'U' in the message 'user <user> initiated console session for VM <VM>'. For consistency, other events start with uppercase letter. Change-Id: Iaa93509cdc0e8c4cc3693b8336810e0a6bb1ee6f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1193018 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/38025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa93509cdc0e8c4cc3693b8336810e0a6bb1ee6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Remove warning on adding Storage Domain
by derez＠redhat.com 22 Feb '15

22 Feb '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Remove warning on adding Storage Domain ...................................................................... webadmin: Remove warning on adding Storage Domain Remove warning message about uninitialized Data Center when adding a storage domain. Bug-Url: https://bugzilla.redhat.com/1081577 Change-Id: I2649992874687fa2ec85fc262cabfdfb332a142b Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 3 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Freddy Rolland: Verified -- To view, visit http://gerrit.ovirt.org/37445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2649992874687fa2ec85fc262cabfdfb332a142b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Append Numa dynamic data to static data
by rgolan＠redhat.com 22 Feb '15

22 Feb '15

Roy Golan has submitted this change and it was merged. Change subject: engine: Append Numa dynamic data to static data ...................................................................... engine: Append Numa dynamic data to static data Numa statistics were created into an empty VdsNumaNode and written to the DB. The correction append Numa statistics into existing VdsNumaNode static information. This is relevant only while doing capabilities refresh. Othewise it is OK to store VdsNumaNode with only statistical data. Bug-URl: bugzilla.redhat.com/1177154 Change-Id: I71a4b71348127aa479b13cb8ad5e39685252b518 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NumaUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 3 files changed, 26 insertions(+), 7 deletions(-) Approvals: Dudi Maroshi: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71a4b71348127aa479b13cb8ad5e39685252b518 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: MultipleActionsRunner refactor: extracted initCommands...
by masayag＠redhat.com 22 Feb '15

22 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: core: MultipleActionsRunner refactor: extracted initCommandsAndReturnValues method from execute() ...................................................................... core: MultipleActionsRunner refactor: extracted initCommandsAndReturnValues method from execute() method execute() is overgrown and disallowing modifications in subclasses. Change-Id: I99a501325f364aab789f04680e6c7c6999c38b7a Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java 1 file changed, 20 insertions(+), 16 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99a501325f364aab789f04680e6c7c6999c38b7a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: MultipleActionsRunner refactor: extracted canRunAction...
by masayag＠redhat.com 22 Feb '15

22 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: core: MultipleActionsRunner refactor: extracted canRunActions method from execute() ...................................................................... core: MultipleActionsRunner refactor: extracted canRunActions method from execute() method execute() is overgrown and disallowing modifications in subclasses. There are Commands written in a way disallowing separating method calls of 'canDoAction'and 'execute'. Calling all 'canDoAction' methods prior to calling first 'execute' yields bad results, therefore, canDoAction have to be called prior to respective execute method. Change-Id: Id0c8b741d5a8ddce3caf5177d77285132bb1053b Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0c8b741d5a8ddce3caf5177d77285132bb1053b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: MultipleActionsRunner refactor: extracted canRunAction...
by masayag＠redhat.com 22 Feb '15

22 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: core: MultipleActionsRunner refactor: extracted canRunActions method from execute() ...................................................................... core: MultipleActionsRunner refactor: extracted canRunActions method from execute() method execute() is overgrown and disallowing modifications in subclasses. There are Commands written in a way disallowing separating method calls of 'canDoAction'and 'execute'. Calling all 'canDoAction' methods prior to calling first 'execute' yields bad results, therefore, canDoAction have to be called prior to respective execute method. Change-Id: I4b8b3f5a53402b6ceb4dc66cb4f137d7882f6b9f Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java 1 file changed, 19 insertions(+), 16 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b8b3f5a53402b6ceb4dc66cb4f137d7882f6b9f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use failCanDoAction instead return false
by mlipchuk＠redhat.com 22 Feb '15

22 Feb '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: use failCanDoAction instead return false ...................................................................... core: use failCanDoAction instead return false Use the existing failCanDoAction on RemoveStorageDomain instead the existing return false Change-Id: Ief84a89341c6cda7bdea858849b40529d1adfb4f Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/37986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief84a89341c6cda7bdea858849b40529d1adfb4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Validate if Storage is attached before format.
by mlipchuk＠redhat.com 22 Feb '15

22 Feb '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate if Storage is attached before format. ...................................................................... core: Validate if Storage is attached before format. Add validation to check if the Storage Domain is attached to a Data Center before formatting it. Also adding a new CDA which indicates how the user should work around it. Change-Id: I327705b1bb333e9b27ea8e67057966a7b62d8efc Bug-Url: https://bugzilla.redhat.com/1179899 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 42 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I327705b1bb333e9b27ea8e67057966a7b62d8efc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0