- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Determine whether to fetch ISO domain images list ...
by tnisan＠redhat.com 21 Jan '15

21 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Determine whether to fetch ISO domain images list correctly ...................................................................... webadmin: Determine whether to fetch ISO domain images list correctly Change-Id: I6cb6201209227e0968b600817dfc1e40ed327cbf Bug-Url: https://bugzilla.redhat.com/1184535 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cb6201209227e0968b600817dfc1e40ed327cbf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Determine whether to fetch ISO domain images list ...
by tnisan＠redhat.com 21 Jan '15

21 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Determine whether to fetch ISO domain images list correctly ...................................................................... webadmin: Determine whether to fetch ISO domain images list correctly Change-Id: I6cb6201209227e0968b600817dfc1e40ed327cbf Bug-Url: https://bugzilla.redhat.com/1184535 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cb6201209227e0968b600817dfc1e40ed327cbf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, restapi: Glance import - custom disk and template name
by derez＠redhat.com 21 Jan '15

21 Jan '15

Daniel Erez has submitted this change and it was merged. Change subject: core,restapi: Glance import - custom disk and template name ...................................................................... core,restapi: Glance import - custom disk and template name Import Glance image - allow specifying custom disk name and/or template name (when importing as template). E.g. <action> <disk> <alias>imported-disk</alias> </disk> <template> <name>imported-template</name> </template> <import_as_template>true</import_as_template> <storage_domain> <name>data1</name> </storage_domain> <cluster> <name>Default</name> </cluster> </action> Change-Id: I19da074f7b6ae9d5a0c943c3a7dc6b90a3db03f0 Bug-Url: https://bugzilla.redhat.com/1183972 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportRepoImageParameters.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java 6 files changed, 30 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19da074f7b6ae9d5a0c943c3a7dc6b90a3db03f0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove usage of PreparingForHibernate status
by ahadas＠redhat.com 21 Jan '15

21 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: core: remove usage of PreparingForHibernate status ...................................................................... core: remove usage of PreparingForHibernate status Now that the VM is locked for the entire operation of the hibernate command, there is no need to set the status of the VM to PreparingForHibernate. Change-Id: I1b8a8ab2e3e2dee634b6ecb5a22ad9a0f172c723 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 1 file changed, 2 insertions(+), 55 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/37175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b8a8ab2e3e2dee634b6ecb5a22ad9a0f172c723 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.5]: build: ovirt-live-3.5.1
by sbonazzo＠redhat.com 21 Jan '15

21 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.5.1 ...................................................................... build: ovirt-live-3.5.1 Change-Id: I030bc73ccf80dccbed9544ab98cb6fd4a0a5e854 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I030bc73ccf80dccbed9544ab98cb6fd4a0a5e854 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix typos in VdsManager
by rgolan＠redhat.com 21 Jan '15

21 Jan '15

Roy Golan has submitted this change and it was merged. Change subject: core: Fix typos in VdsManager ...................................................................... core: Fix typos in VdsManager Fixes typos in VdsManager method names. Change-Id: Id7f710890061ac73753d00c0a9cbe8056258e56d Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7f710890061ac73753d00c0a9cbe8056258e56d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: build: ovirt-release35-002
by sbonazzo＠redhat.com 21 Jan '15

21 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release35-002 ...................................................................... build: ovirt-release35-002 Change-Id: I326e68f2034739862ac769a294a6caa2f0fc67a5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.5/configure.ac M ovirt-release-3.5/ovirt-release35.spec.in 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I326e68f2034739862ac769a294a6caa2f0fc67a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: remove unneeded checks on end of hibernate command
by ahadas＠redhat.com 21 Jan '15

21 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: core: remove unneeded checks on end of hibernate command ...................................................................... core: remove unneeded checks on end of hibernate command Now that the VM is locked for the entire operation of the hibernate command, there is no point to check if the VM is null since it cannot be removed while the operation is in-progress. Change-Id: Ia86cb3389f841db60fcdcb4577c8449b5eb4d7fc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 1 file changed, 44 insertions(+), 59 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/37174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia86cb3389f841db60fcdcb4577c8449b5eb4d7fc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: lock vm for whole hibernate command life cycle
by ahadas＠redhat.com 21 Jan '15

21 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: core: lock vm for whole hibernate command life cycle ...................................................................... core: lock vm for whole hibernate command life cycle Change the VM lock which is acquired in the hibernate command such that it will not be released at the end of the execute phase but will remain for the whole life-cycle of the command. Relevant message that indicates the VM is being hibernated is added to the lock. Currently this change does not do much as the VM is switched to prepare-to-hibernate status anyway, but this is a step towards removing this status. Change-Id: I7a00eeb74338469339740e0fb20b71b8f849fc02 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 17 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/37173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a00eeb74338469339740e0fb20b71b8f849fc02 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: reverted removal of selectedItemsChanged method.
by lvernia＠redhat.com 21 Jan '15

21 Jan '15

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: reverted removal of selectedItemsChanged method. ...................................................................... webadmin: reverted removal of selectedItemsChanged method. This method was mistakingly removed as a part of one big refactor. Apparently it was removed because it seems that this method does the same thing as overriden one, but that's not true, both calls their private equally named method. This could be fixed by making that method protected, but after some research this is not easily doable, so I just returned removed method back and place warning comment to method being overridden. Change-Id: I473566cf0755519eb7fc922c435ae8a2ee545779 Bug-Url: https://bugzilla.redhat.com/1180897 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I473566cf0755519eb7fc922c435ae8a2ee545779 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0