- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add role of VM run time manager.
by mlipchuk＠redhat.com 21 Jan '15

21 Jan '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add role of VM run time manager. ...................................................................... core: Add role of VM run time manager. Adding a new pre-defined role of VM run time operator which will act the same as VMOperator only without the permissions for create snapshot. Change-Id: Ifc0e2484aabee5779d6bfaf44e25bab0511e8e16 Bug-Url: https://bugzilla.redhat.com/1111095 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PredefinedRoles.java A packaging/dbscripts/upgrade/03_06_0770_add_vm_run_time_permissions.sql 2 files changed, 25 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc0e2484aabee5779d6bfaf44e25bab0511e8e16 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: fixing the check of ISO image permission
by sbonazzo＠redhat.com 21 Jan '15

21 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fixing the check of ISO image permission ...................................................................... packaging: setup: fixing the check of ISO image permission Fixing ISO image permission check against qemu user Change-Id: I3445e536f4f22b7ccdad1163b4be8afe1c8a69af Bug-Url: https://bugzilla.redhat.com/1181585 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 4c2ffae5bdeaf311c120711f1049f820abff2259) --- M src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/36838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3445e536f4f22b7ccdad1163b4be8afe1c8a69af Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix broken AddStorageDomainCommonTest
by amureini＠redhat.com 20 Jan '15

20 Jan '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix broken AddStorageDomainCommonTest ...................................................................... core: Fix broken AddStorageDomainCommonTest AddStorageDomainCommonTest was broken by commit ee99c6df50d4ab5ed2564d4549723a13d3dcd1df, which changed the production code but neglected to change the test accordingly. Change-Id: I66f79ad3246fb59a673250745fc23fa264bd329b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66f79ad3246fb59a673250745fc23fa264bd329b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: build: post ovirt-engine-3.5.1 branching
by tnisan＠redhat.com 20 Jan '15

20 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-3.5.1 branching ...................................................................... build: post ovirt-engine-3.5.1 branching Change-Id: I8a38d2e739d7451b6e35fed5b94c4c9ade9ecab2 Bug-Url: https://bugzilla.redhat.com/1155170 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 49 files changed, 49 insertions(+), 49 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a38d2e739d7451b6e35fed5b94c4c9ade9ecab2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: display of template disk's disk profile
by tnisan＠redhat.com 20 Jan '15

20 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: display of template disk's disk profile ...................................................................... webadmin: display of template disk's disk profile When a template disk is cloned, only one of the disk profiles is shown in general tab. Change-Id: I889015e636bba1ef988fb7a22e40df435e4bb9c9 Bug-Url: https://bugzilla.redhat.com/1178006 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> (cherry picked from commit 7124e51b96aa15c515484ce71b3a06ce4cdc319b) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/37121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I889015e636bba1ef988fb7a22e40df435e4bb9c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix import glance image as template
by derez＠redhat.com 20 Jan '15

20 Jan '15

Daniel Erez has submitted this change and it was merged. Change subject: core: fix import glance image as template ...................................................................... core: fix import glance image as template Importing Glance image as a template from rest-api leads to an NPE due to null user in AddVmTemplateCommand [getCurrentUser() is null]. Fixed by ensuring a valid user from the parameters (instead of setting on ImportRepoImageCommand ctr). Change-Id: I5a34e200ea135469d174f337b802c83a3a1e9052 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a34e200ea135469d174f337b802c83a3a1e9052 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: show cpu profile field for edit template
by gchaplik＠redhat.com 20 Jan '15

20 Jan '15

Gilad Chaplik has submitted this change and it was merged. Change subject: frontend: show cpu profile field for edit template ...................................................................... frontend: show cpu profile field for edit template currently it's hidden since resouce allocation tab within VM's dialog is hidden Change-Id: I26046b23f4931a7c40a1bc53d3d95a8518531e94 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/template/TemplateNewPopupWidget.java 3 files changed, 27 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/33904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26046b23f4931a7c40a1bc53d3d95a8518531e94 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Message fixing for adding an ISO domain on a block dom...
by tnisan＠redhat.com 20 Jan '15

20 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Message fixing for adding an ISO domain on a block domain. ...................................................................... core: Message fixing for adding an ISO domain on a block domain. Adding an ISO domain on a block domain which is not supported gave an uninformative error message. the message was replaced to another message which fits better to this action. Change-Id: Id5b3dc26fb21a876ce6adaa50ec6c35bc38ce0b1 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/36399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5b3dc26fb21a876ce6adaa50ec6c35bc38ce0b1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL fix.
by tnisan＠redhat.com 20 Jan '15

20 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL fix. ...................................................................... engine: ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL fix. ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL user message was set to "Storage Domain type not specified" which does not correlate with the message's name and usage. Change-Id: I2c8c7925c196bfe40f46682d81a81852e594f6f7 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c8c7925c196bfe40f46682d81a81852e594f6f7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Prevent Export domains on block storage
by tnisan＠redhat.com 20 Jan '15

20 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Prevent Export domains on block storage ...................................................................... core: Prevent Export domains on block storage Block domains do not support export type. Thus a validation was added in AddStorageDomainCommand CDA. Change-Id: I80f68c866e583152b80780554f5529eb720e0759 Bug-Url: https://bugzilla.redhat.com/1065989 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 26 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80f68c866e583152b80780554f5529eb720e0759 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0