- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: RFE: sysprep file name should be according to its version
by shavivi＠redhat.com 09 Nov '14

09 Nov '14

Shahar Havivi has submitted this change and it was merged. Change subject: RFE: sysprep file name should be according to its version ...................................................................... RFE: sysprep file name should be according to its version We are using sysprep inside a floppy by the filename: sysprep.inf, - which is what sysprep is looking for in .ini file format that was in xp and 2003. The new format is xml and the filename should be "Unattend.xml" for this versions. Change-Id: Ie1aff3a70c4d34c3e4ba74152e61551f09d33fff Bug-Url: https://bugzilla.redhat.com/1145999 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/src/main/antlr4/org/ovirt/engine/core/utils/osinfo/Osinfo.g4 M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M packaging/conf/osinfo-defaults.properties 6 files changed, 39 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1aff3a70c4d34c3e4ba74152e61551f09d33fff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Date formatting when deleting a snapshot
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Date formatting when deleting a snapshot ...................................................................... webadmin: Date formatting when deleting a snapshot When deleting a VM's snapshot a formatted date is now shown based on a constant taken from another component in the system (DiskGeneralModel) for system consistency. this constant is intended to be exported to some util class later on. Bug-Url: https://bugzilla.redhat.com/1158959 Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/34966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: history: updated required changes 3.5.1
by ydary＠redhat.com 09 Nov '14

09 Nov '14

Yaniv Dary has submitted this change and it was merged. Change subject: history: updated required changes 3.5.1 ...................................................................... history: updated required changes 3.5.1 Change-Id: I251e39973901c25cb997ababb8b9ebc40e5b790b Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/ovirt_engine_dwh/minimalversioncheck_3_5/contexts/Default.properties M etl_export/ovirt_engine_dwh/parallelrun_3_5/contexts/Default.properties M etl_export/ovirt_engine_dwh/validateinstallation_3_5/contexts/Default.properties M tos_project/context/connectionJDBC_3.5.item M tos_project/process/HistoryETL_3.5.item M tos_project/process/MinimalVersionCheck_3.5.item M tos_project/process/ParallelRun_3.5.item M tos_project/process/ValidateInstallation_3.5.item 8 files changed, 8 insertions(+), 8 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I251e39973901c25cb997ababb8b9ebc40e5b790b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Clear Inactive ISO Domain Images List
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Clear Inactive ISO Domain Images List ...................................................................... frontend: Clear Inactive ISO Domain Images List When an ISO domain is not active, navigating to its images subtab should not query for the images, but show an empty list. Change-Id: Idb29eb14a07a8084b62bda5ac41769ce964bac16 Bug-Url: https://bugzilla.redhat.com/1155191 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/34853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb29eb14a07a8084b62bda5ac41769ce964bac16 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Avoid NPE in request for CDROMs of wrong VM
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Avoid NPE in request for CDROMs of wrong VM ...................................................................... restapi: Avoid NPE in request for CDROMs of wrong VM Currently when we receive a request for the collection of CDROMs of a VM we don't take into account that the query performed to find the VM can return null if there isn't such a VM (the identifier is wrong, or the VM has been removed). To avoid that NPE this patch checks the result of the query and will respond with an empty list in those cases. Change-Id: Id17ef36193c21e113d4abafeee0c769a2a948bd3 Bug-Url: https://bugzilla.redhat.com/1150953 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit f1dc8f77e611a2b8f40ddac822032632833d4eb0) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id17ef36193c21e113d4abafeee0c769a2a948bd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fixed UI for popup New CPU QoS
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fixed UI for popup New CPU QoS ...................................................................... webadmin: Fixed UI for popup New CPU QoS In the popup "New CPU Qos", the scroll bar was removed and also, margin was added for the "Limit" textbox so it will be aligned with the rest of the textboxes. Color for the "Limit" row wasn't changed(It was decided to leave it as is). Change-Id: I4aebf602a70b7b65f65d45e388b5d49296ed0be7 Bug-Url: https://bugzilla.redhat.com/1142813 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/CpuQosPopupView.ui.xml 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4aebf602a70b7b65f65d45e388b5d49296ed0be7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fixed out of frame load balancer boxes.
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fixed out of frame load balancer boxes. ...................................................................... webadmin: Fixed out of frame load balancer boxes. In the "New Scheduling Policy" dialog, extended the height of the frame. Also, Added new css style "separatorStyle" with margins for the seperators to adjust the style to the height change. Change-Id: Ic4342dc06d11d0d7c884e9f6b0ecbc25b3934db5 Bug-Url: https://bugzilla.redhat.com/1142897 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Tomer Saban: Verified Gilad Chaplik: Looks good to me, approved Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4342dc06d11d0d7c884e9f6b0ecbc25b3934db5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Revert "core: Improve performance of getdisksvmguid"
by tnisan＠redhat.com 09 Nov '14

09 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: Revert "core: Improve performance of getdisksvmguid" ...................................................................... Revert "core: Improve performance of getdisksvmguid" This reverts commit d9e489471aaf0113fac7dff63845dee6f7f4523e. UNION removes duplicate records, UNION ALL does not. Hence, 'all_disks_including_snapshots' view includes duplicate records for copied template disks. Performance improvement should probably be achieved in another way. In the mean time, reverting this change. Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Bug-Url: https://bugzilla.redhat.com/1161612 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: doc: README: update fakeqemu section
by Alon Bar-Lev 09 Nov '14

09 Nov '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: README: update fakeqemu section ...................................................................... doc: README: update fakeqemu section Change-Id: I7c8a5598ae4d0ac5213f626e8b51d7aebbfd871e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c8a5598ae4d0ac5213f626e8b51d7aebbfd871e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Revert "core: Improve performance of getdisksvmguid"
by amureini＠redhat.com 09 Nov '14

09 Nov '14

Allon Mureinik has submitted this change and it was merged. Change subject: Revert "core: Improve performance of getdisksvmguid" ...................................................................... Revert "core: Improve performance of getdisksvmguid" This reverts commit d9e489471aaf0113fac7dff63845dee6f7f4523e. UNION removes duplicate records, UNION ALL does not. Hence, 'all_disks_including_snapshots' view includes duplicate records for copied template disks. Performance improvement should probably be achieved in another way. In the mean time, reverting this change. Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Bug-Url: https://bugzilla.redhat.com/1161612 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0