- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: readonly label editors
by awels＠redhat.com 06 Nov '14

06 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: readonly label editors ...................................................................... webadmin: readonly label editors - Modified readonly label editors to not use a parser as they are readonly. This fixes potential issues different locales as the values in different locales will not properly parse back into their original values. Change-Id: I5d485f40d574df26ab4b4a0f6f60679e2c2b2506 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ManageGlusterSwiftPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java 4 files changed, 5 insertions(+), 54 deletions(-) Approvals: Alexander Wels: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d485f40d574df26ab4b4a0f6f60679e2c2b2506 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: notifier: extend event filter documentation at config file.
by oourfali＠redhat.com 06 Nov '14

06 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: notifier: extend event filter documentation at config file. ...................................................................... notifier: extend event filter documentation at config file. Change-Id: Ie1596a00cf079227020167e519a5287c6d5f9cca Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1596a00cf079227020167e519a5287c6d5f9cca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainI...
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainIdForPoolByType ...................................................................... core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainIdForPoolByType The method's parameters types are clear enough, so there's no need to include them also in the method's name. Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Related-To: https://bugzilla.redhat.com/1085398 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/34865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool ...................................................................... core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool The method's parameters types are clear enough, so there's no need to include them also in the method's name. Change-Id: Iffc63c3a22488e459be3c9beac9dd5d0163f0d12 Related-To: https://bugzilla.redhat.com/1085398 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java 4 files changed, 8 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified Objections: automation(a)ovirt.org: Fails -- To view, visit http://gerrit.ovirt.org/34864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffc63c3a22488e459be3c9beac9dd5d0163f0d12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Renamed the getStorageDomainId Method
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Renamed the getStorageDomainId Method ...................................................................... core: Renamed the getStorageDomainId Method The method's name implies that it's a simple getter, even though it does not always return the expected storage domain even if it exists (permissions issues for example). Thus, renamed to getStorageDomainIdForQuery. Change-Id: I93e7fdda6ffacb0fc1fd740fe69390864100ab7b Related-To: https://bugzilla.redhat.com/1085398 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQueryTest.java 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/34863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93e7fdda6ffacb0fc1fd740fe69390864100ab7b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: packaging: fixes a warning while building
by juan.hernandez＠redhat.com 06 Nov '14

06 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: fixes a warning while building ...................................................................... packaging: fixes a warning while building [WARNING] [WARNING] Some problems were encountered while building the effective model for org.ovirt.engine.sdk:ovirt-engine-sdk-java:jar:3.6.0.0-SNAPSHOT [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-eclipse-plugin is missing. @ line 143, column 25 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] Change-Id: I2924b7deb5b712e472721ea53bfa8d87513e2516 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2924b7deb5b712e472721ea53bfa8d87513e2516 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: packaging: spec: update spec syntax
by juan.hernandez＠redhat.com 06 Nov '14

06 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: spec: update spec syntax ...................................................................... packaging: spec: update spec syntax Solves: *************************************************************** * WARNING! mvn-rpmbuild is deprecated and it will be removed * * in future. Users should migrate to using %mvn_build macro * * or call XMvn directly if greater flexibility is required. * *************************************************************** Change-Id: Ib81f345772db5da4d23cf1ee917b3d11e85b3ed6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib81f345772db5da4d23cf1ee917b3d11e85b3ed6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: packaging: spec: add support for EL7 builds
by juan.hernandez＠redhat.com 06 Nov '14

06 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: spec: add support for EL7 builds ...................................................................... packaging: spec: add support for EL7 builds Change-Id: I1672e50c4977b4fb1ad97da9e661d5794b11d1e9 Bug-Url: https://bugzilla.redhat.com/1159293 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1672e50c4977b4fb1ad97da9e661d5794b11d1e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: configuring cluster CPU type only on the f...
by sbonazzo＠redhat.com 06 Nov '14

06 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: configuring cluster CPU type only on the first host ...................................................................... packaging: setup: configuring cluster CPU type only on the first host No need to reconfigure the cluster CPU type for each additional host Change-Id: I82916788b8e2582bbf3bebc3c285e1833b7678ad Bug-Url: https://bugzilla.redhat.com/1086032 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit e4cfeb8859a009d2363f738a10b348a61f1250a0) --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 42 insertions(+), 36 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82916788b8e2582bbf3bebc3c285e1833b7678ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: configuring cluster CPU type only on the f...
by sbonazzo＠redhat.com 06 Nov '14

06 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: configuring cluster CPU type only on the first host ...................................................................... packaging: setup: configuring cluster CPU type only on the first host No need to reconfigure the cluster CPU type for each additional host Change-Id: I82916788b8e2582bbf3bebc3c285e1833b7678ad Bug-Url: https://bugzilla.redhat.com/1086032 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 42 insertions(+), 36 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/34834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82916788b8e2582bbf3bebc3c285e1833b7678ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0