- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: added support for optionally select the target cluster
by tjelinek＠redhat.com 30 Oct '14

30 Oct '14

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: added support for optionally select the target cluster ...................................................................... restapi: added support for optionally select the target cluster An optional parameter cluste.id has been added to the migrate. Change-Id: I66aa4041b5308fe4f7f1038f53715cd78c5c279f Bug-Url: https://bugzilla.redhat.com/1150191 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 3 files changed, 28 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66aa4041b5308fe4f7f1038f53715cd78c5c279f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: allow migration to different cluster
by tjelinek＠redhat.com 30 Oct '14

30 Oct '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: allow migration to different cluster ...................................................................... webadmin: allow migration to different cluster Added a list box into the advanced parameters which lets the user change the destination cluster. Since this is quite a dangerous task, added also a warning. Change-Id: I224ac719d16b348bb8ea31b256fe459bc372a88d Bug-Url: https://bugzilla.redhat.com/1150191 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MigrateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMigratePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMigratePopupView.ui.xml 6 files changed, 201 insertions(+), 84 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I224ac719d16b348bb8ea31b256fe459bc372a88d Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: enable migration to a different cluster
by tjelinek＠redhat.com 30 Oct '14

30 Oct '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: enable migration to a different cluster ...................................................................... core: enable migration to a different cluster Added a possibility to define the target cluster for the migration. Change-Id: I9eb4fd7f10d3b0e63455a81f0b5c1389586a43f4 Bug-Url: https://bugzilla.redhat.com/1150191 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmToServerParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 265 insertions(+), 170 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eb4fd7f10d3b0e63455a81f0b5c1389586a43f4 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainI...
by tnisan＠redhat.com 30 Oct '14

30 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainIdForPoolByType ...................................................................... core: Renamed StorageDomainDAODbFacadeImpl.getStorageDomainIdForPoolByType The method's parameters types are clear enough, so there's no need to include them also in the method's name. Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Related-To: https://bugzilla.redhat.com/1085398 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/34030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool
by tnisan＠redhat.com 30 Oct '14

30 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool ...................................................................... core: Renamed StorageDomainDAO.getStorageDomainByTypeAndPool The method's parameters types are clear enough, so there's no need to include them also in the method's name. Change-Id: Iffc63c3a22488e459be3c9beac9dd5d0163f0d12 Related-To: https://bugzilla.redhat.com/1085398 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java 4 files changed, 8 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffc63c3a22488e459be3c9beac9dd5d0163f0d12 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Renamed the getStorageDomainId Method
by tnisan＠redhat.com 30 Oct '14

30 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Renamed the getStorageDomainId Method ...................................................................... core: Renamed the getStorageDomainId Method The method's name implies that it's a simple getter, even though it does not always return the expected storage domain even if it exists (permissions issues for example). Thus, renamed to getStorageDomainIdForQuery. Change-Id: I93e7fdda6ffacb0fc1fd740fe69390864100ab7b Related-To: https://bugzilla.redhat.com/1085398 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQueryTest.java 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/34028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93e7fdda6ffacb0fc1fd740fe69390864100ab7b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Engine: set device-id in payload constructor
by tnisan＠redhat.com 30 Oct '14

30 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: Engine: set device-id in payload constructor ...................................................................... Engine: set device-id in payload constructor When adding a new payload its device id need to set since it is inherit from VmDevice now - This is true for the default constructor. Change-Id: I33bdc975070d71923ae21985a371b53d427b61d8 Bug-Url: https://bugzilla.redhat.com/1158010 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33bdc975070d71923ae21985a371b53d427b61d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove redundant method in QueryData class
by yzaslavs＠redhat.com 30 Oct '14

30 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Remove redundant method in QueryData class ...................................................................... core: Remove redundant method in QueryData class Change-Id: Ibc4a6f2717eef97c7b11f03f4dc83b3fec57bba6 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc4a6f2717eef97c7b11f03f4dc83b3fec57bba6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: extapi: provide configuration file name
by oourfali＠redhat.com 30 Oct '14

30 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: extapi: provide configuration file name ...................................................................... extapi: provide configuration file name this will enable extension to use relative file names. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1158775 Change-Id: Ie380f38f1ef6a68bdfa58c3b17ab26ed0fbb37b3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/Base.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie380f38f1ef6a68bdfa58c3b17ab26ed0fbb37b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: engine-config didn't show HotUnplugCpuSupported value
by tnisan＠redhat.com 30 Oct '14

30 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: engine-config didn't show HotUnplugCpuSupported value ...................................................................... core: engine-config didn't show HotUnplugCpuSupported value add HotUnplugCpuSupported to vdc_options so engine-config utility could see the default value as well Change-Id: Ief7fe91d9947e778588ae2b73684ead68df8dc6b Bug-Url: https://bugzilla.redhat.com/1100430 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief7fe91d9947e778588ae2b73684ead68df8dc6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0