- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Code needs to run once, remove from loop
by lvernia＠redhat.com 30 Oct '14

30 Oct '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Code needs to run once, remove from loop ...................................................................... engine: Code needs to run once, remove from loop There was some code inside SetupNetworksVDSCommand that didn't require being inside the iteration of networks, extracted it out of the loop. Change-Id: I8778a6e08dc696353af95bd2be67fdb31f7f2882 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 4 files changed, 41 insertions(+), 19 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8778a6e08dc696353af95bd2be67fdb31f7f2882 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.5]: packaging: moving to 3.5.1-snapshot
by sbonazzo＠redhat.com 30 Oct '14

30 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: moving to 3.5.1-snapshot ...................................................................... packaging: moving to 3.5.1-snapshot Change-Id: Ifb8de0e8023f929f693aa8a77f61915b2551a848 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb8de0e8023f929f693aa8a77f61915b2551a848 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: setup: updated answer file
by sbonazzo＠redhat.com 30 Oct '14

30 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: updated answer file ...................................................................... setup: updated answer file updated answer file for avoiding prompt: [ INFO ] Stage: Setup validation Generated iptables rules are different from current ones. Do you want to review them? (Yes, No) [No]: Change-Id: Ie458dfeb79ab1f00d4435191de4e41931dde7e82 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie458dfeb79ab1f00d4435191de4e41931dde7e82 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: jobs: ovirt-reports_create-rpms
by dcaroest＠redhat.com 30 Oct '14

30 Oct '14

David Caro has submitted this change and it was merged. Change subject: jobs: ovirt-reports_create-rpms ...................................................................... jobs: ovirt-reports_create-rpms drop fedora 19 and add fedora 21 on master Change-Id: If70aa965d51c6b9897cf4838f49521030f81d4d1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/jobs/ovirt-reports/ovirt-reports_create-rpms.yaml 1 file changed, 24 insertions(+), 6 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If70aa965d51c6b9897cf4838f49521030f81d4d1 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: disable the mixing of RHEL6 and RHEL7 in one cluster
by tnisan＠redhat.com 30 Oct '14

30 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: disable the mixing of RHEL6 and RHEL7 in one cluster ...................................................................... core: disable the mixing of RHEL6 and RHEL7 in one cluster This patch handles the special case, that the RHEL6 and RHEL7 can not be mixed in one cluster even the emulated machines are the same. If the newly added host is not compatible with the rest of the hosts, it is turned to be non operational. Change-Id: Ieb6d41b1921a6caf946cba44a6c92ef86fef6bc8 Bug-Url: https://bugzilla.redhat.com/1150191 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MonitoringStrategyFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/MultipleServicesMonitoringStrategyTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategyTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M packaging/dbscripts/vds_sp.sql 14 files changed, 156 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb6d41b1921a6caf946cba44a6c92ef86fef6bc8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: added support for optionally select the target cluster
by tnisan＠redhat.com 30 Oct '14

30 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: added support for optionally select the target cluster ...................................................................... restapi: added support for optionally select the target cluster An optional parameter cluste.id has been added to the migrate. Change-Id: I66aa4041b5308fe4f7f1038f53715cd78c5c279f Bug-Url: https://bugzilla.redhat.com/1150191 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 3 files changed, 28 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66aa4041b5308fe4f7f1038f53715cd78c5c279f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: allow migration to different cluster
by tnisan＠redhat.com 30 Oct '14

30 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: allow migration to different cluster ...................................................................... webadmin: allow migration to different cluster Added a list box into the advanced parameters which lets the user change the destination cluster. Since this is quite a dangerous task, added also a warning. Change-Id: I224ac719d16b348bb8ea31b256fe459bc372a88d Bug-Url: https://bugzilla.redhat.com/1150191 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MigrateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMigratePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMigratePopupView.ui.xml 6 files changed, 203 insertions(+), 86 deletions(-) Approvals: Tomas Jelinek: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I224ac719d16b348bb8ea31b256fe459bc372a88d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin, branding: fix PatternFly impl for IE8
by tnisan＠redhat.com 30 Oct '14

30 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin, branding: fix PatternFly impl for IE8 ...................................................................... userportal, webadmin, branding: fix PatternFly impl for IE8 Our PatternFly implementation was not IE8 compliant. Needed to add respond.js and html5shiv.js. Everything now looks good in IE8. Major caveat with respond.js is that it will not follow CSS @import's, and we used them heavily. Changed branding to allow multiple CSS files as part of a branding theme. Then changed ovirt-brand to use all of the CSS files directly and removed all @import's. So now instead of ovirt-brand depending on one CSS file and that file importing a chain, all individual files are now referenced by the brand directly. Change-Id: I4b40eef0a1dbdab93d55ab5ea6c25bb9e70714c5 Bug-Url: https://bugzilla.redhat.com/1152656 Bug-Url: https://bugzilla.redhat.com/1152646 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java M backend/manager/modules/branding/src/main/resources/META-INF/obrand.tld A backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/stylesheets.tag M backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingThemeTest.java M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/01-test.brand/branding.properties M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M packaging/branding/ovirt.brand/branding.properties M packaging/branding/ovirt.brand/common.css M packaging/branding/ovirt.brand/user_portal.css M packaging/branding/ovirt.brand/web_admin.css M packaging/branding/ovirt.brand/welcome_style.css 17 files changed, 59 insertions(+), 31 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/34567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b40eef0a1dbdab93d55ab5ea6c25bb9e70714c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Fix npe in search when authz is not properly configured
by oourfali＠redhat.com 30 Oct '14

30 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Fix npe in search when authz is not properly configured ...................................................................... aaa: Fix npe in search when authz is not properly configured Topic: AAA NPE occured as the namespaces list returned null in case authz extension is not configured properly. Change-Id: Ic7b7c196b01f1572d6013996303f26ccd3d782d0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1158512 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7b7c196b01f1572d6013996303f26ccd3d782d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Cluster sub general tab broken
by tnisan＠redhat.com 30 Oct '14

30 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Cluster sub general tab broken ...................................................................... webadmin: Cluster sub general tab broken - For certain locales the cluster general sub tab would not popuplate its values. This was due to an exception being thrown in the value parser of read only fields. Since these field are readonly they don't need a parser. - Added a new EntityModelLabelEditor constructor without a parser that is meant for readonly fields. Change-Id: I9c7a911d7a6ecfe79ee006be46e0ef8e627b97e3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157380 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelLabelEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java 3 files changed, 21 insertions(+), 24 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c7a911d7a6ecfe79ee006be46e0ef8e627b97e3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0