- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: RunVmValidator storage allocation
by tnisan＠redhat.com 12 Oct '14

12 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: core: RunVmValidator storage allocation ...................................................................... core: RunVmValidator storage allocation This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch did this for RunVmValidator. In doing so, space allocation validation for stateless VM became redundant and was therefore removed. Change-Id: Ib3f7c7f31d738f84d356d4e89b05a21d4ca7a118 Bug-Url: https://bugzilla.redhat.com/1149809 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 3 files changed, 19 insertions(+), 54 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/33876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3f7c7f31d738f84d356d4e89b05a21d4ca7a118 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Reduce DB queries for interfaces in GetStats
by lvernia＠redhat.com 12 Oct '14

12 Oct '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Reduce DB queries for interfaces in GetStats ...................................................................... engine: Reduce DB queries for interfaces in GetStats The same data was fetched twice as part of the GetStats flow - now it is fetched only once and cached for reference during the flow. Change-Id: I0581f29b368fdf5771aeace2c5c200f726bdb912 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStatsVDSCommand.java 2 files changed, 23 insertions(+), 11 deletions(-) Approvals: Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0581f29b368fdf5771aeace2c5c200f726bdb912 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix button availability for qos subtab
by tnisan＠redhat.com 12 Oct '14

12 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix button availability for qos subtab ...................................................................... webadmin: fix button availability for qos subtab Change-Id: Ia91804df19b82c579254b8e87e5894133e74e7a3 Bug-Url: https://bugzilla.redhat.com/1142815 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> (cherry picked from commit 11d032c5587351730102a96ec04245bd5f0aa736) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/DataCenterQosListModel.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified -- To view, visit http://gerrit.ovirt.org/33899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia91804df19b82c579254b8e87e5894133e74e7a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Added Qos per profile when removing qos
by tnisan＠redhat.com 12 Oct '14

12 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Added Qos per profile when removing qos ...................................................................... webadmin: Added Qos per profile when removing qos When removing multiple qos for datacenter which are connected to storage profiles a message appears which state which profiles are connected to those qos, but without stating which qos belong to each profile(This is a problem only when selecting multiple qos for removal). The following fix adds the associated qos to each profile name in the message. Change-Id: I474d38f934f8aaef482f06a81603bbd8566cb871 Bug-Url: https://bugzilla.redhat.com/1142854 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> (cherry picked from commit a5798e2354c94daf7b5177281aee9dc9998501b3) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/RemoveQosModel.java 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified -- To view, visit http://gerrit.ovirt.org/33900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I474d38f934f8aaef482f06a81603bbd8566cb871 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: fixing remote engine pki common code usage...
by sradco＠redhat.com 12 Oct '14

12 Oct '14

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: fixing remote engine pki common code usage on upgrades ...................................................................... packaging: setup: fixing remote engine pki common code usage on upgrades Change-Id: I011db10e16bb931c1610bc6645410917e722218d Bug-Url: https://bugzilla.redhat.com/1150116 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py 2 files changed, 9 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Simone Tiraboschi: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I011db10e16bb931c1610bc6645410917e722218d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: close button
by piotr.kliczewski＠gmail.com 10 Oct '14

10 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: userportal,webadmin: close button ...................................................................... userportal,webadmin: close button - Removed a lot of the z-index changes and reverted to letting the browser figure it out. This solves all the following: - Unable to drag windows - Unable to close windows with X - Unable to click help icon. Change-Id: I990250c45783b3ba00ea7ee74d88e2bf6205f2f6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1150050 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/common.css M packaging/branding/ovirt.brand/gwt_common.css 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I990250c45783b3ba00ea7ee74d88e2bf6205f2f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.5]: upload: making it faster on el6
by sbonazzo＠redhat.com 10 Oct '14

10 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: making it faster on el6 ...................................................................... upload: making it faster on el6 Removing at all the usage of tarlib and gzip which are really slow on Python 2.6 Change-Id: Ie7a1cf9757429e8cf77745b39a4c1b9efeab6169 Bug-Url: https://bugzilla.redhat.com/1150922 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit c2a7f29207eb9b80e402c329e461d9976d60dba2) --- M src/__main__.py 1 file changed, 23 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7a1cf9757429e8cf77745b39a4c1b9efeab6169 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[master]: upload: making it faster on el6
by sbonazzo＠redhat.com 10 Oct '14

10 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: making it faster on el6 ...................................................................... upload: making it faster on el6 Removing at all the usage of tarlib and gzip which are really slow on Python 2.6 Change-Id: Ie7a1cf9757429e8cf77745b39a4c1b9efeab6169 Bug-Url: https://bugzilla.redhat.com/1150922 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 23 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/33976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7a1cf9757429e8cf77745b39a4c1b9efeab6169 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal,webadmin: close button
by awels＠redhat.com 09 Oct '14

09 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: close button ...................................................................... userportal,webadmin: close button - Removed a lot of the z-index changes and reverted to letting the browser figure it out. This solves all the following: - Unable to drag windows - Unable to close windows with X - Unable to click help icon. Change-Id: I990250c45783b3ba00ea7ee74d88e2bf6205f2f6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1150050 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/common.css M packaging/branding/ovirt.brand/gwt_common.css 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Greg Sheremeta: Verified; Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I990250c45783b3ba00ea7ee74d88e2bf6205f2f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.5]: build: oVirt Live 3.5.0 RC5
by sbonazzo＠redhat.com 09 Oct '14

09 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 3.5.0 RC5 ...................................................................... build: oVirt Live 3.5.0 RC5 Change-Id: I55512d99d438b26a28170d19252cad1a49e80645 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55512d99d438b26a28170d19252cad1a49e80645 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0